nuttxpr commented on PR #14456: URL: https://github.com/apache/nuttx/pull/14456#issuecomment-2429311386
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information: * **What functional part of the code is being changed?** Be specific, e.g., "the syslog implementation" or "signal handler execution". * **How does the change exactly work?** Briefly explain the technical approach, like "Instead of blocking on the mutex, the log message is written one character at a time." **Impact:** * The impact section should clearly state YES/NO for each item, even if describing it further. For example: * **Impact on user:** YES (Users relying on syslog within signal handlers will no longer experience deadlocks, particularly in SMP configurations) * **Impact on build:** While likely NO, confirm this explicitly. * **Impact on hardware:** This seems relevant as the issue mentions qemu-rv:ksmp64. Clarify if specific architectures or boards are impacted. * **Impact on documentation:** Does this fix require any documentation updates? **Testing:** * The provided testing information is very minimal. * Specify the build host details (OS, Compiler version). * Instead of just stating "qemu-rv:ksmp64", describe the specific test case used to reproduce the deadlock before and how the fix addresses it. **Overall:** The PR summary needs more detail, and the impact and testing sections require additional information for a comprehensive review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
