Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-22 Thread via GitHub
acassis merged PR #15877: URL: https://github.com/apache/nuttx/pull/15877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-21 Thread via GitHub
Laczen commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2676063437 > @Laczen please update the git commit message to include more info about the issue (like you explained in the Discord) @acassis my knowledge of NuttX, 6lowpan, and tcp is too limite

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-21 Thread via GitHub
acassis commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2675284297 @Laczen please update the git commit message to include more info about the issue (like you explained in the Discord) -- This is an automated message from the Apache Git Service. To res

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
Laczen commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2672523654 > @Laczen it is important to describe in the commit log message the problem you are fixing and what was causing it. Imagine someone that just ran gitk and saw your commit, they will ask th

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
acassis commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2672418242 > > @Laczen please include more context in the commit log message, tell us what happened and why this modification was necessary > > @acassis, @xiaoxiang781216, I thought it was cle

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #15877: URL: https://github.com/apache/nuttx/pull/15877#discussion_r1964065587 ## net/devif/ipv6_input.c: ## @@ -463,9 +463,15 @@ static int ipv6_in(FAR struct net_driver_s *dev) if ((dev->d_len > 0 && dev->d_lltype == NET_LL_IEEE

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
Laczen commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2672060550 > @Laczen please include more context in the commit log message, tell us what happened and why this modification was necessary @acassis, @xiaoxiang781216, I thought it was clear from

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
acassis commented on code in PR #15877: URL: https://github.com/apache/nuttx/pull/15877#discussion_r1963869478 ## net/devif/ipv6_input.c: ## @@ -463,9 +463,15 @@ static int ipv6_in(FAR struct net_driver_s *dev) if ((dev->d_len > 0 && dev->d_lltype == NET_LL_IEEE802154)

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #15877: URL: https://github.com/apache/nuttx/pull/15877#discussion_r1963851321 ## net/devif/ipv6_input.c: ## @@ -463,9 +463,15 @@ static int ipv6_in(FAR struct net_driver_s *dev) if ((dev->d_len > 0 && dev->d_lltype == NET_LL_IEEE

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
acassis commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2671682865 @wengzhe please take a look too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
acassis commented on PR #15877: URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2671681885 @Laczen please include more context in the commit log message, tell us what happened and why this modification was necessary -- This is an automated message from the Apache Git Service.

[PR] sixlowpan: improve tcp support. [nuttx]

2025-02-20 Thread via GitHub
Laczen opened a new pull request, #15877: URL: https://github.com/apache/nuttx/pull/15877 Update the handling of tcp packets over sixlowpan. `tcp_ipv6_input()` can update the dev->d_iob, so use this to send the response. ## Summary When using tcp over sixlowpan (e.g. for telnet