acassis commented on PR #15877:
URL: https://github.com/apache/nuttx/pull/15877#issuecomment-2672418242
> > @Laczen please include more context in the commit log message, tell us
what happened and why this modification was necessary
>
> @acassis, @xiaoxiang781216, I thought it was clear from the commit message
and the summary. It is just like resetting `ipv6` to the correct iob. As tcp
over sixlowpan was only possible since #15822 it was never discovered.
@Laczen it is important to describe in the commit log message the problem
you are fixing and what was causing it. Imagine someone that just ran gitk and
saw your commit, they will ask the same question that Xiang did: why the use a
new ipv6 variable instead of using the original?
You comment there is doesn't explain it:
/* Let 6LoWPAN handle the TCP output, the TCP output can be
* updated in dev->d_iob so we get this first.
*/
I think originally it was doing it as well, wasn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
