yamt commented on PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2594184662
> > * i suspect the "generic" error number used for the case where
conversion is not available might need to be per-operation.
>
> it's better to apply the complex approach util we hit
xiaoxiang781216 merged PR #15552:
URL: https://github.com/apache/nuttx/pull/15552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2591912795
> * i suspect the "generic" error number used for the case where conversion
is not available might need to be per-operation.
it's better to apply the complex approach util w
crafcat7 commented on code in PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#discussion_r1916001367
##
arch/sim/src/sim/posix/sim_hostfs.c:
##
@@ -233,7 +246,7 @@ nuttx_ssize_t host_read(int fd, void *buf, nuttx_size_t
count)
ret = -errno;
}
- return
yamt commented on code in PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915951045
##
arch/sim/src/sim/posix/sim_hostfs.c:
##
@@ -233,7 +246,7 @@ nuttx_ssize_t host_read(int fd, void *buf, nuttx_size_t
count)
ret = -errno;
}
- return ret;
crafcat7 commented on code in PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915930496
##
arch/sim/src/sim/posix/sim_hostfs.c:
##
@@ -279,7 +292,7 @@ int host_ioctl(int fd, int request, unsigned long arg)
{
/* Just call the ioctl routine */
- retu
yamt commented on PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2591607069
* i suspect the "generic" error number used for the case where conversion is
not available might need to be per-operation.
* what's your plan for other backends? (eg.
arch/xtensa/src/com
xiaoxiang781216 commented on code in PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#discussion_r1915891764
##
arch/sim/src/sim/posix/sim_hostfs.c:
##
@@ -299,7 +312,7 @@ void host_sync(int fd)
int host_dup(int fd)
{
- return dup(fd);
+ return host_errno_convert
xiaoxiang781216 commented on PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#issuecomment-259127
@yamt could you review the change match your expect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
nuttxpr commented on PR #15552:
URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2591545709
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements, al
crafcat7 opened a new pull request, #15552:
URL: https://github.com/apache/nuttx/pull/15552
## Summary
This PR comes from the discussion of
https://github.com/apache/nuttx/pull/15535#event-15924592365.
A common conversion interface `host_errno_convert` is provided in
`arch/sim/pos
11 matches
Mail list logo
