Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
hartmannathan commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1959813403 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memo

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
hartmannathan merged PR #15848: URL: https://github.com/apache/nuttx/pull/15848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
anchao commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1959260122 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memory barr

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-17 Thread via GitHub
anchao commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1958367568 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memory barr

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-17 Thread via GitHub
hartmannathan commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1958348577 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memo

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-17 Thread via GitHub
hartmannathan commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1958347638 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memo

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-16 Thread via GitHub
anchao commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1957562921 ## arch/arm/include/spinlock.h: ## @@ -63,12 +63,21 @@ *all memory accesses are complete */ -#define UP_DSB() __asm__ __volatile__ ("dsb sy" : : : "mem

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1957537628 ## arch/arm/include/spinlock.h: ## @@ -63,12 +63,21 @@ *all memory accesses are complete */ -#define UP_DSB() __asm__ __volatile__ ("dsb sy" :

[PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-16 Thread via GitHub
anchao opened a new pull request, #15848: URL: https://github.com/apache/nuttx/pull/15848 ## Summary arm/memory_barrier: fix build warning on GCC14 ``` nuttx/include/arch/spinlock.h:66:9: warning: "UP_DSB" redefined 66 | #define UP_DSB() __asm__ __volatile__ ("dsb sy" :

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-16 Thread via GitHub
nuttxpr commented on PR #15848: URL: https://github.com/apache/nuttx/pull/15848#issuecomment-2661861681 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al