Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
xiaoxiang781216 merged PR #11203: URL: https://github.com/apache/nuttx/pull/11203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
raiden00pl commented on code in PR #11203: URL: https://github.com/apache/nuttx/pull/11203#discussion_r1396128552 ## arch/arm/src/nrf91/Kconfig: ## @@ -742,4 +742,22 @@ config NRF91_MODEM_AT bool "Modem AT interface support" default y +config NRF91_MODEM_LTEM +

Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
raiden00pl commented on code in PR #11203: URL: https://github.com/apache/nuttx/pull/11203#discussion_r1396127436 ## arch/arm/src/nrf91/nrf91_modem.c: ## @@ -122,5 +159,22 @@ int nrf91_modem_initialize(void) nerr("nrf_modem_init failed %d\n", ret); } Review Comment:

Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
raiden00pl commented on code in PR #11203: URL: https://github.com/apache/nuttx/pull/11203#discussion_r1396127194 ## arch/arm/src/nrf91/nrf91_modem_gnss.c: ## @@ -0,0 +1,734 @@ +/ + * arch/arm/src/nrf91/

Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
acassis commented on code in PR #11203: URL: https://github.com/apache/nuttx/pull/11203#discussion_r1396072520 ## arch/arm/src/nrf91/Kconfig: ## @@ -742,4 +742,22 @@ config NRF91_MODEM_AT bool "Modem AT interface support" default y +config NRF91_MODEM_LTEM +

Re: [PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #11203: URL: https://github.com/apache/nuttx/pull/11203#discussion_r1395927882 ## arch/arm/src/nrf91/nrf91_modem_gnss.c: ## @@ -0,0 +1,734 @@ +/ + * arch/arm/src/n

[PR] nRF91: initial support for GNSS [nuttx]

2023-11-16 Thread via GitHub
raiden00pl opened a new pull request, #11203: URL: https://github.com/apache/nuttx/pull/11203 ## Summary ## Impact - sensors/gps: define the number of items in the satellite info list - drivers/sensors/Make.defs: cosmetics - nrf91/nrf91_modem_sock.c: fix printf warnings