Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-11 Thread via GitHub
xiaoxiang781216 merged PR #15125: URL: https://github.com/apache/nuttx/pull/15125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #15125: URL: https://github.com/apache/nuttx/pull/15125#discussion_r1879660184 ## boards/arm/mps/mps2-an500/configs/knsh/defconfig: ## @@ -61,7 +61,6 @@ CONFIG_READLINE_CMD_HISTORY=y CONFIG_RR_INTERVAL=200 CONFIG_SCHED_HPWORK=y CONFIG_S

Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-10 Thread via GitHub
anchao commented on code in PR #15125: URL: https://github.com/apache/nuttx/pull/15125#discussion_r1879462548 ## boards/arm/mps/mps2-an500/configs/knsh/defconfig: ## @@ -61,7 +61,6 @@ CONFIG_READLINE_CMD_HISTORY=y CONFIG_RR_INTERVAL=200 CONFIG_SCHED_HPWORK=y CONFIG_SCHED_HPWO

Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #15125: URL: https://github.com/apache/nuttx/pull/15125#discussion_r1879458610 ## boards/arm/mps/mps2-an500/configs/knsh/defconfig: ## @@ -61,7 +61,6 @@ CONFIG_READLINE_CMD_HISTORY=y CONFIG_RR_INTERVAL=200 CONFIG_SCHED_HPWORK=y CONFIG_S

Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #15125: URL: https://github.com/apache/nuttx/pull/15125#discussion_r1879458610 ## boards/arm/mps/mps2-an500/configs/knsh/defconfig: ## @@ -61,7 +61,6 @@ CONFIG_READLINE_CMD_HISTORY=y CONFIG_RR_INTERVAL=200 CONFIG_SCHED_HPWORK=y CONFIG_S

Re: [PR] libc/chdir: replace heap alloc to path buffer to improve performance [nuttx]

2024-12-10 Thread via GitHub
nuttxpr commented on PR #15125: URL: https://github.com/apache/nuttx/pull/15125#issuecomment-2533417220 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.