nuttxpr commented on PR #15125: URL: https://github.com/apache/nuttx/pull/15125#issuecomment-2533417220
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of *what* was changed, it lacks crucial details. Here's why: * **Insufficient Summary Detail:** The summary mentions performance improvement, but doesn't explain *why* the current implementation is slow or *how* the change improves performance (e.g., by how much?). It also lacks context on the functional part of the code being changed (beyond `libc/chdir`). * **Missing Impact Assessment:** "N/A" is insufficient. Even if the changes seem minor, each impact area needs to be explicitly addressed with a "YES" or "NO" and a brief explanation. For instance, even if there's no user-facing change, the impact on user should be explicitly stated as "NO - No changes to user interface or behavior." There might be implications for memory usage which should be discussed. * **Incomplete Testing Information:** While `sim/nsh` is mentioned, it's not enough. The PR needs to specify: * **Build Host Details:** OS, CPU architecture, compiler version used for building. * **Target Details:** Specific simulator configuration used (e.g., `sim:nsh`). * **Missing Logs:** The "Testing logs before change" and "Testing logs after change" sections are empty. These are crucial to demonstrate the improvement and that the functionality remains correct. Showing timing differences would be particularly helpful here. Even a simple "time ./nsh" before and after would be a big improvement. * **Missing Issue References:** If this change relates to a reported issue, the PR should reference the relevant NuttX or NuttX Apps issue. In short, the PR needs to provide substantially more detail in the Summary, Impact, and Testing sections to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
