Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
yamt commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2053222762 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.py Review

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2053185255 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
yamt commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2053174164 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.py Review

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2052299120 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2052299120 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2818102334 > cmake build is failing because it requires the host sources under posix or win. while i guess this file works for win as well, i probably will move it under posix because it's the only use

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-21 Thread via GitHub
yamt commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2052100070 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.py Review

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2052007027 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2817609527 cmake build is failing because it requires the host sources under posix or win. while i guess this file works for win as well, i probably will move it under posix because it's the only us

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2051915207 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.py Review

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2051911162 ## include/errno_defs.h: ## @@ -0,0 +1,311 @@ +/ + * include/errno_defs.h Review Comment: i

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2051907445 ## tools/mkerrno.py: ## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 + +# tools/mkerrno.

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2817461329 > hm, the latest nxstyle seems more nervous than the binary i happened to have. let me fix. done -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2817430558 hm, the latest nxstyle seems more nervous than the binary i happened to have. let me fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] generate errno definitions from CSV [nuttx]

2025-04-20 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2817428976 > > could you provide other patch? so I can understand the whole picture. > > ok. > > (it might take a bit long to find time to work on this.) done. i just added ch

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601436221 > could you provide other patch? so I can understand the whole picture. ok. (it might take a bit long to find time to work on this.) -- This is an automated message from t

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
xiaoxiang781216 commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601429899 could you provide other patch? so I can understand the whole picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601410401 > > > Does your solution share one errno.csv for all OS or have the seperate errno.csv for each OS? The complex of include/errno.csv and include/errno.h is almost same, so whether we can sha

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
xiaoxiang781216 commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601401288 > > Does your solution share one errno.csv for all OS or have the seperate errno.csv for each OS? The complex of include/errno.csv and include/errno.h is almost same, so whether w

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601304427 > > > > > > > @yamt what's the benefit to generate the errno from a csv, but not modify errno.h direclty? > > > > > > > > > > > > > > > > > > i want to generate other things as wel

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
xiaoxiang781216 commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601278958 > > > > > > @yamt what's the benefit to generate the errno from a csv, but not modify errno.h direclty? > > > > > > > > > > > > > > > i want to generate other things as

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601242632 > > > the script this PR added (mkerrno.py) is not meant to be used during a build. > > > i expect a developer who modified errno.csv to run it to regenerate some source files. > >

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-19 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2601207736 > > > > > @yamt what's the benefit to generate the errno from a csv, but not modify errno.h direclty? > > > > > > > > > > > > i want to generate other things as well, which are dif

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-17 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2599567225 > @yamt what's the benefit to generate the errno from a csv, but not modify errno.h direclty? i want to generate other things as well, which are difficult or impossible with C preproc

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-17 Thread via GitHub
xiaoxiang781216 commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2598617407 @yamt what's the benefit to generate the errno from a csv, but not modify errno.h direclty? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594906232 > the script this PR added (mkerrno.py) is not meant to be used during a build. i expect a developer who modified errno.csv to run it to regenerate some source files. then it

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-16 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594811788 > > i have a question: is python acceptable for this kind of tools these days? > > honestly speaking, i'm not inclined to write this in C. > > I don't think so, or I missed somethin

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594778197 > i have a question: is python acceptable for this kind of tools these days? honestly speaking, i'm not inclined to write this in C. I don't think so, or I missed something. If

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594640225 i have a question: is python acceptable for this kind of tools these days? honestly speaking, i'm not inclined to write this in C. -- This is an automated message from the Apache Git

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594587114 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
yamt opened a new pull request, #15579: URL: https://github.com/apache/nuttx/pull/15579 ## Summary generate errno definitions from a CSV file for flexibility. i plan to use this CSV file for other things like host <-> nuttx errno conversion logic. ## Impact ## Tes