xiaoxiang781216 commented on code in PR #15579: URL: https://github.com/apache/nuttx/pull/15579#discussion_r2051907445
########## tools/mkerrno.py: ########## @@ -0,0 +1,77 @@ +#!/usr/bin/env python3 +############################################################################ +# tools/mkerrno.py Review Comment: we can achieve the similar result by c macro instead python script, please check how syscall is implemented: https://github.com/apache/nuttx/blob/master/include/sys/syscall.h https://github.com/apache/nuttx/blob/master/include/sys/syscall_lookup.h https://github.com/apache/nuttx/blob/master/syscall/syscall_wraps.h https://github.com/apache/nuttx/blob/master/syscall/syscall_names.c https://github.com/apache/nuttx/blob/master/syscall/syscall_stublookup.c ########## include/errno_defs.h: ########## @@ -0,0 +1,311 @@ +/**************************************************************************** + * include/errno_defs.h Review Comment: it's better to generate errno_defs.h automatically instead adding to git, to simplify the process of errno modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
