Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-04-05 Thread via GitHub
raiden00pl commented on PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#issuecomment-2744096532 something is broken with cmake build. For now I'm changing to draft until I fix it -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-04-05 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007821358 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-04-05 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007190413 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-29 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005866451 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2006706757 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no gi

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-27 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007776115 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git rep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-26 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007274756 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007363025 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no gi

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
lupyuen merged PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007821358 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007808006 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007782654 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git rep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007274756 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2006707749 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-21 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007190413 ## canutils/lely-canopen/Makefile: ## @@ -170,25 +170,34 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005866451 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005863418 ## canutils/lely-canopen/Makefile: ## @@ -170,22 +170,31 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git rep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005159675 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005037542 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-19 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2003761219 ## canutils/lely-canopen/Makefile: ## @@ -170,22 +170,31 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-19 Thread via GitHub
simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2003761219 ## canutils/lely-canopen/Makefile: ## @@ -170,22 +170,31 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-19 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2003366167 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-19 Thread via GitHub
nuttxpr commented on PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#issuecomment-2736663569 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX require

[PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-19 Thread via GitHub
raiden00pl opened a new pull request, #3030: URL: https://github.com/apache/nuttx-apps/pull/3030 ## Summary This commit fixes lely-canopen build for make and cmake. It also update lely commit tag to the latest lely master. The required changes are now split into several patches to ma