simbit18 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2007274756
########## canutils/lely-canopen/Makefile: ########## @@ -170,25 +170,34 @@ MAINSRC = $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git repo found -ifeq ($(wildcard $(LELYCANOPEN_SRCNAME)/.git),) Review Comment: some examples ifeq ($(wildcard xxxxx/.git),) apps/audioutils/libmad/Makefile apps/benchmarks/coremark/Makefile apps/benchmarks/fio/Makefile apps/benchmarks/superpi/Makefile I also believe that it is necessary to create common guidelines to standardize the downloading of external packages in the two nuttx and nuttx-apps repositories. Also use, where possible, more generic variable names example : Let's use LVGL_TARBALL https://github.com/apache/nuttx-apps/blob/bbcba55bbc357b3c5f651379f55b2917075e4df9/graphics/lvgl/Makefile#L62 for a .zip package maybe better LVGL_ARCHIVE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
