Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-27 Thread via GitHub
acassis merged PR #16267: URL: https://github.com/apache/nuttx/pull/16267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
shtirlic commented on code in PR #16267: URL: https://github.com/apache/nuttx/pull/16267#discussion_r2061413716 ## drivers/lcd/ili9341.c: ## @@ -287,20 +287,26 @@ /* General fix display resolution */ -#define ILI9341_XRES 240 -#define ILI9341_YRES 320 +#

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
acassis commented on code in PR #16267: URL: https://github.com/apache/nuttx/pull/16267#discussion_r2061262908 ## drivers/lcd/ili9341.c: ## @@ -287,20 +287,26 @@ /* General fix display resolution */ -#define ILI9341_XRES 240 -#define ILI9341_YRES 320 +#i

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
nuttxpr commented on PR #16267: URL: https://github.com/apache/nuttx/pull/16267#issuecomment-2832000675 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.