Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
no1wudi commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909831239 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation of RISCV

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
no1wudi commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909831239 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation of RISCV

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909807275 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
no1wudi commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909648530 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation of RISCV

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
no1wudi commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909648530 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation of RISCV

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #15475: URL: https://github.com/apache/nuttx/pull/15475#discussion_r1909244259 ## arch/risc-v/src/cmake/Toolchain.cmake: ## @@ -343,21 +343,19 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG) # These models can't cover all implementation

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-09 Thread via GitHub
xiaoxiang781216 merged PR #15475: URL: https://github.com/apache/nuttx/pull/15475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-08 Thread via GitHub
nuttxpr commented on PR #15475: URL: https://github.com/apache/nuttx/pull/15475#issuecomment-2579052435 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] arch/risc-v: Refactor LLVM CPU type handling in Toolchain.cmake [nuttx]

2025-01-08 Thread via GitHub
no1wudi opened a new pull request, #15475: URL: https://github.com/apache/nuttx/pull/15475 ## Summary - Replace direct string comparisons with regex pattern matching for ARCHCPUEXTFLAGS - Change from using LLVM_CPUFLAGS list to setting LLVM_CPUTYPE directly - Simplify CPU ty