Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-05 Thread via GitHub
cederom commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2638682027 Thank you @zouboan and @anchao !! After long discussions on the mailing lists the conclusion is to take time and extra caution with critical kernel / architecture changes, as they impact

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-04 Thread via GitHub
zouboan commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2635567993 > > > @cederom: Thank you @zouboan :-) Good catch! :-) > > > Can you also perform `apps/testing/ostest` and other possible tests to make sure this `REG_RESERVED` is never used? :-) >

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-04 Thread via GitHub
anchao commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2635541355 > @anchao please take a look at dev@ mailing list. > @cederom Thank you, I have encountered similar problems before on other RTOS, and I think this change is reasonable. If this

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
cederom commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2633117780 > > @cederom: Thank you @zouboan :-) Good catch! :-) > > Can you also perform `apps/testing/ostest` and other possible tests to make sure this `REG_RESERVED` is never used? :-) >

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
zouboan commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2633097840 > @anchao please take a look at dev@ mailing list. > > @zouboan could you please try running the `ostest` please? I'm on leave today and don't have access to the hardware. I w

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
zouboan commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2633092117 > Thank you @zouboan :-) Good catch! :-) > i > Can you also perform `apps/testing/ostest` and other possible tests to make sure this `REG_RESERVED` is never used? :-) Thank yo

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
cederom commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2632915928 @anchao please take a look at dev@ mailing list. @zouboan could you please try running the `ostest` please? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
anchao merged PR #15748: URL: https://github.com/apache/nuttx/pull/15748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
acassis commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2630794393 @zouboan nice work investigating this issue and submitting this fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] arch/arm64 Fix the SP unalignment issues [nuttx]

2025-02-03 Thread via GitHub
zouboan opened a new pull request, #15748: URL: https://github.com/apache/nuttx/pull/15748 ## Summary zynq-mpsoc and zcu111 borad was broken by #15437, because #15437 changes ARM64_CONTEXT_REGS from 36 to 37, resulting in the stack no longer being 16-byte aligned which appears to vio