cederom commented on PR #15748: URL: https://github.com/apache/nuttx/pull/15748#issuecomment-2633117780
> > @cederom: Thank you @zouboan :-) Good catch! :-) > > Can you also perform `apps/testing/ostest` and other possible tests to make sure this `REG_RESERVED` is never used? :-) > > @zouboan: Thank you for the reminder. After checking, I found that `REG_RESERVED` is not used in either NuttX or APPS . However, I will still proceed with conducting `apps/testing/ostest` Thank you for understanding @zouboan, and for fixing the problem!! :-) We are discussing on the mailing list how to improve testing of hardware related changes, to avoid this kind of breaks in future, that better testing is required, and we should not rush merging because that rush already impacts users and self-compatibility. Take your time. Lets try out one step deeper verification (i.e. ostest maybe some benchmarks). If you have ideas on what should be part of standard mandatory "selftest" for architecture related changes please share :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
