Re: [PR] Segger sysview improvements [nuttx]

2025-06-05 Thread via GitHub
xiaoxiang781216 commented on PR #16483: URL: https://github.com/apache/nuttx/pull/16483#issuecomment-2947725782 @jlaitine could you bring back your dropped patch again? it's easy to support the recursive lock after https://github.com/apache/nuttx/pull/16486. -- This is an automated messag

Re: [PR] Segger sysview improvements [nuttx]

2025-06-05 Thread via GitHub
xiaoxiang781216 merged PR #16483: URL: https://github.com/apache/nuttx/pull/16483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Segger sysview improvements [nuttx]

2025-06-05 Thread via GitHub
jlaitine commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128806190 ## drivers/note/note_driver.c: ## @@ -611,7 +611,7 @@ void sched_note_add(FAR const void *data, size_t len) note_add(*driver, note, notelen); } -

Re: [PR] Segger sysview improvements [nuttx]

2025-06-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128162918 ## drivers/note/note_driver.c: ## @@ -611,7 +611,7 @@ void sched_note_add(FAR const void *data, size_t len) note_add(*driver, note, notelen);

Re: [PR] Segger sysview improvements [nuttx]

2025-06-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2128161421 ## drivers/segger/config/SEGGER_RTT_Conf.h: ## @@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock; /* Lock RTT (nestable) (i.e. disable interrupts) */ -

Re: [PR] Segger sysview improvements [nuttx]

2025-06-04 Thread via GitHub
jlaitine commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2127978773 ## drivers/segger/config/SEGGER_RTT_Conf.h: ## @@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock; /* Lock RTT (nestable) (i.e. disable interrupts) */ -#define

Re: [PR] Segger sysview improvements [nuttx]

2025-06-04 Thread via GitHub
jlaitine commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2127978773 ## drivers/segger/config/SEGGER_RTT_Conf.h: ## @@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock; /* Lock RTT (nestable) (i.e. disable interrupts) */ -#define

Re: [PR] Segger sysview improvements [nuttx]

2025-06-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #16483: URL: https://github.com/apache/nuttx/pull/16483#discussion_r2127794681 ## drivers/segger/config/SEGGER_RTT_Conf.h: ## @@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock; /* Lock RTT (nestable) (i.e. disable interrupts) */ -

[PR] Segger sysview improvements [nuttx]

2025-06-04 Thread via GitHub
jlaitine opened a new pull request, #16483: URL: https://github.com/apache/nuttx/pull/16483 ## Summary I recently tested segger sysview on MPFS platform, and found out some issues with the driver. This is a collection of patches which I made in order to make it usable for