xiaoxiang781216 commented on code in PR #16483:
URL: https://github.com/apache/nuttx/pull/16483#discussion_r2127794681
##########
drivers/segger/config/SEGGER_RTT_Conf.h:
##########
@@ -89,11 +81,11 @@ extern spinlock_t g_segger_lock;
/* Lock RTT (nestable) (i.e. disable interrupts) */
-#define SEGGER_RTT_LOCK() irqstate_t __flags =
spin_lock_irqsave_notrace(&g_segger_lock)
Review Comment:
let's switch to recursive look?
##########
drivers/note/note_driver.c:
##########
@@ -611,7 +611,7 @@ void sched_note_add(FAR const void *data, size_t len)
note_add(*driver, note, notelen);
}
- data += notelen;
+ data = (void *)((uintptr_t)data + notelen);
Review Comment:
add FAR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
