xiaoxiang781216 merged PR #16323:
URL: https://github.com/apache/nuttx/pull/16323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860992196
Fixed!
Please @xiaoxiang781216 @jerpelea @cederom @lupyuen review/approve again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860966755
Aff, I did a mistake, I created a new commit and replaced the old commits. I
will send them again
--
This is an automated message from the Apache Git Service.
To respond to the message,
cederom commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860048911
@acassis yes its already updated in
https://github.com/apache/nuttx/pull/16336 please approve the PR so it can be
merged :-)
--
This is an automated message from the Apache Git Service
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2859650450
@cederom maybe it is better to remove this rule after the PR was submitted.
So, be in sync with the master (upstream) is important when opening the PR,
after that the github will do the r
xiaoxiang781216 commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2078090071
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool
xiaoxiang781216 commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2078090721
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool
acassis commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2077566675
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool "Mark th
xiaoxiang781216 commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076033609
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool
acassis commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076029293
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool "Mark th
acassis commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076029293
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool "Mark th
xiaoxiang781216 commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2075996375
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2855429661
> Thank you @acassis :-)
>
> These patches come from outside private repository, and processed by
@acassis, I have asked original author to follow Contributing Guidelines and
sign
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2855087468
> > @xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until
we get a proper AVR Toolchain?
>
> hi @acassis you must add this
>
> ```
> # Sparc-gaisler-elf
simbit18 commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2854893902
> @xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until
we get a proper AVR Toolchain?
hi @acassis you must add this
```
# Sparc-gaisler-elf
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2854607607
@xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until we
get a proper AVR Toolchain?
--
This is an automated message from the Apache Git Service.
To respond to the me
acassis commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2075394221
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool "Mark th
xiaoxiang781216 commented on code in PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#discussion_r2074659948
##
arch/avr/src/avr/Kconfig:
##
@@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN
endchoice # Toolchain
+config AVR_LINUXGCC_TOOLCHAIN_IS_GCC
+ bool
xiaoxiang781216 commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2853129084
> @sumpfralle please add RCALL to codespell exception, it is failing:
>
> /home/runner/work/nuttx/nuttx/nuttx/arch/avr/src/avr/excptmacros.h:336:
RCALL ==> RECALL
>
>
acassis commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2852893321
@sumpfralle please add RCALL to codespell exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nuttxpr commented on PR #16323:
URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2852887823
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requirements.
acassis opened a new pull request, #16323:
URL: https://github.com/apache/nuttx/pull/16323
## Summary
These patches were created by KR to enable support to AVRDA and AVRDB. This
is early stage with only hello board profile example.
## Impact
Users will be able to test Nu
22 matches
Mail list logo
