xiaoxiang781216 merged PR #10605:
URL: https://github.com/apache/nuttx/pull/10605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
TaiJuWu commented on PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1750561428
> The style need fix too:
>
> ```
> ../nuttx/tools/checkpatch.sh -u -m -g
57bf9d44d2d93619616a4c87ce96b85986f96c65..HEAD
> Error:
/home/runner/work/nuttx/nuttx/nuttx/sched/se
xiaoxiang781216 commented on PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1750260049
The style need fix too:
```
../nuttx/tools/checkpatch.sh -u -m -g
57bf9d44d2d93619616a4c87ce96b85986f96c65..HEAD
Error: /home/runner/work/nuttx/nuttx/nuttx/sched/semaphore
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348459819
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# d
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348459819
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# d
TaiJuWu commented on PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1750117670
> please run './tools/refresh.sh qemu-armv8a/nsh_smp' to fix the ci error.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348266675
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# define __
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348216222
##
sched/semaphore/spinlock.c:
##
@@ -137,32 +155,52 @@ void spin_lock_wo_note(FAR volatile spinlock_t *lock)
*
xiaoxiang781216 commented on PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1749949331
please run './tools/refresh.sh qemu-armv8a/nsh_smp' to fix the ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348212690
##
include/nuttx/spinlock.h:
##
@@ -39,6 +39,26 @@
typedef uint8_t spinlock_t;
#else
+#ifdef CONFIG_TICKET_SPINLOCK
+
+# define SP_UNLOCKED 0 /* The Un-lo
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1348211586
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# d
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347825217
##
include/nuttx/spinlock.h:
##
@@ -39,6 +39,26 @@
typedef uint8_t spinlock_t;
#else
+#ifdef CONFIG_TICKET_SPINLOCK
+
+# define SP_UNLOCKED 0 /* The Un-locked sta
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347865072
##
sched/semaphore/spinlock.c:
##
@@ -137,32 +155,52 @@ void spin_lock_wo_note(FAR volatile spinlock_t *lock)
*
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347862942
##
sched/semaphore/spinlock.c:
##
@@ -137,32 +155,52 @@ void spin_lock_wo_note(FAR volatile spinlock_t *lock)
*
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347850536
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# define __
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347850536
##
include/nuttx/spinlock.h:
##
@@ -84,6 +107,10 @@ typedef uint8_t spinlock_t;
# define __SP_UNLOCK_FUNCTION 1
#endif
+#ifdef CONFIG_TICKET_SPINLOCK
+# define __
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347825217
##
include/nuttx/spinlock.h:
##
@@ -39,6 +39,26 @@
typedef uint8_t spinlock_t;
#else
+#ifdef CONFIG_TICKET_SPINLOCK
+
+# define SP_UNLOCKED 0 /* The Un-locked sta
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347825217
##
include/nuttx/spinlock.h:
##
@@ -39,6 +39,26 @@
typedef uint8_t spinlock_t;
#else
+#ifdef CONFIG_TICKET_SPINLOCK
+
+# define SP_UNLOCKED 0 /* The Un-locked sta
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347658375
##
include/nuttx/spinlock.h:
##
@@ -352,9 +383,11 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned int
cpu,
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1347583921
##
sched/semaphore/spinlock.c:
##
@@ -187,16 +225,36 @@ spinlock_t spin_trylock(FAR volatile spinlock_t *lock)
*
***
xiaoxiang781216 commented on PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#issuecomment-1748049854
@TaiJuWu please squash your patch. It's very easy to review the change
between the update from github, so you don't need split the new change into the
separated patch. BTW, please
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346795877
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if d
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346701893
##
sched/semaphore/spinlock.c:
##
@@ -189,6 +224,25 @@ spinlock_t spin_trylock(FAR volatile spinlock_t *lock)
spinlock_t spin_trylock_wo_note(FAR volatile spinlock_t
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346570541
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346535035
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
TaiJuWu commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346535035
##
include/nuttx/spinlock.h:
##
@@ -49,6 +49,21 @@ typedef uint8_t spinlock_t;
* SP_LOCKED and SP_UNLOCKED must be constants of type spinlock_t.
*/
+#if defined(C
xiaoxiang781216 commented on code in PR #10605:
URL: https://github.com/apache/nuttx/pull/10605#discussion_r1346262202
##
sched/semaphore/CMakeLists.txt:
##
@@ -40,4 +40,8 @@ if(CONFIG_SPINLOCK)
list(APPEND CSRCS spinlock.c)
endif()
+if(CONFIG_TICKET_SPINLOCK)
Review Comm
32 matches
Mail list logo
