Re: [PR] Fix x86/64 early-print [nuttx]

2025-04-04 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim +

Re: [PR] Fix x86/64 early-print [nuttx]

2025-04-01 Thread via GitHub
xiaoxiang781216 merged PR #15936: URL: https://github.com/apache/nuttx/pull/15936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-31 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim +

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-31 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim +

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2014409134 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982689156 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982686515 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982685527 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982569452 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982533233 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982472838 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982429178 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1981403808 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim + +A

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1981400232 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-05 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1981242423 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1980694666 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1980544510 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1980532638 ## arch/x86_64/src/intel64/intel64_fbterm.c: ## @@ -284,43 +296,45 @@ void x86_64_mb2_fbinitialize(struct multiboot_tag_framebuffer *fbt) * Name: fb_putc ***

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1980532444 ## arch/x86_64/src/intel64/intel64_fbterm.c: ## @@ -348,5 +362,7 @@ void fb_putc(char ch) } g_fb_term.cursor_x += fbm->metric.width; + + return ; Review C

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
lupyuen commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1980162385 ## arch/x86_64/src/intel64/intel64_fbterm.c: ## @@ -284,43 +296,45 @@ void x86_64_mb2_fbinitialize(struct multiboot_tag_framebuffer *fbt) * Name: fb_putc *

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1979260621 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1979259757 ## arch/x86_64/src/intel64/intel64_map_region.c: ## @@ -38,6 +38,54 @@ * Private Functions ***

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1979158697 ## libs/libnx/nxfonts/CMakeLists.txt: ## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bit

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-04 Thread via GitHub
Fix-Point commented on PR #15936: URL: https://github.com/apache/nuttx/pull/15936#issuecomment-2696866928 > please change commit title for [c4a8248](https://github.com/apache/nuttx/commit/c4a82481a3f7cdc5fd645fbfe1309f5e5d34f59c) to libc/stream: Support lowsyslog. Done. -- This is

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-03 Thread via GitHub
nuttxpr commented on PR #15936: URL: https://github.com/apache/nuttx/pull/15936#issuecomment-2696072669 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] Fix x86/64 early-print [nuttx]

2025-03-03 Thread via GitHub
Fix-Point opened a new pull request, #15936: URL: https://github.com/apache/nuttx/pull/15936 ## Summary Since the x86_64 platform does not have effective bare-metal hardware debugging, it is very difficult to debug errors in the early boot stage. These patches fix the frame-buffer-