anchao commented on code in PR #15936:
URL: https://github.com/apache/nuttx/pull/15936#discussion_r1979158697
##########
libs/libnx/nxfonts/CMakeLists.txt:
##########
@@ -251,5 +251,12 @@ if(CONFIG_NXFONTS)
add_font(tom-thumb-4x6 43)
endif()
+ # Fix -Wshadow warnings for built-in bitops on x86_64
+
+ if(CONFIG_ARCH_X86_64)
+ list(APPEND CFLAGS -fno-builtin-ffs -fno-builtin-ffsl -fno-builtin-ffsll)
+ list(APPEND CFLAGS -fno-builtin-fls -fno-builtin-flsl -fno-builtin-flsll)
Review Comment:
Is it related to toolchain version?
##########
arch/x86_64/src/common/x86_64_internal.h:
##########
@@ -251,7 +251,7 @@ uint64_t *x86_64_syscall(uint64_t *regs);
#ifdef CONFIG_ARCH_MULTIBOOT2
void x86_64_mb2_fbinitialize(struct multiboot_tag_framebuffer *tag);
-void fb_putc(char ch);
+int fb_putc(int ch);
Review Comment:
```suggestion
void fb_putc(int ch);
```
##########
arch/x86_64/src/intel64/intel64_map_region.c:
##########
@@ -38,6 +38,54 @@
* Private Functions
****************************************************************************/
+static inline
Review Comment:
```suggestion
static inline_function
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
