Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-14 Thread via GitHub
raiden00pl merged PR #15794: URL: https://github.com/apache/nuttx/pull/15794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-14 Thread via GitHub
acassis commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2659735638 @jerpelea @raiden00pl could you please merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-12 Thread via GitHub
acassis commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2653884945 @LuchianMihai I fixed the previous paragraph to make it clear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-11 Thread via GitHub
LuchianMihai commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2651205383 > > > > Hi @acassis, On the same page, an paragraph before, talks about nxstyle, which can be used to do the same thing. Should we move that sentence to your new heading as well?

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-11 Thread via GitHub
acassis commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2651157087 > > > Hi @acassis, On the same page, an paragraph before, talks about nxstyle, which can be used to do the same thing. Should we move that sentence to your new heading as well? > >

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-11 Thread via GitHub
acassis commented on code in PR #15794: URL: https://github.com/apache/nuttx/pull/15794#discussion_r1951057934 ## Documentation/contributing/coding_style.rst: ## @@ -12,6 +12,25 @@ for conformance to the coding style, you should use the `nxstyle <#nxstyle>`_ tool included unde

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-11 Thread via GitHub
fdcavalcanti commented on code in PR #15794: URL: https://github.com/apache/nuttx/pull/15794#discussion_r1950811666 ## Documentation/contributing/coding_style.rst: ## @@ -12,6 +12,25 @@ for conformance to the coding style, you should use the `nxstyle <#nxstyle>`_ tool included

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-11 Thread via GitHub
fdcavalcanti commented on code in PR #15794: URL: https://github.com/apache/nuttx/pull/15794#discussion_r1950811666 ## Documentation/contributing/coding_style.rst: ## @@ -12,6 +12,25 @@ for conformance to the coding style, you should use the `nxstyle <#nxstyle>`_ tool included

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-10 Thread via GitHub
LuchianMihai commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2649970778 > > Hi @acassis, On the same page, an paragraph before, talks about nxstyle, which can be used to do the same thing. Should we move that sentence to your new heading as well? >

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-10 Thread via GitHub
acassis commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2648965522 > Hi @acassis, On the same page, an paragraph before, talks about nxstyle, which can be used to do the same thing. Should we move that sentence to your new heading as well? @Luchia

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-10 Thread via GitHub
LuchianMihai commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2647435386 Hi @acassis, On the same page, an paragraph before, talks about nxstyle, which can be used to do the same thing. Should we move that sentence to your new heading as well? -

Re: [PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-09 Thread via GitHub
nuttxpr commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2646209535 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description **does not fully meet the NuttX req

[PR] DOC: Fix documentation to include checkpatch.sh [nuttx]

2025-02-09 Thread via GitHub
acassis opened a new pull request, #15794: URL: https://github.com/apache/nuttx/pull/15794 ## Summary Unfortunately new contributors used to submit code with many coding issue. And in fact it is our guilt: our codign style documentation doesn't say to them how to use the checkpatch t