nuttxpr commented on PR #15794: URL: https://github.com/apache/nuttx/pull/15794#issuecomment-2646209535
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description **does not fully meet the NuttX requirements**. While it explains the *why* of the change (helping new contributors), it lacks critical details required by the template. Here's a breakdown: * **Missing in Summary:** * **What functional part of the code is being changed?** (e.g., documentation, build system, CI?) * **How does the change exactly work?** (e.g., adding a section to the coding style guide, updating the contribution guidelines, adding a checkpatch step to the CI?) * **Issue references:** Even if there isn't a formal issue, it's good practice to create one and link it for tracking purposes. * **Missing in Impact:** While the overall impact is mentioned, the specific yes/no questions are not addressed. This makes it difficult to quickly assess the breadth of the change. All should be answered, even if the answer is NO. * **Testing is insufficient:** "N/A" is not acceptable. Even for documentation changes, there should be *some* form of verification. For example, "Verified the updated documentation renders correctly locally" or "Confirmed the new section appears in the online documentation." To make this PR compliant, the author needs to add the missing details outlined above. Specifically, they need to clarify precisely *what* code or documentation is being changed and *how*, and provide more concrete verification of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
