Re: [PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-12 Thread via GitHub
acassis merged PR #2990: URL: https://github.com/apache/nuttx-apps/pull/2990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-07 Thread via GitHub
anchao commented on code in PR #2990: URL: https://github.com/apache/nuttx-apps/pull/2990#discussion_r1947421936 ## nshlib/nsh_builtin.c: ## @@ -234,7 +234,13 @@ int nsh_builtin(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd, /* Restore the old actions */ -

Re: [PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-07 Thread via GitHub
Donny9 commented on code in PR #2990: URL: https://github.com/apache/nuttx-apps/pull/2990#discussion_r1947406721 ## nshlib/nsh_builtin.c: ## @@ -234,7 +234,13 @@ int nsh_builtin(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd, /* Restore the old actions */ -

Re: [PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-07 Thread via GitHub
anchao commented on code in PR #2990: URL: https://github.com/apache/nuttx-apps/pull/2990#discussion_r1947380487 ## nshlib/nsh_builtin.c: ## @@ -234,7 +234,13 @@ int nsh_builtin(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd, /* Restore the old actions */ -

Re: [PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-07 Thread via GitHub
acassis commented on code in PR #2990: URL: https://github.com/apache/nuttx-apps/pull/2990#discussion_r1947007371 ## nshlib/nsh_builtin.c: ## @@ -234,7 +234,13 @@ int nsh_builtin(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd, /* Restore the old actions */ -

[PR] nshlib/builtin: check background task before restore the signal [nuttx-apps]

2025-02-07 Thread via GitHub
anchao opened a new pull request, #2990: URL: https://github.com/apache/nuttx-apps/pull/2990 ## Summary nshlib/builtin: check background task before restore the signal fix crash if: CONFIG_SCHED_WAITPID=n CONFIG_SCHED_CHILD_STATUS=y The old signal will be restored o