anchao commented on code in PR #2990:
URL: https://github.com/apache/nuttx-apps/pull/2990#discussion_r1947380487


##########
nshlib/nsh_builtin.c:
##########
@@ -234,7 +234,13 @@ int nsh_builtin(FAR struct nsh_vtbl_s *vtbl, FAR const 
char *cmd,
 
           /* Restore the old actions */
 
-          sigaction(SIGCHLD, &old, NULL);
+#  ifndef CONFIG_SCHED_WAITPID

Review Comment:
   This PR only solves the crash issue, it should not appear in the code 
comments, and the comments above have already indicated the relevant behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to