[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065772178 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065650437 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065630233 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065630233 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065567897 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065468467 ## mm/shm/shmdt.c: ## @@ -178,4 +164,55 @@ int shmdt(FAR const void *shmaddr) return ERROR; } +int shmdt(FAR const void *shmaddr) +{ + FAR struct tcb_s *tcb; + F

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065461901 ## mm/map/mm_map.c: ## @@ -0,0 +1,315 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065404158 ## mm/map/mm_map.c: ## @@ -0,0 +1,315 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065405960 ## fs/mmap/fs_rammap.c: ## @@ -44,12 +41,83 @@ * Public Data / -/* This is the list of

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065407280 ## mm/shm/shmdt.c: ## @@ -33,32 +33,34 @@ #include #include #include +#include #include "shm/shm.h" #ifdef CONFIG_MM_SHM /***

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065406482 ## mm/shm/shmat.c: ## @@ -32,11 +32,39 @@ #include #include #include +#include #include "shm/shm.h" #ifdef CONFIG_MM_SHM +/***

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065406297 ## fs/mmap/fs_munmap.c: ## @@ -158,7 +159,40 @@ static int file_munmap_(FAR void *start, size_t length, bool kernel) nxmutex_unlock(&g_rammaps.lock); return ret;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065405960 ## fs/mmap/fs_rammap.c: ## @@ -44,12 +41,83 @@ * Public Data / -/* This is the list of

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065405158 ## fs/mmap/fs_rammap.c: ## @@ -81,15 +149,14 @@ struct fs_allmaps_s g_rammaps = * / -in

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065404972 ## fs/mmap/fs_rammap.h: ## @@ -53,29 +35,28 @@ * - There are not access privileges. */ -struct fs_rammap_s -{ - struct fs_rammap_s *flink; /* Implements a s

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065404814 ## mm/map/mm_map.c: ## @@ -0,0 +1,315 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065404322 ## mm/map/mm_map.c: ## @@ -0,0 +1,315 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1065404158 ## mm/map/mm_map.c: ## @@ -0,0 +1,315 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064464826 ## fs/mmap/fs_mmap.c: ## @@ -140,20 +145,6 @@ static int file_mmap_(FAR struct file *filep, FAR void *start, if (filep->f_inode && filep->f_inode->u.i_ops->mmap !=

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064462671 ## fs/mmap/fs_rammap.c: ## @@ -81,15 +149,14 @@ struct fs_allmaps_s g_rammaps = * / -in

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064462401 ## fs/mmap/fs_rammap.h: ## @@ -53,29 +35,28 @@ * - There are not access privileges. */ -struct fs_rammap_s -{ - struct fs_rammap_s *flink; /* Implements a s

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064460918 ## include/nuttx/mm/map.h: ## @@ -84,34 +84,34 @@ struct mm_map_s * Name: mm_map_lock * * Description: - * Get exclusive access to task_group's mm_map + * Get

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064460709 ## include/nuttx/sched.h: ## @@ -506,6 +506,10 @@ struct task_group_s struct group_shm_s tg_shm;/* Task shared memory logic */ #endif + + /* V

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064457650 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064457337 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064456982 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1064455426 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063585176 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063585176 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063505448 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063505448 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063504249 ## mm/map/mm_map.c: ## @@ -0,0 +1,327 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063493292 ## mm/shm/shmdt.c: ## @@ -113,6 +91,16 @@ int shmdt(FAR const void *shmaddr) goto errout_with_errno; } + if (!group) Review Comment: World is rarely p

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063450573 ## mm/map/mm_map.c: ## @@ -0,0 +1,326 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063449856 ## mm/map/mm_map.c: ## @@ -0,0 +1,326 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063431469 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063431469 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063431469 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063428645 ## include/nuttx/mm/map.h: ## @@ -73,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063428271 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063413414 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063413414 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063411826 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063408292 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063394016 ## include/nuttx/mm/map.h: ## @@ -73,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063401584 ## mm/shm/shmdt.c: ## @@ -113,6 +91,16 @@ int shmdt(FAR const void *shmaddr) goto errout_with_errno; } + if (!group) Review Comment: the shmdt_priv is

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063397722 ## mm/map/mm_map.c: ## @@ -0,0 +1,325 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063394224 ## include/nuttx/mm/map.h: ## @@ -73,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063394016 ## include/nuttx/mm/map.h: ## @@ -73,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063318221 ## include/nuttx/mm/map.h: ## @@ -63,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063317974 ## include/nuttx/mm/map.h: ## @@ -63,11 +73,156 @@ struct mm_map_entry_s struct mm_map_s { sq_queue_t mm_map_sq; - mutex_t mm_map_mutex; + rmutex_t mm_map_mutex;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063317621 ## fs/mmap/fs_rammap.c: ## @@ -44,12 +41,81 @@ * Public Data / -/* This is the list of

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063315629 ## fs/mmap/fs_anonmap.h: ## @@ -0,0 +1,64 @@ +/ + * fs/mmap/fs_anonmap.h + * + * Licensed to

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062150946 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062178285 ## mm/Kconfig: ## @@ -257,4 +257,8 @@ config MM_PANIC_ON_FAILURE default n depends on DEBUG_MM +config MM_MAP Review Comment: done -- This is a

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062159525 ## mm/Kconfig: ## @@ -257,4 +257,8 @@ config MM_PANIC_ON_FAILURE default n depends on DEBUG_MM +config MM_MAP Review Comment: I measured the differ

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062159098 ## include/nuttx/mm/map.h: ## @@ -43,7 +49,11 @@ struct mm_map_entry_s off_t offset; int prot; int flags; - FAR void *priv; + union + { +FAR void *p; +

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062150946 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061698798 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061691266 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061509569 ## include/nuttx/mm/map.h: ## @@ -43,7 +49,11 @@ struct mm_map_entry_s off_t offset; int prot; int flags; - FAR void *priv; + union + { +FAR void *p; +

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061470297 ## fs/mmap/fs_munmap.c: ## @@ -158,7 +160,38 @@ static int file_munmap_(FAR void *start, size_t length, bool kernel) nxmutex_unlock(&g_rammaps.lock); return ret;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061396990 ## fs/mmap/fs_munmap.c: ## @@ -158,7 +159,44 @@ static int file_munmap_(FAR void *start, size_t length, bool kernel) nxmutex_unlock(&g_rammaps.lock); return ret;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061392888 ## fs/mmap/fs_munmap.c: ## @@ -158,7 +159,44 @@ static int file_munmap_(FAR void *start, size_t length, bool kernel) nxmutex_unlock(&g_rammaps.lock); return ret;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061387032 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061378372 ## include/nuttx/mm/map.h: ## @@ -43,7 +49,11 @@ struct mm_map_entry_s off_t offset; int prot; int flags; - FAR void *priv; + union + { +FAR void *p; +

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061376968 ## fs/mmap/fs_munmap.c: ## @@ -158,7 +160,38 @@ static int file_munmap_(FAR void *start, size_t length, bool kernel) nxmutex_unlock(&g_rammaps.lock); return ret;

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061376597 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061376243 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061375058 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061374911 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061373239 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061372433 ## mm/shm/shmat.c: ## @@ -32,11 +32,43 @@ #include #include #include +#include #include "shm/shm.h" #ifdef CONFIG_MM_SHM +/***

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061372242 ## fs/mmap/fs_munmap.c: ## @@ -23,9 +23,11 @@ / #include +#include #include #incl

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061372041 ## fs/mmap/fs_mmap.c: ## @@ -42,6 +42,50 @@ * Private Functions / +/***

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061194065 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061188946 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061196819 ## mm/Kconfig: ## @@ -257,4 +257,8 @@ config MM_PANIC_ON_FAILURE default n depends on DEBUG_MM +config MM_MAP Review Comment: This is a trade off b

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061195452 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061194774 ## include/nuttx/mm/map.h: ## @@ -80,4 +80,137 @@ struct mm_map_s * Public Function Prototypes **

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061194065 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061188946 ## mm/map/mm_map.c: ## @@ -0,0 +1,337 @@ +/ + * mm/map/mm_map.c + * + * Licensed to the Apach

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061175458 ## include/nuttx/mm/map.h: ## @@ -43,7 +49,11 @@ struct mm_map_entry_s off_t offset; int prot; int flags; - FAR void *priv; + union + { +FAR void *p; +

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1060742053 ## mm/shm/shmat.c: ## @@ -32,11 +32,43 @@ #include #include #include +#include #include "shm/shm.h" #ifdef CONFIG_MM_SHM +/***

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1060621819 ## fs/mmap/fs_munmap.c: ## @@ -23,9 +23,11 @@ / #include +#include #include #incl

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

jlaitine commented on code in PR #8026: URL: https://github.com/apache/nuttx/pull/8026#discussion_r1060621034 ## fs/mmap/fs_mmap.c: ## @@ -42,6 +42,50 @@ * Private Functions / +/***