jlaitine commented on code in PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#discussion_r1063493292
##########
mm/shm/shmdt.c:
##########
@@ -113,6 +91,16 @@ int shmdt(FAR const void *shmaddr)
goto errout_with_errno;
}
+ if (!group)
Review Comment:
World is rarely perfect :)
But that's why I made a private function shmdt_priv, so that you don't need
to duplicate code for the two cleanup cases 1) normal munmap 2) process exit
(where you must still return pages and deallocate kernel memory, but cannot
touch group or MMU)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
