Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-208411 > > the following warning could be fixed, I think: [..] > > Which specific warning do you mean? > > * configed / persistance / vaild / avalaible: I mentioned these

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-17 Thread via GitHub
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2888759926 > the following warning could be fixed, I think: [..] Which specific warning do you mean? * configed / persistance / vaild / avalaible: I mentioned these in the summary of exp

[PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]

2025-05-17 Thread via GitHub
ldube opened a new pull request, #16408: URL: https://github.com/apache/nuttx/pull/16408 ## Summary Add knsh defconfig ## Impact Only affects users of sama5d3-xplained ## Testing (using Linux host) cd nuttx make distclean; ./tools/configure.sh -l sama

[PR] WIP: Documentation: replace first person perspectives [nuttx]

2025-05-17 Thread via GitHub
sumpfralle opened a new pull request, #16407: URL: https://github.com/apache/nuttx/pull/16407 ## Summary Currently there are a few pieces of documentation written in the first person perspective. This phrasing may be misunderstood as belonging to a single person project (instead o

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-17 Thread via GitHub
sumpfralle commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2094238487 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/1

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-17 Thread via GitHub
sumpfralle commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2094235869 ## tools/checkpatch.sh: ## @@ -125,7 +126,14 @@ check_file() { fi if [ $spell != 0 ]; then -if ! codespell -q 7 ${@: -1}; then +if [ "$codespell_conf

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094179941 ## fs/vfs/fs_ioctl.c: ## @@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req, va_list ap) } break; -#ifdef CONFI

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094174857 ## fs/vfs/fs_fcntl.c: ## @@ -46,7 +46,7 @@ * Name: file_vfcntl / -static int f

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094177845 ## include/nuttx/fs/fs.h: ## @@ -466,6 +466,15 @@ struct file off_t f_pos; /* File position */ Review Comment: The memory leak will alwa

Re: [I] [HELP] Invalid address for created tasks [nuttx]

2025-05-17 Thread via GitHub
emomaxd commented on issue #16384: URL: https://github.com/apache/nuttx/issues/16384#issuecomment-2888514021 @acassis, I don't have UART or console set up at the moment because my main goal is just to get the system to successfully reach the idle loop. The crash I'm seeing is due t

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094175112 ## fs/vfs/fs_fcntl.c: ## @@ -91,7 +91,7 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap) */ { - ret = filep

(nuttx) branch master updated: boards/sama5d3-xplained: Fix mmc card detection.

2025-05-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new accfb3609b7 boards/sama5d3-xplained: Fix mmc c

Re: [PR] docs/contributing: Add board documentation template [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 merged PR #16405: URL: https://github.com/apache/nuttx/pull/16405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: docs/contributing: Add board documentation template.

2025-05-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 641e8daaef0 docs/contributing: Add board docum

Re: [PR] boards/sama5d3-xplained: Fix mmc card detection. [nuttx]

2025-05-17 Thread via GitHub
xiaoxiang781216 merged PR #16403: URL: https://github.com/apache/nuttx/pull/16403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [I] [BUG] Potential pointer arithmetic issue? [nuttx]

2025-05-17 Thread via GitHub
emomaxd commented on issue #16386: URL: https://github.com/apache/nuttx/issues/16386#issuecomment-2888465254 Thanks for your concern, I’ll let you know on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [BUG] RP2040 SMP configurations broken [nuttx]

2025-05-17 Thread via GitHub
linguini1 commented on issue #15760: URL: https://github.com/apache/nuttx/issues/15760#issuecomment-2888417901 > Still broken for rp23xx (pico2) on master, reverting to at least to [b49f428](https://github.com/apache/nuttx/commit/b49f4286fb60a2b1ceaefc0ce2b712d1992bf2e6) fixes the SMP build

Re: [I] [BUG] Potential pointer arithmetic issue? [nuttx]

2025-05-17 Thread via GitHub
linguini1 commented on issue #16386: URL: https://github.com/apache/nuttx/issues/16386#issuecomment-2888415655 I am also not too sure here. As others pointed out, `volatile uint32_t *stk = (void *)*g_idle_topstack;` is an odd expression. Can you confirm that `volatile uint32_t *stk = (void

Re: [PR] DOCS: Application documentation [nuttx]

2025-05-17 Thread via GitHub
linguini1 commented on code in PR #16406: URL: https://github.com/apache/nuttx/pull/16406#discussion_r2094129494 ## Documentation/applications/examples/gps/index.rst: ## @@ -2,4 +2,26 @@ ``gps`` GPS example === -GPS example. +This example can be used to inter

Re: [I] [HELP] SPI TX DMA complete callback [nuttx]

2025-05-17 Thread via GitHub
acassis commented on issue #16373: URL: https://github.com/apache/nuttx/issues/16373#issuecomment-2888407051 Hi @dakejahl it is not directly possible to install a callback from user space for SPI DMA completion due the userspace/kernel space separation (in FLAT mode it could work, but it wi

Re: [PR] boards/sama5d3-xplained: Fix mmc card detection. [nuttx]

2025-05-17 Thread via GitHub
ldube commented on code in PR #16403: URL: https://github.com/apache/nuttx/pull/16403#discussion_r2094127244 ## boards/arm/sama5/sama5d3-xplained/configs/knsh/defconfig: ## @@ -0,0 +1,91 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. Review Comment: I'll delete

Re: [I] [BUG] Potential pointer arithmetic issue? [nuttx]

2025-05-17 Thread via GitHub
acassis commented on issue #16386: URL: https://github.com/apache/nuttx/issues/16386#issuecomment-2888400647 @emomaxd thank you for explanation. Could it be something related to cache been enabled? Then when you try to do a right boolean operation the right value is read. @linguini1

Re: [I] [HELP] Invalid address for created tasks [nuttx]

2025-05-17 Thread via GitHub
acassis commented on issue #16384: URL: https://github.com/apache/nuttx/issues/16384#issuecomment-2888396887 @emomaxd probably there is some issue your chip port, these issues you are facing are not common on NuttX. Could you please print the dump of this crash? This way we could instruct y

Re: [I] [BUG] Potential pointer arithmetic issue? [nuttx]

2025-05-17 Thread via GitHub
emomaxd commented on issue #16386: URL: https://github.com/apache/nuttx/issues/16386#issuecomment-2888393948 @acassis, My goal is to get NuttX running correctly on the R5F core of the TI AM67A SoC—nothing more. Currently, it crashes at nx_start(), as shown in the attached image.

Re: [I] [BUG] Potential pointer arithmetic issue? [nuttx]

2025-05-17 Thread via GitHub
acassis commented on issue #16386: URL: https://github.com/apache/nuttx/issues/16386#issuecomment-2888388724 @emomaxd could you please explain what you want to accomplish not how you want to do it? Maybe if we understand your goal we could help better. Also since you are using a custom boar

Re: [PR] DOCS: Application documentation [nuttx]

2025-05-17 Thread via GitHub
acassis commented on code in PR #16406: URL: https://github.com/apache/nuttx/pull/16406#discussion_r2094108291 ## Documentation/applications/examples/gps/index.rst: ## @@ -2,4 +2,26 @@ ``gps`` GPS example === -GPS example. +This example can be used to interac

Re: [I] [HELP] `dhcpd_stop()` does not return if no packets were received (recv blocking behavior) [nuttx]

2025-05-17 Thread via GitHub
TimJTi commented on issue #16135: URL: https://github.com/apache/nuttx/issues/16135#issuecomment-2888263329 OK, I was miles off. But: ``` /* Wait for the DHCPD client to respond to the stop request */ sem_wait(&g_dhcpd_daemon.ds_sync); ``` There

Re: [I] [HELP] STM32H723+SDMMC2+SDRAM(executing in sdram)+IDMA+FATFS,read/write file failure [nuttx]

2025-05-17 Thread via GitHub
snikeguo commented on issue #16400: URL: https://github.com/apache/nuttx/issues/16400#issuecomment-2888237447 ``` static sdio_capset_t stm32_capabilities(struct sdio_dev_s *dev) { struct stm32_dev_s *priv = (struct stm32_dev_s *)dev; sdio_capset_t caps = 0; if (priv->

Re: [PR] tools/CMakeLists.txt: Improvements to CMakeLists.txt file [nuttx]

2025-05-17 Thread via GitHub
lupyuen merged PR #16402: URL: https://github.com/apache/nuttx/pull/16402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [I] [HELP] STM32H723+SDMMC2+SDRAM(executing in sdram)+IDMA+FATFS,read/write file failure [nuttx]

2025-05-17 Thread via GitHub
snikeguo closed issue #16400: [HELP] STM32H723+SDMMC2+SDRAM(executing in sdram)+IDMA+FATFS,read/write file failure URL: https://github.com/apache/nuttx/issues/16400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [HELP] STM32H723+SDMMC2+SDRAM(executing in sdram)+IDMA+FATFS,read/write file failure [nuttx]

2025-05-17 Thread via GitHub
snikeguo commented on issue #16400: URL: https://github.com/apache/nuttx/issues/16400#issuecomment-2888202105 solution: CONFIG_FAT_DMAMEMORY=y CONFIG_GRAN=y CONFIG_STM32H7_SDMMC_IDMA=y CONFIG_ARMV7M_DCACHE_WRITETHROUGH=n see:armv7m mpu document in stm32_dmarecvsetup:

Re: [I] [HELP] SD Card imxrt_dmapreflight: dcache unaligned buffer:0x202458b8 end:0x20245ab7 [nuttx]

2025-05-17 Thread via GitHub
snikeguo commented on issue #16159: URL: https://github.com/apache/nuttx/issues/16159#issuecomment-2888201707 @keever50 solution: CONFIG_FAT_DMAMEMORY=y CONFIG_GRAN=y CONFIG_STM32H7_SDMMC_IDMA=y CONFIG_ARMV7M_DCACHE_WRITETHROUGH=n see:armv7m mpu document in stm32_

Re: [I] [BUG] imx93-evk/bootloader: undefined reference to `main' [nuttx]

2025-05-17 Thread via GitHub
lupyuen closed issue #16404: [BUG] imx93-evk/bootloader: undefined reference to `main' URL: https://github.com/apache/nuttx/issues/16404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [BUG] imx93-evk/bootloader: undefined reference to `main' [nuttx]

2025-05-17 Thread via GitHub
lupyuen commented on issue #16404: URL: https://github.com/apache/nuttx/issues/16404#issuecomment-2888179739 Build is OK now https://github.com/NuttX/nuttx/actions/runs/15081641852/job/42399073623#step:7:105 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] tools/nxstyle.c: fix error Relative file path on Windows Native [nuttx]

2025-05-17 Thread via GitHub
raiden00pl commented on code in PR #16396: URL: https://github.com/apache/nuttx/pull/16396#discussion_r2093982218 ## tools/nxstyle.c: ## @@ -719,6 +723,63 @@ static void show_usage(char *progname, int exitcode, char *what) exit(exitcode); } +#ifndef HAVE_STRNDUP +/***