Re: [PR] examples/xmlrpc: Fix calls buffers size. [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen merged PR #3027: URL: https://github.com/apache/nuttx-apps/pull/3027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] nuttx/wireless/ioctl: Common IOCTL API for RF Modulation Technologies [nuttx]

2025-03-20 Thread via GitHub
hartmannathan commented on code in PR #16024: URL: https://github.com/apache/nuttx/pull/16024#discussion_r2006472694 ## Documentation/components/drivers/character/wireless/index.rst: ## @@ -6,3 +6,34 @@ Wireless character drivers :maxdepth: 1 lpwan/index.rst + +IOCTL Int

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen commented on code in PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006659386 ## examples/fbcon/Kconfig: ## @@ -0,0 +1,205 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX t

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
cederom commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2741984037 Hmm was this PR marked DRAFT and merged? We need to be more careful as it broke build for all other boards/config not using fbcon. DRAFT means NO MERGE! :-) Things to update (in

Re: [PR] examples/fbcon: Fix endchoice and help in Kconfig [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen merged PR #3032: URL: https://github.com/apache/nuttx-apps/pull/3032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] nuttx/wireless/ioctl: Common IOCTL API for RF Modulation Technologies [nuttx]

2025-03-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #16024: URL: https://github.com/apache/nuttx/pull/16024#discussion_r2006712477 ## include/nuttx/wireless/ioctl.h: ## @@ -48,67 +48,214 @@ * the open() interface. *

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2741994899 @cederom I think it was marked Ready For Review yesterday? - https://github.com/apache/nuttx-apps/pull/3029#event-16882080694 -- This is an automated message from the Apache Git Se

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
cederom commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742001058 Cool cool at least we have more focus now :D :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen commented on code in PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006672226 ## examples/fbcon/Kconfig: ## @@ -0,0 +1,205 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX t

(nuttx-apps) branch master updated: build.yml: Brought into sync with NuttX repository

2025-03-20 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository. lupyuen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 95c99d933 build.yml: Brought into sync with

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
hartmannathan commented on code in PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006577020 ## examples/fbcon/Kconfig: ## @@ -0,0 +1,205 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the N

Re: [PR] nuttx/wireless/ioctl: Common IOCTL API for RF Modulation Technologies [nuttx]

2025-03-20 Thread via GitHub
keever50 commented on PR #16024: URL: https://github.com/apache/nuttx/pull/16024#issuecomment-2741746752 Thank you for the spelling checks. These are now corrected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] boards/xtensa: Add support for szpi-esp32s3 [nuttx]

2025-03-20 Thread via GitHub
JianyuWang0623 commented on PR #16027: URL: https://github.com/apache/nuttx/pull/16027#issuecomment-2740972581 depends on https://github.com/apache/nuttx/pull/16025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005866451 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005863418 ## canutils/lely-canopen/Makefile: ## @@ -170,22 +170,31 @@ MAINSRC= $(LELYCANOPEN_SRCDIR)/tools/coctl.c endif # Download and unpack tarball if no git rep

Re: [PR] build.yml: Brought into sync with NuttX repository [nuttx-apps]

2025-03-20 Thread via GitHub
simbit18 commented on code in PR #3031: URL: https://github.com/apache/nuttx-apps/pull/3031#discussion_r2005847537 ## .github/workflows/build.yml: ## @@ -330,3 +331,55 @@ jobs: name: msys2-${{matrix.boards}}-builds path: buildartifacts/ continue-on

Re: [PR] build.yml: Brought into sync with NuttX repository [nuttx-apps]

2025-03-20 Thread via GitHub
simbit18 commented on code in PR #3031: URL: https://github.com/apache/nuttx-apps/pull/3031#discussion_r2005833598 ## .github/workflows/build.yml: ## @@ -330,3 +331,55 @@ jobs: name: msys2-${{matrix.boards}}-builds path: buildartifacts/ continue-on

Re: [PR] build.yml: Brought into sync with NuttX repository [nuttx-apps]

2025-03-20 Thread via GitHub
lupyuen commented on code in PR #3031: URL: https://github.com/apache/nuttx-apps/pull/3031#discussion_r2005810973 ## .github/workflows/build.yml: ## @@ -330,3 +331,55 @@ jobs: name: msys2-${{matrix.boards}}-builds path: buildartifacts/ continue-on-

[PR] include/nuttx/math.h: add missing HUGE_VALF and HUGE_VALL [nuttx]

2025-03-20 Thread via GitHub
raiden00pl opened a new pull request, #16028: URL: https://github.com/apache/nuttx/pull/16028 ## Summary add missing HUGE_VALF and HUGE_VALL definitions to NuttX math.h ## Impact fix compilation errors for third party code that needs these definitions and we build with N

Re: [PR] Documentation/xtensa/esp32: Add snake game documentation [nuttx]

2025-03-20 Thread via GitHub
acassis commented on PR #16006: URL: https://github.com/apache/nuttx/pull/16006#issuecomment-2740496934 @eren-terzioglu please refresh the snake defconfig, it is reporting error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-20 Thread via GitHub
acassis commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2740435332 > > > I am going to add a Kconfig option for whether to intercept/redirect STDIN - it's necessary for NSH but probably is not if the FB is just used for output from the majority of otg

Re: [PR] boards/xtensa: Add support for szpi-esp32s3 [nuttx]

2025-03-20 Thread via GitHub
JianyuWang0623 commented on PR #16027: URL: https://github.com/apache/nuttx/pull/16027#issuecomment-2740339301 @tmedicci @Donny9 Could you review this patch please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] boards/xtensa: Add support for szpi-esp32s3 [nuttx]

2025-03-20 Thread via GitHub
nuttxpr commented on PR #16027: URL: https://github.com/apache/nuttx/pull/16027#issuecomment-2740334714 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. T

Re: [PR] mpfs/mpfs_rcc: Add stub driver for FPGA clock and reset controller [nuttx]

2025-03-20 Thread via GitHub
lupyuen commented on PR #16026: URL: https://github.com/apache/nuttx/pull/16026#issuecomment-2740290675 Please remember to sign-off with `git commit -s`. Thanks :-) - https://github.com/apache/nuttx/pull/16026/commits/d28f80b230c5f9f22051ea6ace7d1be26ce3cbc6 -- This is an automated mes

Re: [PR] arch/xtensa/espressif: Fix I2C Slave driver error [nuttx]

2025-03-20 Thread via GitHub
eren-terzioglu commented on PR #15993: URL: https://github.com/apache/nuttx/pull/15993#issuecomment-2739888646 Thanks @anchao, updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Update gd55.c to fix uninitialised variables [nuttx]

2025-03-20 Thread via GitHub
TimJTi commented on PR #16021: URL: https://github.com/apache/nuttx/pull/16021#issuecomment-2739831366 > Please remember to fill in the Commit Message, and sign off with `git commit -s`. Thanks :-) > > * [578f86b](https://github.com/apache/nuttx/commit/578f86be318495236973e96ea7a8bf3

Re: [PR] nuttx/wireless/ioctl: Common IOCTL API for RF Modulation Technologies [nuttx]

2025-03-20 Thread via GitHub
lupyuen commented on PR #16024: URL: https://github.com/apache/nuttx/pull/16024#issuecomment-2739800941 Yep we just updated the guidelines here :-) https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] boards/esp32s3: Merge common configurations [nuttx]

2025-03-20 Thread via GitHub
JianyuWang0623 commented on PR #16025: URL: https://github.com/apache/nuttx/pull/16025#issuecomment-2739751579 @tmedicci @Donny9 Could you review this patch please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005159675 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon

Re: [PR] fix build for canutilis/lely-canopen [nuttx-apps]

2025-03-20 Thread via GitHub
raiden00pl commented on code in PR #3030: URL: https://github.com/apache/nuttx-apps/pull/3030#discussion_r2005037542 ## canutils/lely-canopen/0003-tools-coctl.c-use-readline-and-fix-printf-issues.patch: ## @@ -0,0 +1,101 @@ +From 737d4b02ba71737a83be223001df6f53c5936ef8 Mon Sep

Re: [PR] arch/xtensa: fix definition for `_int32_t` and `_uint32_t` [nuttx]

2025-03-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #16022: URL: https://github.com/apache/nuttx/pull/16022#discussion_r2005015226 ## arch/xtensa/src/common/espressif/esp_loader.c: ## @@ -209,7 +209,7 @@ int map_rom_segments(uint32_t app_drom_start, uint32_t app_drom_vaddr, ram_

Re: [PR] Documentation/games: Add snake game docs [nuttx]

2025-03-20 Thread via GitHub
eren-terzioglu commented on PR #16007: URL: https://github.com/apache/nuttx/pull/16007#issuecomment-2739495239 > @eren-terzioglu please include the schematic drawing I added on Espressif update MR https://github.com/apache/nuttx/pull/16006 -- This is an automated message from the Ap