Re: [PR] apps/system: replace CONFIG_NSH_LINELEN to LINE_MAX [nuttx-apps]

2024-12-28 Thread via GitHub
anchao commented on code in PR #2918: URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899073456 ## nshlib/nsh_console.h: ## @@ -157,6 +157,14 @@ struct nsh_vtbl_s char traceline[CONFIG_NSH_LINELEN]; #endif + /* Temporary line buffer */ + +#if (!defined(CO

Re: [PR] sched/semaphore: tick wait 0 timeout should be safe in interrupt context [nuttx]

2024-12-28 Thread via GitHub
anchao commented on code in PR #15377: URL: https://github.com/apache/nuttx/pull/15377#discussion_r1899073437 ## sched/semaphore/sem_tickwait.c: ## @@ -68,12 +68,10 @@ int nxsem_tickwait(FAR sem_t *sem, uint32_t delay) { - FAR struct tcb_s *rtcb = this_task(); + FAR struct

Re: [PR] Update toywasm to v65.0.0 and fixes SPDX stuff [nuttx-apps]

2024-12-28 Thread via GitHub
nuttxpr commented on PR #2920: URL: https://github.com/apache/nuttx-apps/pull/2920#issuecomment-2564630828 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit wi

Re: [PR] nuttx/apps: migrate to SPDX identifier [nuttx-apps]

2024-12-28 Thread via GitHub
yamt commented on PR #2909: URL: https://github.com/apache/nuttx-apps/pull/2909#issuecomment-2564629940 this broke toywasm regen.sh. https://github.com/apache/nuttx-apps/pull/2920 contains a fix. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Update toywasm to v65.0.0 and fixes SPDX stuff [nuttx-apps]

2024-12-28 Thread via GitHub
yamt opened a new pull request, #2920: URL: https://github.com/apache/nuttx-apps/pull/2920 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] sched/semaphore: tick wait 0 timeout should be safe in interrupt context [nuttx]

2024-12-28 Thread via GitHub
anchao commented on code in PR #15377: URL: https://github.com/apache/nuttx/pull/15377#discussion_r1899071035 ## sched/semaphore/sem_tickwait.c: ## @@ -68,12 +68,10 @@ int nxsem_tickwait(FAR sem_t *sem, uint32_t delay) { - FAR struct tcb_s *rtcb = this_task(); + FAR struct

(nuttx) branch master updated: Doc: loading ELF program

2024-12-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 04c7391162 Doc: loading ELF program 04c7391162

Re: [PR] Doc: loading ELF program [nuttx]

2024-12-28 Thread via GitHub
xiaoxiang781216 merged PR #15376: URL: https://github.com/apache/nuttx/pull/15376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sched/semaphore: tick wait 0 timeout should be safe in interrupt context [nuttx]

2024-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #15377: URL: https://github.com/apache/nuttx/pull/15377#discussion_r1899070361 ## sched/semaphore/sem_tickwait.c: ## @@ -68,12 +68,10 @@ int nxsem_tickwait(FAR sem_t *sem, uint32_t delay) { - FAR struct tcb_s *rtcb = this_task(); + F

Re: [PR] apps/system: replace CONFIG_NSH_LINELEN to LINE_MAX [nuttx-apps]

2024-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #2918: URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899069478 ## nshlib/nsh_console.h: ## @@ -157,6 +157,14 @@ struct nsh_vtbl_s char traceline[CONFIG_NSH_LINELEN]; #endif + /* Temporary line buffer */ + +#if (!d

[PR] sched/semaphore: tick wait 0 timeout should be safe in interrupt context [nuttx]

2024-12-28 Thread via GitHub
anchao opened a new pull request, #15377: URL: https://github.com/apache/nuttx/pull/15377 ## Summary sched/semaphore: tick wait 0 timeout should be safe in interrupt context 1. remove up_interrupt_context() check, which should be safe in interrupt context 2. remove sem instance

(nuttx) branch master updated: rpmsg/rpmsg_virtio_lite: rename rpmsg_virtio to rpmsg_virtio_lite

2024-12-28 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f0a3c43a54 rpmsg/rpmsg_virtio_lite: rename rpmsg

Re: [PR] rpmsg/rpmsg_virtio_lite: rename rpmsg_virtio to rpmsg_virtio_lite [nuttx]

2024-12-28 Thread via GitHub
acassis merged PR #15336: URL: https://github.com/apache/nuttx/pull/15336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] Doc: loading ELF program [nuttx]

2024-12-28 Thread via GitHub
acassis commented on PR #15376: URL: https://github.com/apache/nuttx/pull/15376#issuecomment-2564580157 Nice work @lvanasse !!! Did you test this documentation recently? Many of our old documentation is outdated and needs to be update to reflect current NuttX code -- This is an automated

Re: [I] Documentation: migrate pages from wiki [nuttx]

2024-12-28 Thread via GitHub
lvanasse commented on issue #11127: URL: https://github.com/apache/nuttx/issues/11127#issuecomment-2564575463 @raiden00pl here's 1 other page to check (once they are merged) :) https://github.com/apache/nuttx/pull/15376 : * [Updating a Release System with ELF Programs](https://

Re: [PR] Doc: loading ELF program [nuttx]

2024-12-28 Thread via GitHub
nuttxpr commented on PR #15376: URL: https://github.com/apache/nuttx/pull/15376#issuecomment-2564574202 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR likely does *not* fully meet the NuttX requ

[PR] Doc: loading ELF program [nuttx]

2024-12-28 Thread via GitHub
lvanasse opened a new pull request, #15376: URL: https://github.com/apache/nuttx/pull/15376 Migrate the Updating a release system with ELF programs with child pages to official wiki. ## Summary Migrated the Updating a release system with ELF programs with its child pages to th

Re: [I] Documentation: migrate pages from wiki [nuttx]

2024-12-28 Thread via GitHub
lvanasse commented on issue #11127: URL: https://github.com/apache/nuttx/issues/11127#issuecomment-2564476012 @raiden00pl I see that you've written about the SMARTFS in the official documentation. I was wondering if we ought to still do the * https://cwiki.apache.org/confluence/display/NU

Re: [PR] {bp-15353} fix compile error [nuttx]

2024-12-28 Thread via GitHub
xiaoxiang781216 merged PR #15375: URL: https://github.com/apache/nuttx/pull/15375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch releases/12.8 updated: fix compile error

2024-12-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.8 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.8 by this push: new b1876144ee fix compile error b18

(nuttx) 02/02: Documentation: add NuttX-12.8.0 release notes

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit db1ebe00951d28a9a7f005a2f0a14d8f6b41c0eb Author: Alin Jerpelea AuthorDate: Sat Dec 28 11:59:58 2024 +0100 Documentat

(nuttx) 01/02: Documentation: add NuttX-12.7.0 release notes

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 48f80bf41e000289f33454264f4cf2ed2b2c3b04 Author: Alin Jerpelea AuthorDate: Sat Dec 28 11:56:18 2024 +0100 Documentat

(nuttx) branch master updated (1cfab89e65 -> db1ebe0095)

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 1cfab89e65 Added incomplete octospi hardware defintions. new 48f80bf41e Documentation: add NuttX-12.7.0 release no

Re: [PR] Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
anchao merged PR #15373: URL: https://github.com/apache/nuttx/pull/15373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) 01/02: Documentation: add NuttX-12.7.0 release notes

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch releases/12.8 in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 21113bba5c21d911046f724ee3c35eae56a99363 Author: Alin Jerpelea AuthorDate: Sat Dec 28 11:56:18 2024 +0100 Doc

(nuttx) 02/02: Documentation: add NuttX-12.8.0 release notes

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch releases/12.8 in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 15d91f5639e5b579ad12855879bf0b07cba72ead Author: Alin Jerpelea AuthorDate: Sat Dec 28 11:59:58 2024 +0100 Doc

(nuttx) branch releases/12.8 updated (b2fc3b2d7f -> 15d91f5639)

2024-12-28 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch releases/12.8 in repository https://gitbox.apache.org/repos/asf/nuttx.git from b2fc3b2d7f Thermal/step_wise: Fix that hysteresis takes no effect new 21113bba5c Documentation: add NuttX-1

Re: [PR] {bp-15373} Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
anchao merged PR #15374: URL: https://github.com/apache/nuttx/pull/15374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
nuttxpr commented on PR #15373: URL: https://github.com/apache/nuttx/pull/15373#issuecomment-2564299173 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] {bp-15373} Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
nuttxpr commented on PR #15374: URL: https://github.com/apache/nuttx/pull/15374#issuecomment-2564298926 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] {bp-15353} fix compile error [nuttx]

2024-12-28 Thread via GitHub
nuttxpr commented on PR #15375: URL: https://github.com/apache/nuttx/pull/15375#issuecomment-2564298696 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. The

[PR] {bp-15373} Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
jerpelea opened a new pull request, #15374: URL: https://github.com/apache/nuttx/pull/15374 ## Summary add NuttX 12.8.0 Release notes add NuttX 12.7.0 Release notes ## Impact RELEASE ## Testing NONE -- This is an automated message from the Apac

[PR] {bp-15353} fix compile error [nuttx]

2024-12-28 Thread via GitHub
jerpelea opened a new pull request, #15375: URL: https://github.com/apache/nuttx/pull/15375 ## Summary chip/efm32_leserial.c: In function 'efm32_restoreuartint': Error: chip/efm32_leserial.c:329:37: error: 'len' undeclared (first use in this function); did you mean 'ien'? 329 | ef

[PR] Documentation: add NuttX 12.8.0 Release notes [nuttx]

2024-12-28 Thread via GitHub
jerpelea opened a new pull request, #15373: URL: https://github.com/apache/nuttx/pull/15373 ## Summary add NuttX 12.8.0 Release notes add NuttX 12.7.0 Release notes ## Impact Documentation ## Testing NONE -- This is an automated message from the Ap

Re: [PR] Reduce the size of tcb [nuttx]

2024-12-28 Thread via GitHub
hujun260 commented on PR #15345: URL: https://github.com/apache/nuttx/pull/15345#issuecomment-2564278983 fix compile error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Reduce the size of tcb [nuttx]

2024-12-28 Thread via GitHub
hujun260 commented on code in PR #15345: URL: https://github.com/apache/nuttx/pull/15345#discussion_r1898879690 ## arch/arm/src/arm/arm_sigdeliver.c: ## @@ -60,8 +60,8 @@ void arm_sigdeliver(void) board_autoled_on(LED_SIGNAL); sinfo("rtcb=%p sigdeliver=%p sigpendactionq.

Re: [PR] Reduce the size of tcb [nuttx]

2024-12-28 Thread via GitHub
hujun260 commented on code in PR #15345: URL: https://github.com/apache/nuttx/pull/15345#discussion_r1898877417 ## arch/z16/src/common/z16_sigdeliver.c: ## @@ -62,8 +62,8 @@ void z16_sigdeliver(void) board_autoled_on(LED_SIGNAL); sinfo("rtcb=%p sigdeliver=%p sigpendactio

Re: [PR] Reduce the size of tcb [nuttx]

2024-12-28 Thread via GitHub
hujun260 commented on code in PR #15345: URL: https://github.com/apache/nuttx/pull/15345#discussion_r1898877417 ## arch/z16/src/common/z16_sigdeliver.c: ## @@ -62,8 +62,8 @@ void z16_sigdeliver(void) board_autoled_on(LED_SIGNAL); sinfo("rtcb=%p sigdeliver=%p sigpendactio

Re: [PR] sched: remove all spin_lock_irqsave(NULL) [nuttx]

2024-12-28 Thread via GitHub
hujun260 commented on code in PR #15324: URL: https://github.com/apache/nuttx/pull/15324#discussion_r1898875549 ## sched/clock/clock_systime_timespec.c: ## @@ -62,21 +62,21 @@ int clock_systime_timespec(FAR struct timespec *ts) { #ifdef CONFIG_RTC_HIRES + irqstate_t flags; +