anchao commented on code in PR #15377:
URL: https://github.com/apache/nuttx/pull/15377#discussion_r1899073437
##########
sched/semaphore/sem_tickwait.c:
##########
@@ -68,12 +68,10 @@
int nxsem_tickwait(FAR sem_t *sem, uint32_t delay)
{
- FAR struct tcb_s *rtcb = this_task();
+ FAR struct tcb_s *rtcb;
irqstate_t flags;
int ret;
- DEBUGASSERT(sem != NULL && up_interrupt_context() == false);
Review Comment:
Compared with irregular heap access, shared template and will make it more
deterministic
##########
sched/semaphore/sem_tickwait.c:
##########
@@ -68,12 +68,10 @@
int nxsem_tickwait(FAR sem_t *sem, uint32_t delay)
{
- FAR struct tcb_s *rtcb = this_task();
+ FAR struct tcb_s *rtcb;
irqstate_t flags;
int ret;
- DEBUGASSERT(sem != NULL && up_interrupt_context() == false);
Review Comment:
Compared with irregular heap access, shared template and will make it more
deterministic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
