Re: [I] iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? [nuttx]

2023-11-04 Thread via GitHub
wengzhe commented on issue #11123: URL: https://github.com/apache/nuttx/issues/11123#issuecomment-1793651232 As far as I know, both `io_offset` and `io_len` do not count `io_offset`, which means the sum of `io_len` should be `io_offset`. If not, I believe it's the operation that makes them

(nuttx-apps) branch master updated: examples/foc: refactor control loop

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 73ab7dedd examples/foc: refactor control

Re: [PR] examples/foc: refactor control loop [nuttx-apps]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #2175: URL: https://github.com/apache/nuttx-apps/pull/2175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: feature: spinlock benchmark

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 388256b7d feature: spinlock benchmark 388

Re: [PR] feature: spinlock benchmark [nuttx-apps]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #2168: URL: https://github.com/apache/nuttx-apps/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Add Settings Utility and Example App [nuttx-apps]

2023-11-04 Thread via GitHub
xiaoxiang781216 commented on PR #2178: URL: https://github.com/apache/nuttx-apps/pull/2178#issuecomment-1793643662 how about system/ folder? Many utility libraries put there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382503223 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: can w

(nuttx-apps) branch master updated: industrial/foc: add options to configure foclib logs

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 57f98ee20 industrial/foc: add options to

Re: [PR] industrial/foc: add options to configure foclib logs [nuttx-apps]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #2176: URL: https://github.com/apache/nuttx-apps/pull/2176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382503223 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: can w

(nuttx) 08/09: Documentation: migrate "SMP Critical Sections" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f96064db75fe79e8ffb2a0d4a51fa7e063a5e068 Author: raiden00pl AuthorDate: Sat Nov 4 21:23:55 2023 +0100 Documentati

(nuttx) branch master updated (fdc671fa3e -> ffc5434a8c)

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fdc671fa3e Documentation: migrate "Critical Section Monitor" from wiki add 34476b497f sched/semaphore/spinlock.

(nuttx) 01/09: Documentation: fix warning

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit bfd342b4ebc0bf10d0695f1e909218b46ee4c0e8 Author: raiden00pl AuthorDate: Sat Nov 4 20:17:59 2023 +0100 Documentati

Re: [PR] rw spinlocks: cosmetic changes [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #11124: URL: https://github.com/apache/nuttx/pull/11124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 06/09: Documentation: migrate "apps/tools/mkromfsimg.sh" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit adc557f545fd22996efe4f06ecf4a732b87419c5 Author: raiden00pl AuthorDate: Sat Nov 4 19:55:15 2023 +0100 Documentati

(nuttx) 04/09: Documentation: migrate "Running Applications from NSH" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 03b4ec60a5ceaad3f5491635ef311bf26d88aa98 Author: raiden00pl AuthorDate: Sat Nov 4 20:12:22 2023 +0100 Documentati

(nuttx) 02/09: Documentation: migrate "NuttX Graphics Subsystem (NX)" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 63558cf72f31b46e578d8ffd3d6618347b9d44d8 Author: raiden00pl AuthorDate: Sat Nov 4 17:58:33 2023 +0100 Documentati

Re: [PR] Documentation: migrate some wiki pages [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #11128: URL: https://github.com/apache/nuttx/pull/11128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 03/09: Documentation: migrate "Wide Font Support" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit de564d38e9d8d03084c417ca141ea68372ac7eb9 Author: raiden00pl AuthorDate: Sat Nov 4 18:07:46 2023 +0100 Documentati

(nuttx) 07/09: Documentation: CONFIG_USER_ENTRYPOINT was changed to CONFIG_INIT_ENTRYPOINT

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 20fd7f588ff4d72527c1f3e768b1464effed0ee6 Author: raiden00pl AuthorDate: Sat Nov 4 20:56:10 2023 +0100 Documentati

(nuttx) 09/09: Documentation: migrate "Critical Section Monitor" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fdc671fa3e59e31154e44c439ae7ec0dd8e56206 Author: raiden00pl AuthorDate: Sat Nov 4 21:59:24 2023 +0100 Documentati

(nuttx) branch master updated (43ecf36d78 -> fdc671fa3e)

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 43ecf36d78 udp: modify ipv4 multicast to allow different conn to join simultaneously new bfd342b4eb Documentat

(nuttx) 05/09: Documentation: migrate "Linux Processes vs NuttX Tasks" from wiki

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3b23a693acb2d6e148b0b258d6d13d211fc7389c Author: raiden00pl AuthorDate: Sat Nov 4 20:41:19 2023 +0100 Documentati

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 43ecf36d787d681e1c194277c09f32c92f1d58be

2023-11-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 34092d0e Publishing web: 36ddd7c6

[PR] Documentation: migrate some wiki pages [nuttx]

2023-11-04 Thread via GitHub
raiden00pl opened a new pull request, #11128: URL: https://github.com/apache/nuttx/pull/11128 ## Summary - Documentation: fix warning - Documentation: migrate "NuttX Graphics Subsystem (NX)" from wiki - Documentation: migrate "Wide Font Support" from wiki - Documentation: migrate

[I] Documentation: migrate pages from wiki [nuttx]

2023-11-04 Thread via GitHub
raiden00pl opened a new issue, #11127: URL: https://github.com/apache/nuttx/issues/11127 Not all pages below are suitable for migration, some pages are outdated, some are already migrated. Everything listed here for better tracking of the issue. **Getting Started with NuttX** https:

Re: [PR] Add Settings Utility and Example App [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi commented on PR #2178: URL: https://github.com/apache/nuttx-apps/pull/2178#issuecomment-1793476519 OK - I assume it's because a created a new "top level" folder (utils) for the settings functions rather than placing it under some pre-existing folder? If someone can propose a go

Re: [PR] Add Settings Utility and Example App [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi commented on PR #2178: URL: https://github.com/apache/nuttx-apps/pull/2178#issuecomment-1793454266 I have no idea why this is failing CI? HELP! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] net/tcp: Support initial sequence number described in RFC 6528 [nuttx]

2023-11-04 Thread via GitHub
wengzhe opened a new pull request, #11126: URL: https://github.com/apache/nuttx/pull/11126 ## Summary - Patches included: - net/tcp: Take out get random process as common function - net/tcp: Support initial sequence number described in RFC 6528 Support initial sequence num

Re: [PR] implement read-write lock based on nxmutex [nuttx]

2023-11-04 Thread via GitHub
zouboan commented on PR #9739: URL: https://github.com/apache/nuttx/pull/9739#issuecomment-1793450219 #6012 has a more efficient solution in #11125, so i close this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] implement read-write lock based on nxmutex [nuttx]

2023-11-04 Thread via GitHub
zouboan closed pull request #9739: implement read-write lock based on nxmutex URL: https://github.com/apache/nuttx/pull/9739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
zouboan commented on PR #11125: URL: https://github.com/apache/nuttx/pull/11125#issuecomment-1793449389 got it,thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add settings utility and example app [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi closed pull request #2173: Add settings utility and example app URL: https://github.com/apache/nuttx-apps/pull/2173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Add settings utility and example app [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi commented on PR #2173: URL: https://github.com/apache/nuttx-apps/pull/2173#issuecomment-1793448262 Something went very weirdly wrong with my repo and/or PR...will resubmit! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] Add Settings Utility and Example App [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi opened a new pull request, #2178: URL: https://github.com/apache/nuttx-apps/pull/2178 Last year @fjpanag offered to donate some code to the repo. This is my attempt at making his "settings" functions NuttX compatible along with an example app to check it out Impact None. Th

Re: [PR] Test to see if ci works [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi closed pull request #2177: Test to see if ci works URL: https://github.com/apache/nuttx-apps/pull/2177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Test to see if ci works [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi commented on PR #2177: URL: https://github.com/apache/nuttx-apps/pull/2177#issuecomment-1793439176 Nope - some problem my end -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Test to see if ci works [nuttx-apps]

2023-11-04 Thread via GitHub
TimJTi opened a new pull request, #2177: URL: https://github.com/apache/nuttx-apps/pull/2177 ## Summary Previous PR causing many CI errors - seeing if this passes ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
raiden00pl commented on PR #11125: URL: https://github.com/apache/nuttx/pull/11125#issuecomment-1793433899 The logic within `spin_lock_irqsave()` should not suspend (according to https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=139629502). In this case `nxmutex_lock()` may

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
zouboan commented on PR #11125: URL: https://github.com/apache/nuttx/pull/11125#issuecomment-1793429754 Is there any problem with using spin_lock_irqsave and spin_unlock_irqrestore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[PR] industrial/foc: add options to configure foclib logs [nuttx-apps]

2023-11-04 Thread via GitHub
raiden00pl opened a new pull request, #2176: URL: https://github.com/apache/nuttx-apps/pull/2176 ## Summary industrial/foc: add options to configure foclib logs ## Impact ## Testing ci -- This is an automated message from the Apache Git Service. To respond to the messag

[PR] examples/foc: refactor control loop [nuttx-apps]

2023-11-04 Thread via GitHub
raiden00pl opened a new pull request, #2175: URL: https://github.com/apache/nuttx-apps/pull/2175 ## Summary - examples/foc: refactor control loop 1. get FOC device state at the beginning of the loop 2. simplify if-else block ## Impact refactor ## Testing

[PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-04 Thread via GitHub
raiden00pl opened a new pull request, #11125: URL: https://github.com/apache/nuttx/pull/11125 ## Summary - fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex this fixes the issue https://github.com/apache/nuttx/issues/6012 ## Impact ## Testin

Re: [I] Low priority tasks interrupt high priority threads [nuttx]

2023-11-04 Thread via GitHub
raiden00pl commented on issue #6012: URL: https://github.com/apache/nuttx/issues/6012#issuecomment-1793405693 @zouboan rwlock from https://github.com/apache/nuttx/pull/10776 will work only for SMP, otherwise it may cause deadlocks under certain conditions. So unfortunately it won't help us

Re: [I] Low priority tasks interrupt high priority threads [nuttx]

2023-11-04 Thread via GitHub
zouboan commented on issue #6012: URL: https://github.com/apache/nuttx/issues/6012#issuecomment-1793402243 I tried use rwlock_t in #10776 to solve this issue, but unfortunately, there are some compilation errors: ``` CXX: libcxxmini/libxx_delete.cxx In file included from /home/zouboa

(nuttx) branch master updated: udp: modify ipv4 multicast to allow different conn to join simultaneously

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 43ecf36d78 udp: modify ipv4 multicast to allow

Re: [PR] udp: modify ipv4 multicast to allow different conn to join simultaneously [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #11120: URL: https://github.com/apache/nuttx/pull/11120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sim_netdriver: some sim defconfig have problems when using the network [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #11122: URL: https://github.com/apache/nuttx/pull/11122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (3a9c193bf7 -> 7c322c250a)

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3a9c193bf7 ioctl: add SIOCGIWNAME support add 7c322c250a sim_netdriver: some sim defconfig have problems when u

(nuttx) branch master updated: ioctl: add SIOCGIWNAME support

2023-11-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3a9c193bf7 ioctl: add SIOCGIWNAME support 3a9c

Re: [PR] ioctl: add SIOCGIWNAME support [nuttx]

2023-11-04 Thread via GitHub
xiaoxiang781216 merged PR #11121: URL: https://github.com/apache/nuttx/pull/11121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] Update serialrx_main.c [nuttx-apps]

2023-11-04 Thread via GitHub
GC-20-20 opened a new pull request, #2174: URL: https://github.com/apache/nuttx-apps/pull/2174 Add missing variables ## Summary Add missing variables ## Impact Missing variables will not compile ## Testing local test -- This is an automated message from the Apache

[PR] rw spinlocks: cosmetic changes [nuttx]

2023-11-04 Thread via GitHub
raiden00pl opened a new pull request, #11124: URL: https://github.com/apache/nuttx/pull/11124 ## Summary - sched/semaphore/spinlock.c: cosmetics - sched/Kconfig: RW_SPINLOCK depends on SPINLOCK ## Impact ## Testing CI -- This is an automated message from the