[GitHub] [nuttx-apps] lucasssvaz commented on pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#issuecomment-1495285442 Added support for CROMFS and fixed console output when ```CONFIG_DEFAULT_SMALL``` is enabled. -- This is an automated message from the Apache Git Service. To respond to the messag

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: d3f659b85427401c334aea8f2c633516222f7982

2023-04-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new eebdd333 Publishing web: b50f5ca4

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1156561953 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/romloa

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1156559000 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/romloa

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1156557607 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/romloa

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1156557607 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/romloa

[GitHub] [nuttx] radek-pesina commented on a diff in pull request #8922: eMMC driver support

2023-04-03 Thread via GitHub
radek-pesina commented on code in PR #8922: URL: https://github.com/apache/nuttx/pull/8922#discussion_r1156549982 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -3722,24 +3836,29 @@ static int mmcsd_probe(FAR struct mmcsd_state_s *priv) /* Bit 1: SD version 1.x */

[GitHub] [nuttx] gustavonihei opened a new pull request, #8957: risc-v/espressif: Add support for Periodic and Oneshot Timers

2023-04-03 Thread via GitHub
gustavonihei opened a new pull request, #8957: URL: https://github.com/apache/nuttx/pull/8957 ## Summary This PR intends to add support for both the Periodic (`CONFIG_TIMER`) and Oneshot (`CONFIG_ONESHOT`) timers for the currently supported Espressif RISC-V based chips: - **ESP32-

[GitHub] [nuttx] acassis commented on pull request #8955: sched/assert: Simplify the fatal detection logic

2023-04-03 Thread via GitHub
acassis commented on PR #8955: URL: https://github.com/apache/nuttx/pull/8955#issuecomment-1494933276 @xiaoxiang781216 although the code became optimized, I think the older way was easier to read :-D -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on PR #8940: URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1494860709 Ok, I fix the problem with a different method, @davids5 please review this patch: https://github.com/apache/nuttx/pull/8956. -- This is an automated message from the Apache Git Se

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8956: Let BOARDIOC_SOFTRESETCAUSE_ASSERT equals to the default value of BOARD_ASSERT_RESET_VALUE

2023-04-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8956: URL: https://github.com/apache/nuttx/pull/8956 ## Summary Unify the software reset value, see the dissucsion: https://github.com/apache/nuttx/pull/8940 ## Impact ## Testing CI -- This is an automated message fro

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8955: sched/assert: Simplify the fatal detection logic

2023-04-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8955: URL: https://github.com/apache/nuttx/pull/8955 ## Summary ## Impact Code refactor only ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nuttx] gustavonihei opened a new pull request, #8954: risc-v/espressif: Panic if CPU interrupt allocation fails

2023-04-03 Thread via GitHub
gustavonihei opened a new pull request, #8954: URL: https://github.com/apache/nuttx/pull/8954 ## Summary This PR intends to simplify the error handling of CPU interrupt allocation for Espressif's chis supported within `risc-v/espressif` tree. Instead of propagating an `-ENOMEM`

[GitHub] [nuttx-apps] lucasssvaz commented on pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#issuecomment-1494817756 > > > This looks nice, can it also support the compressed version? > > > There is a formatting issue in the Kconfig. > > > > > > What exactly do you mean by "support the

[GitHub] [nuttx-apps] hartmannathan commented on pull request #1696: system/adb: Replace adb special reset cause with boardctl.h's value

2023-04-03 Thread via GitHub
hartmannathan commented on PR #1696: URL: https://github.com/apache/nuttx-apps/pull/1696#issuecomment-1494812310 Restarting checks... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[nuttx] branch master updated (12fda1da1c -> d3f659b854)

2023-04-03 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 12fda1da1c boards: Replace open/pread with file_open/file_pread add b43ca9fcdb boardctl.h: Move BOARDIOC_SO

[GitHub] [nuttx] hartmannathan merged pull request #8941: boardctl.h: Add BOARDIOC_SOFTRESETCAUSE_ENTER_BOOTLOADER reset cause

2023-04-03 Thread via GitHub
hartmannathan merged PR #8941: URL: https://github.com/apache/nuttx/pull/8941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx-apps] davids5 commented on pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
davids5 commented on PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#issuecomment-1494801152 > > This looks nice, can it also support the compressed version? > > There is a formatting issue in the Kconfig. > > What exactly do you mean by "support the compressed version

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1156322596 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/rom

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1693: system/composite_main.c: Hide fprintf behind macro to handle FILE_STR…

2023-04-03 Thread via GitHub
pkarashchenko merged PR #1693: URL: https://github.com/apache/nuttx-apps/pull/1693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[nuttx-apps] branch master updated: system/composite_main.c: Convert fprintf -> dprintf

2023-04-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new c694d8d90 system/composite_main.c: Co

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8943: stm32_eth: Added error handling for abnormal interrupts.

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #8943: URL: https://github.com/apache/nuttx/pull/8943#discussion_r1156315969 ## arch/arm/src/stm32/stm32_eth.c: ## @@ -2027,17 +2027,13 @@ static void stm32_interrupt_work(void *arg) stm32_putreg(ETH_DMAINT_NIS, STM32_ETH_DMASR);

[GitHub] [nuttx-apps] lucasssvaz commented on pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#issuecomment-1494753037 Current CI fail was due to an curl timeout and is not related to this MR: ```curl: (28) SSL connection timeout``` -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] gustavonihei opened a new pull request, #8953: risc-v/espressif: Add support for Tickless mode

2023-04-03 Thread via GitHub
gustavonihei opened a new pull request, #8953: URL: https://github.com/apache/nuttx/pull/8953 ## Summary This PR intends to add support for the operation of the NuttX scheduler under Tickless mode for the currently supported Espressif RISC-V based chips: - **ESP32-C3** - **ESP32

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1494735139 > > > > ls /data will report the error. This patch ensures the user get the consistent result regardless he launches the program from anywhere. > > > > > > > > > probably

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1156227458 ## netutils/ftpd/ftpd.c: ## @@ -1470,16 +1471,18 @@ static FAR char *ftpd_node2path(FAR struct ftpd_pathnode_s *node, { if (namelen <= 0

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1697: nshlib: Add boot command

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1697: URL: https://github.com/apache/nuttx-apps/pull/1697#discussion_r1156221756 ## nshlib/nsh_syscmds.c: ## @@ -318,6 +318,52 @@ int cmd_poweroff(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) } #endif +/***

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on PR #8940: URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1494664613 > Changing this API is not OK. It breaks systems that pass the value CONFIG_BOARD_ASSERT_RESET_VALUE to mean s something. 0 reboot, 1 boot to ROM... etc > > Once before t

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1156212603 ## system/zmodem/host/nuttx/config.h: ## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 Review Comment: I didn't notice tha

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1156206233 ## system/zmodem/host/nuttx/config.h: ## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 Review Comment: shold we keep thi

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1156205792 ## system/zmodem/host/nuttx/config.h: ## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 #define FAR #define DEBUGASSERT ass

[GitHub] [nuttx] wengzhe commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-03 Thread via GitHub
wengzhe commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1156106792 ## libs/libc/string/lib_strerror.c: ## @@ -367,6 +371,11 @@ static const struct errno_strmap_s g_errnomap[] = FAR char *strerror(int errnum) { +#ifdef CONFIG_LIBC_STR

[GitHub] [nuttx] no1wudi commented on pull request #8950: driver/telnet: Remove TELNET_CHARACTER_MODE

2023-04-03 Thread via GitHub
no1wudi commented on PR #8950: URL: https://github.com/apache/nuttx/pull/8950#issuecomment-1494462726 > Do we need to create issue instead of simply adding comment? We can create issue to track it, btw, I'll submit a fix this week. -- This is an automated message from the Apache Git

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1156067200 ## libs/libc/string/lib_strerror.c: ## @@ -367,6 +371,11 @@ static const struct errno_strmap_s g_errnomap[] = FAR char *strerror(int errnum) { +#ifdef CONFIG_LI

[GitHub] [nuttx] ALTracer commented on pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
ALTracer commented on PR #8906: URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1494463545 > But serious USB debugging without a dedicated USB protocol analyzer is terribly difficult. Unfortunately, these devices are not cheap. I can do Wireshark + usbmon, maybe even on a

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1156052730 ## examples/ustream/ustream_server.c: ## @@ -60,7 +60,7 @@ int main(int argc, FAR char *argv[]) /* Allocate a BIG buffer */ - buffer = (char*)malloc(2*

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1697: nshlib: Add boot command

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1697: URL: https://github.com/apache/nuttx-apps/pull/1697#discussion_r1156044184 ## nshlib/nsh_syscmds.c: ## @@ -318,6 +318,52 @@ int cmd_poweroff(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) } #endif +/*

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-03 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1494422906 Just drafted changes, but really didn't have time to run ostest. I would appreciate someone helping with that. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [nuttx] raiden00pl opened a new pull request, #8952: boards/stm32: add composite device configurations

2023-04-03 Thread via GitHub
raiden00pl opened a new pull request, #8952: URL: https://github.com/apache/nuttx/pull/8952 ## Summary - stm32f4discovery: add composite device configuration - stm32f4discovery/stm32_usbmsc.c: fix SD card initialization - stm32f4discovery/stm32_mmcsd.c: remove redundant SCK pin c

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-03 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1494420526 Just drafted changes, but really didn't have time to run ostest. I would appreciate someone helping with that. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [nuttx] pkarashchenko opened a new pull request, #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-03 Thread via GitHub
pkarashchenko opened a new pull request, #8951: URL: https://github.com/apache/nuttx/pull/8951 ## Summary Optimize semaphore holder check for priority inheritance ## Impact Should be none. Code clean-up ## Testing ostest -- This is an automated message from the Apach

[GitHub] [nuttx] raiden00pl commented on pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
raiden00pl commented on PR #8906: URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1494350468 > F411 has dwc2, and you were working with systemwide NuttX USB stack (and maybe NENDPOINTS). Could you suggest how to debug/trace this, apart from USBTRACE and logic analyzers (sigrok-p

[GitHub] [nuttx] tmedicci commented on pull request #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-04-03 Thread via GitHub
tmedicci commented on PR #8926: URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1494340494 > @acassis @tmedicci so do we need this change at all? Yes, at least for xtensa. Applying this patch and compiling using the older GCC avoids crashing, but doesn't solve the

[GitHub] [nuttx] ALTracer commented on a diff in pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
ALTracer commented on code in PR #8906: URL: https://github.com/apache/nuttx/pull/8906#discussion_r1155959781 ## boards/arm/stm32/stm32f411-minimum/src/stm32_composite.c: ## @@ -0,0 +1,276 @@ +/ + * boar

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1155953813 ## system/zmodem/host/nuttx/config.h: ## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 #define FAR #define DEBUGASSERT asser

[nuttx] branch master updated: boards: Replace open/pread with file_open/file_pread

2023-04-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 12fda1da1c boards: Replace open/pread with

[GitHub] [nuttx] pkarashchenko merged pull request #8942: boards: Replace open/pread with file_open/file_pread

2023-04-03 Thread via GitHub
pkarashchenko merged PR #8942: URL: https://github.com/apache/nuttx/pull/8942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx-apps] branch master updated: examples/ftpd: Add support for choosing address family

2023-04-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 93105568c examples/ftpd: Add support

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1689: examples/ftpd: Add support for choosing address family

2023-04-03 Thread via GitHub
pkarashchenko merged PR #1689: URL: https://github.com/apache/nuttx-apps/pull/1689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [nuttx] pkarashchenko commented on pull request #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-04-03 Thread via GitHub
pkarashchenko commented on PR #8926: URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1494311000 @acassis @tmedicci so do we need this change at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [nuttx] ALTracer commented on pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
ALTracer commented on PR #8906: URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1494309346 > @ALTracer have you tested composite with the latest master ? I submitted various changes for RNDIS and composite device last month and that should now work for STM32 OTGFS No, I d

[nuttx-apps] branch master updated (125cf7abe -> 75ddde9c5)

2023-04-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 125cf7abe nshlib: Fix the ps command format add 75ddde9c5 apps/examples/mqttc/Makefile: Add missing Ap

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1701: apps/examples/mqttc/Makefile: Add missing Apache Foundation copyright…

2023-04-03 Thread via GitHub
pkarashchenko merged PR #1701: URL: https://github.com/apache/nuttx-apps/pull/1701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #8906: URL: https://github.com/apache/nuttx/pull/8906#discussion_r1155946159 ## boards/arm/stm32/stm32f411-minimum/src/stm32_composite.c: ## @@ -0,0 +1,276 @@ +/ + *

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1155939974 ## fsutils/romloader/romloader_main.c: ## @@ -0,0 +1,103 @@ +/ + * apps/fsutils/rom

[GitHub] [nuttx] ALTracer commented on a diff in pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
ALTracer commented on code in PR #8906: URL: https://github.com/apache/nuttx/pull/8906#discussion_r1155939144 ## boards/arm/stm32/stm32f411-minimum/src/stm32_composite.c: ## @@ -0,0 +1,276 @@ +/ + * boar

[GitHub] [nuttx] ALTracer commented on a diff in pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
ALTracer commented on code in PR #8906: URL: https://github.com/apache/nuttx/pull/8906#discussion_r1155937482 ## boards/arm/stm32/stm32f411-minimum/configs/usbmsc/defconfig: ## @@ -0,0 +1,57 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. +# +# You can use "make menu

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
pkarashchenko commented on code in PR #8906: URL: https://github.com/apache/nuttx/pull/8906#discussion_r1155916197 ## boards/arm/stm32/stm32f411-minimum/configs/usbmsc/defconfig: ## @@ -0,0 +1,57 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. +# +# You can use "make

[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
hartmannathan commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155930585 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -866,30 +885,25 @@ void stm32_stdclockconfig(void) { } - /* Over-drive is needed if -

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
raiden00pl commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155921130 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -866,30 +885,25 @@ void stm32_stdclockconfig(void) { } - /* Over-drive is needed if - *

[GitHub] [nuttx] pkarashchenko commented on pull request #8950: driver/telnet: Remove TELNET_CHARACTER_MODE

2023-04-03 Thread via GitHub
pkarashchenko commented on PR #8950: URL: https://github.com/apache/nuttx/pull/8950#issuecomment-1494258731 Do we need to create issue instead of simply adding comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [nuttx] raiden00pl commented on pull request #8906: MiniF4 peripherals support improvements

2023-04-03 Thread via GitHub
raiden00pl commented on PR #8906: URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1494244301 @ALTracer have you tested composite with the latest master ? I submitted various changes for RNDIS and composite device last month and that should now work for STM32 OTGFS -- This is

[GitHub] [nuttx-apps] lucasssvaz commented on pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
lucasssvaz commented on PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#issuecomment-1494213399 > This looks nice, can it also support the compressed version? > > There is a formatting issue in the Kconfig. What exactly do you mean by "support the compressed versio

[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
hartmannathan commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155877905 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -866,30 +885,25 @@ void stm32_stdclockconfig(void) { } - /* Over-drive is needed if -

[GitHub] [nuttx-apps] davids5 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-03 Thread via GitHub
davids5 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1155796846 ## fsutils/romloader/Kconfig: ## @@ -0,0 +1,47 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX

[GitHub] [nuttx] davids5 commented on a diff in pull request #8922: eMMC driver support

2023-04-03 Thread via GitHub
davids5 commented on code in PR #8922: URL: https://github.com/apache/nuttx/pull/8922#discussion_r1155795029 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -3722,24 +3836,29 @@ static int mmcsd_probe(FAR struct mmcsd_state_s *priv) /* Bit 1: SD version 1.x */

[GitHub] [nuttx-apps] simbit18 opened a new pull request, #1701: apps/examples/mqttc/Makefile: Add missing Apache Foundation copyright…

2023-04-03 Thread via GitHub
simbit18 opened a new pull request, #1701: URL: https://github.com/apache/nuttx-apps/pull/1701 ## Summary Add missing Apache Foundation copyright header ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [nuttx] FASTSHIFT commented on pull request #8907: video/fb: add vsync offset support

2023-04-03 Thread via GitHub
FASTSHIFT commented on PR #8907: URL: https://github.com/apache/nuttx/pull/8907#issuecomment-1493936552 > @FASTSHIFT please include the summary in the commit log message. Do you have plans for this driver? Please consider submitting some usage application and also include a Documentation/

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1692: wamr: Simplify target handling by LLVM style arch info

2023-04-03 Thread via GitHub
no1wudi commented on code in PR #1692: URL: https://github.com/apache/nuttx-apps/pull/1692#discussion_r1155648371 ## Makefile: ## @@ -20,10 +20,7 @@ export APPDIR = $(CURDIR) include $(APPDIR)/Make.defs - -ifeq ($(CONFIG_INTERPRETERS_WAMR),y) - include $(APPDIR)$(DELIM)inte

[GitHub] [nuttx] no1wudi opened a new pull request, #8950: driver/telnet: Remove TELNET_CHARACTER_MODE

2023-04-03 Thread via GitHub
no1wudi opened a new pull request, #8950: URL: https://github.com/apache/nuttx/pull/8950 ## Summary If TELNET_CHARACTER_MODE is set, the ECHO must be handled by the telnet server. So this option is useless. We need a new approach to control the ECHO behavior. BTW,

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
raiden00pl commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155581522 ## arch/arm/src/stm32h7/stm32_otgdev.c: ## @@ -60,6 +60,16 @@ enabled. Enable STM32H7_HSI48 #endif +#if defined(CONFIG_STM32H7_OTGHS) && !defined(CONFIG_S

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
raiden00pl commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155578003 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -866,30 +885,25 @@ void stm32_stdclockconfig(void) { } - /* Over-drive is needed if - *

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-03 Thread via GitHub
raiden00pl commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1155572371 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -866,30 +885,25 @@ void stm32_stdclockconfig(void) { } - /* Over-drive is needed if - *

[GitHub] [nuttx-apps] Junbo-Zheng opened a new pull request, #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-03 Thread via GitHub
Junbo-Zheng opened a new pull request, #1700: URL: https://github.com/apache/nuttx-apps/pull/1700 ## Summary Follow the commit with https://github.com/apache/nuttx/pull/8401 OK/ERROR has already been defined in `sys/types.h` file. Reference: https://github.com/apache/n

[GitHub] [nuttx] terry0012 opened a new pull request, #8949: drivers/video: passthrough unknown ioctl cmd to fb driver

2023-04-03 Thread via GitHub
terry0012 opened a new pull request, #8949: URL: https://github.com/apache/nuttx/pull/8949 ## Summary passthrough the custom ioctl commands to framebuffer driver ## Impact None ## Testing Daily -- This is an automated message from the Apache Git Service. To resp

[nuttx] branch master updated: arch/boards: fix stm32f411-mininum:nsh compilation failure after enabling IRQMONITOR

2023-04-03 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new cafd3af160 arch/boards: fix stm32f411-mininum:n

[GitHub] [nuttx] raiden00pl merged pull request #8948: arch/boards: fix stm32f411-mininum:nsh compilation failure

2023-04-03 Thread via GitHub
raiden00pl merged PR #8948: URL: https://github.com/apache/nuttx/pull/8948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

[GitHub] [nuttx] michallenc commented on issue #8858: Issues with adjtime implementation / Build failure.

2023-04-03 Thread via GitHub
michallenc commented on issue #8858: URL: https://github.com/apache/nuttx/issues/8858#issuecomment-1493788770 > adjtime() does depend on the architecture-specific code providing interfaces to adjust the clock rate, so perhaps it would need to depend on CONFIG_ARCH_HAVE_TIMEKEEPING @p

[nuttx] branch master updated: Assert if a thread attempts to post a semaphore incorrectly.

2023-04-03 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 758e88672b Assert if a thread attempts to post

[GitHub] [nuttx] jerpelea merged pull request #8938: Assert if a thread attempts to post a semaphore incorrectly.

2023-04-03 Thread via GitHub
jerpelea merged PR #8938: URL: https://github.com/apache/nuttx/pull/8938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated (71d7028c4a -> 4ff4562401)

2023-04-03 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 71d7028c4a stm32h7/stm32_sdmmc.c: fix compilation add 4ff4562401 tm4c1294-launchpad: Use bmi160 driver for boost

[GitHub] [nuttx] jerpelea merged pull request #8929: tm4c1294-launchpad: Use bmi160 driver for boostxl-sensors.

2023-04-03 Thread via GitHub
jerpelea merged PR #8929: URL: https://github.com/apache/nuttx/pull/8929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach