[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7770: libc/stdio: add total_len back

xiaoxiang781216 commented on code in PR #7770: URL: https://github.com/apache/nuttx/pull/7770#discussion_r1038923520 ## libs/libc/stdio/lib_libvsprintf.c: ## @@ -67,6 +67,14 @@ # undef CONFIG_LIBC_LONG_LONG #endif +/* [Re]define putc() */ + +#ifdef putc +# undef putc +#end

[GitHub] [nuttx] jihandong opened a new pull request, #7770: libc/stdio: add total_len back

jihandong opened a new pull request, #7770: URL: https://github.com/apache/nuttx/pull/7770 ## Summary "The number of characters written if successful or negative value if an error occurred. If the resulting string gets truncated due to buf_size limit, function returns the total numbe

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #7769: net: Rename arp_arpin to arp_input

xiaoxiang781216 opened a new pull request, #7769: URL: https://github.com/apache/nuttx/pull/7769 ## Summary align with other similar function(e.g. ipv4_input and ipv6_input) ## Impact code refactor only ## Testing Pass CI -- This is an automated message from the

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7768: net/d_buf: remove d_buf reference from l3/l4

xiaoxiang781216 commented on code in PR #7768: URL: https://github.com/apache/nuttx/pull/7768#discussion_r1038919007 ## net/arp/arp.h: ## @@ -81,8 +81,10 @@ /* This is a helper pointer for accessing the contents of the IP header */ -#define ARPBUF((FAR struct arp_hdr_s

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038916855 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7768: net/d_buf: remove d_buf reference from l3/l4

xiaoxiang781216 commented on code in PR #7768: URL: https://github.com/apache/nuttx/pull/7768#discussion_r1038913641 ## net/utils/net_ipchksum.c: ## @@ -170,13 +170,11 @@ uint16_t ipv6_upperlayer_chksum(FAR struct net_driver_s *dev, /* Sum IP payload data. */ -#ifdef CON

[nuttx-website] branch asf-site updated: Publishing web: e978ad4c5b4a50a6bebd3d0505f9893d0411c74e docs: 4859d40a51939cef700b22d86d2b7c6a8b932e8e

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 146a15cc Publishing web: e978ad4c

[nuttx] branch master updated (82d67b201a -> 4859d40a51)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 82d67b201a net/offload: add offload support for pkt/arp add 4859d40a51 arm_syscall: add SYS_save_context for ar

[GitHub] [nuttx] xiaoxiang781216 merged pull request #7767: arm_syscall: add SYS_save_context for armv7-a

xiaoxiang781216 merged PR #7767: URL: https://github.com/apache/nuttx/pull/7767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (0dafa5f921 -> 82d67b201a)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0dafa5f921 Added initial USB support for stm32f746g discovery. add 82d67b201a net/offload: add offload support

[GitHub] [nuttx] xiaoxiang781216 merged pull request #7766: net/offload: add offload support for pkt/arp

xiaoxiang781216 merged PR #7766: URL: https://github.com/apache/nuttx/pull/7766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] anchao opened a new pull request, #7768: net/d_buf: remove d_buf reference from l3/l4

anchao opened a new pull request, #7768: URL: https://github.com/apache/nuttx/pull/7768 ## Summary net/d_buf: remove d_buf reference from l3/l4 l3/l4 stack will decouple the reference of d_buf gradually, Only legacy devices still retain d_buf support, new net devices will use

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7767: arm_syscall: add SYS_save_context for armv7-a

xiaoxiang781216 commented on code in PR #7767: URL: https://github.com/apache/nuttx/pull/7767#discussion_r1038802441 ## arch/arm/src/armv7-a/arm_syscall.c: ## @@ -250,6 +250,25 @@ uint32_t *arm_syscall(uint32_t *regs) } break; #endif + /* R0=SYS_save_cont

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038789173 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038789173 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038801808 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038801808 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038801808 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038801808 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038801808 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] fjpanag commented on a diff in pull request #7525: Improvements in TCP connections allocation.

fjpanag commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038799446 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into the free l

[GitHub] [nuttx] fjpanag commented on a diff in pull request #7525: Improvements in TCP connections allocation.

fjpanag commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038792888 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int i; +#

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038789173 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038789173 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038789173 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038788257 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038788257 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038787283 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] fjpanag commented on a diff in pull request #7525: Improvements in TCP connections allocation.

fjpanag commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038787720 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into the free l

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038787283 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038787283 ## net/tcp/tcp_conn.c: ## @@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn) } #endif - /* Mark the connection available and put it into th

[GitHub] [nuttx] CV-Bowen opened a new pull request, #7767: arm_syscall: add SYS_save_context for armv7-a

CV-Bowen opened a new pull request, #7767: URL: https://github.com/apache/nuttx/pull/7767 ## Summary I noticed that there is not register information in the crash log when DEBUGASSERT failed, the reason is that the arm_dumpstate() call up_saveusercontext() to get the context of current t

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038784224 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038784224 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] fjpanag commented on pull request #7525: Improvements in TCP connections allocation.

fjpanag commented on PR #7525: URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1336172724 I removed the extra Kconfig and all connections are allocated in a single batch. Also I changed init a bit, so it is simpler now, and there is no code duplication. -- This is

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7525: Improvements in TCP connections allocation.

xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038784224 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int

[GitHub] [nuttx] anchao commented on a diff in pull request #7766: net/offload: add offload support for pkt/arp

anchao commented on code in PR #7766: URL: https://github.com/apache/nuttx/pull/7766#discussion_r1038782449 ## net/netdev/netdev_iob.c: ## @@ -125,4 +125,6 @@ void netdev_iob_release(FAR struct net_driver_s *dev) iob_free_chain(dev->d_iob); dev->d_iob = NULL;

[GitHub] [nuttx] TimJTi commented on a diff in pull request #7702: Fix SAMA5D2 ADC and TSD problems

TimJTi commented on code in PR #7702: URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038782007 ## arch/arm/src/sama5/sam_adc.c: ## @@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg) int ret; DEBUGASSERT(priv != NULL); - ainfo("pending=%08x\n",

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7766: net/offload: add offload support for pkt/arp

xiaoxiang781216 commented on code in PR #7766: URL: https://github.com/apache/nuttx/pull/7766#discussion_r1038780546 ## net/netdev/netdev_iob.c: ## @@ -125,4 +125,6 @@ void netdev_iob_release(FAR struct net_driver_s *dev) iob_free_chain(dev->d_iob); dev->d_iob = NU

[GitHub] [nuttx] anchao opened a new pull request, #7766: net/offload: add offload support for pkt/arp

anchao opened a new pull request, #7766: URL: https://github.com/apache/nuttx/pull/7766 ## Summary net/offload: add offload support for pkt/arp 1. add offload support for pkt/arp 2. Reset the d_buf to NULL if d_iob has released Signed-off-by: chao an ## Impact

[GitHub] [nuttx] fjpanag commented on a diff in pull request #7525: Improvements in TCP connections allocation.

fjpanag commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038779571 ## net/tcp/tcp_conn.c: ## @@ -586,16 +586,32 @@ FAR struct tcp_conn_s *tcp_alloc_conn(void) void tcp_initialize(void) { -#ifndef CONFIG_NET_ALLOC_CONNS int i; +#

[GitHub] [nuttx] fjpanag commented on pull request #6631: Added memory health checks.

fjpanag commented on PR #6631: URL: https://github.com/apache/nuttx/pull/6631#issuecomment-1336161897 > @fjpanag do you want to improve this patch? Yes yes, I will. I am struggling to find some free time, first for the TCP connections, and then for this. I will try my be

[GitHub] [nuttx-apps] zouboan commented on a diff in pull request #1407: Fix various error in Windows native build

zouboan commented on code in PR #1407: URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038771434 ## Makefile: ## @@ -21,6 +21,16 @@ export APPDIR = $(CURDIR) include $(APPDIR)/Make.defs +# The GNU make CURDIR will always be a POSIX-like path with forward sla

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1407: Fix various error in Windows native build

xiaoxiang781216 commented on code in PR #1407: URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038770468 ## Makefile: ## @@ -21,6 +21,16 @@ export APPDIR = $(CURDIR) include $(APPDIR)/Make.defs +# The GNU make CURDIR will always be a POSIX-like path with for

[nuttx] branch master updated: Added initial USB support for stm32f746g discovery.

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0dafa5f921 Added initial USB support for stm32

[GitHub] [nuttx] xiaoxiang781216 merged pull request #7763: Dev/stm32f746 usb

xiaoxiang781216 merged PR #7763: URL: https://github.com/apache/nuttx/pull/7763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7702: Fix SAMA5D2 ADC and TSD problems

xiaoxiang781216 commented on code in PR #7702: URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038769231 ## arch/arm/src/sama5/sam_adc.c: ## @@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg) int ret; DEBUGASSERT(priv != NULL); - ainfo("pending

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7702: Fix SAMA5D2 ADC and TSD problems

xiaoxiang781216 commented on code in PR #7702: URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038769231 ## arch/arm/src/sama5/sam_adc.c: ## @@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg) int ret; DEBUGASSERT(priv != NULL); - ainfo("pending

[GitHub] [nuttx] TimJTi commented on a diff in pull request #7702: Fix SAMA5D2 ADC and TSD problems

TimJTi commented on code in PR #7702: URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038765865 ## arch/arm/src/sama5/sam_adc.c: ## @@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg) int ret; DEBUGASSERT(priv != NULL); - ainfo("pending=%08x\n",

[nuttx] branch master updated: tools/define.bat: sync design of define.bat with define.sh to uniform usage

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new aad321dfa8 tools/define.bat: sync design of de

[GitHub] [nuttx] xiaoxiang781216 merged pull request #7765: tools/define.bat: sync design of define.bat with define.sh to uniform usage

xiaoxiang781216 merged PR #7765: URL: https://github.com/apache/nuttx/pull/7765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] okayserh commented on pull request #7763: Dev/stm32f746 usb

okayserh commented on PR #7763: URL: https://github.com/apache/nuttx/pull/7763#issuecomment-1336131813 Struggling with git again, but looks alright to me now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [nuttx] okayserh closed pull request #7763: Dev/stm32f746 usb

okayserh closed pull request #7763: Dev/stm32f746 usb URL: https://github.com/apache/nuttx/pull/7763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [nuttx] zouboan opened a new pull request, #7765: tools/define.bat: sync design of define.bat with define.sh to uniform usage

zouboan opened a new pull request, #7765: URL: https://github.com/apache/nuttx/pull/7765 ## Summary [-val ] [ [-val ] [ [-val ] ...]] ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub