xiaoxiang781216 commented on code in PR #7525:
URL: https://github.com/apache/nuttx/pull/7525#discussion_r1038788257
##########
net/tcp/tcp_conn.c:
##########
@@ -836,10 +863,25 @@ void tcp_free(FAR struct tcp_conn_s *conn)
}
#endif
- /* Mark the connection available and put it into the free list */
+ /* Mark the connection available. */
conn->tcpstateflags = TCP_CLOSED;
- dq_addlast(&conn->sconn.node, &g_free_tcp_connections);
+
+ /* Check if this is a preallocated connection to store it in the free
+ * connections list, else deallocate it.
+ */
+
+#ifdef CONFIG_NET_ALLOC_CONNS
+ if ((conn->flags & TCP_PREALLOC) == 0)
+ {
+ kmm_free(conn);
Review Comment:
If so, you destroy NET_TCP_CONNS meaning:
```
config NET_TCP_CONNS
int "Number of TCP/IP connections"
default 8
---help---
Maximum number of TCP/IP connections (all tasks)
Number of TCP/IP connections (all tasks).
This number of connections will be pre-allocated during system
boot.
If NET_ALLOC_CONNS is enabled, more connections may be
allocated at
a later time, as the system needs them. Else this will be the
maximum number of connections avaiable to the system at all
times.
```
We need keep the code consistent with config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
