[GitHub] [incubator-nuttx] lupyuen commented on pull request #7692: arch/arm64: Add support for PINE64 PinePhone

2022-11-24 Thread GitBox
lupyuen commented on PR #7692: URL: https://github.com/apache/incubator-nuttx/pull/7692#issuecomment-1327103980 @zouboan Yep I also thought I had to change the [Image Load Offset](https://lupyuen.github.io/articles/uboot#nuttx-header) in the Linux Kernel Header `arch/arm64/src/common/arm64_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7693: URL: https://github.com/apache/incubator-nuttx/pull/7693#issuecomment-1327042773 Please fix the style issue here: https://github.com/apache/incubator-nuttx/actions/runs/3544821874/jobs/5953835220 -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7694: libc/stream: Remove \n special handle from syslogstream_putc

2022-11-24 Thread GitBox
xiaoxiang781216 opened a new pull request, #7694: URL: https://github.com/apache/incubator-nuttx/pull/7694 ## Summary since \r\n process is already done in up_putc or serial driver level ## Impact Make the behaviour same with/without iob ## Testing Pass CI -- Thi

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7692: arch/arm64: Add support for PINE64 PinePhone

2022-11-24 Thread GitBox
hartmannathan commented on code in PR #7692: URL: https://github.com/apache/incubator-nuttx/pull/7692#discussion_r1031985497 ## boards/arm64/a64/pinephone/src/pinephone_boardinit.c: ## @@ -0,0 +1,105 @@ +/**

[GitHub] [incubator-nuttx] lupyuen commented on pull request #7692: arch/arm64: Add support for PINE64 PinePhone

2022-11-24 Thread GitBox
lupyuen commented on PR #7692: URL: https://github.com/apache/incubator-nuttx/pull/7692#issuecomment-1326963914 @zouboan Very cool thanks! Remember to get the [PinePhone Serial Debug Cable](https://wiki.pine64.org/index.php/PinePhone#Serial_console) too :-) -- This is an automated message

[GitHub] [incubator-nuttx] zouboan commented on pull request #7692: arch/arm64: Add support for PINE64 PinePhone

2022-11-24 Thread GitBox
zouboan commented on PR #7692: URL: https://github.com/apache/incubator-nuttx/pull/7692#issuecomment-1326961921 after two month of long trip from Germany, my Pinephone arrived last week, your PR is just in time! -- This is an automated message from the Apache Git Service. To respond to th

[incubator-nuttx] branch master updated: tools/nuttx-gdbinit: restore the context at the end of each command

2022-11-24 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1815c2e1e1 tools/nuttx-gdbinit: resto

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7686: tools/nuttx-gdbinit: restore the context at the end of each command

2022-11-24 Thread GitBox
masayuki2009 merged PR #7686: URL: https://github.com/apache/incubator-nuttx/pull/7686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx] branch master updated (5fd1379d3f -> 0e57e69b08)

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 5fd1379d3f syslog: Move syslog stream to libc like other stream implementation add 0e57e69b08 Add li

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] SuGlider opened a new pull request, #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup

2022-11-24 Thread GitBox
SuGlider opened a new pull request, #7693: URL: https://github.com/apache/incubator-nuttx/pull/7693 ## Summary This PR adds a new configuration to Xtensa esp32-wrover-kit board that includes Lua Interpreter, MMCSD SPI support, User Leds and also Buttons. It fixes an issue with conf

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7673: Add virtio-mmio and virtio-net drivers

2022-11-24 Thread GitBox
masayuki2009 commented on PR #7673: URL: https://github.com/apache/incubator-nuttx/pull/7673#issuecomment-1326953244 @xiaoxiang781216 @qinwei2004 I've added multiple mmio devices support to `virtio_init()` in drivers/virtio-mmio.c -- This is an automated message from the Apache Gi

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7673: Add virtio-mmio and virtio-net drivers

2022-11-24 Thread GitBox
masayuki2009 commented on code in PR #7673: URL: https://github.com/apache/incubator-nuttx/pull/7673#discussion_r1031949542 ## boards/arm64/qemu/qemu-armv8a/src/qemu_virtio.c: ## @@ -0,0 +1,41 @@ +/ + *

[GitHub] [incubator-nuttx] lupyuen opened a new pull request, #7692: arch/arm64: Add support for PINE64 PinePhone

2022-11-24 Thread GitBox
lupyuen opened a new pull request, #7692: URL: https://github.com/apache/incubator-nuttx/pull/7692 # Summary This PR adds support for PINE64 PinePhone and the Allwinner A64 SoC (based on Arm Cortex-A53). With this PR, PinePhone boots successfully to nsh (via microSD Card) and

[incubator-nuttx-website] branch asf-site updated: Publishing web: 7e21510459ba6f754fb1da76a14d643b3953b931 docs: 5fd1379d3f9dc13e67d8c5d2734eb0bc0cdc3107

2022-11-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8b45bd14 Publishing web

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7673: Add virtio-mmio and virtio-net drivers

2022-11-24 Thread GitBox
masayuki2009 commented on code in PR #7673: URL: https://github.com/apache/incubator-nuttx/pull/7673#discussion_r1031883979 ## drivers/virtio/Kconfig: ## @@ -0,0 +1,33 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in th

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7691: GD25Q 4 byte read status issue

2022-11-24 Thread GitBox
TimJTi commented on code in PR #7691: URL: https://github.com/apache/incubator-nuttx/pull/7691#discussion_r1031866158 ## drivers/mtd/gd25.c: ## @@ -107,6 +107,7 @@ #define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */ #define GD25_SR_WEL

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7687: video driver enhancements

2022-11-24 Thread GitBox
acassis commented on code in PR #7687: URL: https://github.com/apache/incubator-nuttx/pull/7687#discussion_r1031863937 ## video/Kconfig: ## @@ -13,6 +13,10 @@ config VIDEO if VIDEO +config VIDEO_DEV_PATH + string "video device path" Review Comment: Please use capi

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7691: GD25Q 4 byte read status issue

2022-11-24 Thread GitBox
acassis commented on code in PR #7691: URL: https://github.com/apache/incubator-nuttx/pull/7691#discussion_r1031848011 ## drivers/mtd/gd25.c: ## @@ -107,6 +107,7 @@ #define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */ #define GD25_SR_WEL

[GitHub] [incubator-nuttx] TimJTi opened a new pull request, #7691: GD25Q 4 byte read status issue

2022-11-24 Thread GitBox
TimJTi opened a new pull request, #7691: URL: https://github.com/apache/incubator-nuttx/pull/7691 ## Summary Attempt 3. GG25Q devices have the 4 byte read mode in bit 0 not bit 3 of the status register. This change allows for both types, depending on the JEDEC DEVICE ID that i

[GitHub] [incubator-nuttx] TimJTi closed pull request #7690: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi closed pull request #7690: GD25 mtd issues URL: https://github.com/apache/incubator-nuttx/pull/7690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [incubator-nuttx] TimJTi commented on pull request #7690: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi commented on PR #7690: URL: https://github.com/apache/incubator-nuttx/pull/7690#issuecomment-1326797541 If I was to cherry pick the gd25.c commit to a fresh clone would that be better? I want to find a workflow that works for the repo and for me! -- This is an automated mess

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031776746 ## arch/risc-v/src/esp32c3/esp32c3_start.c: ## @@ -136,6 +177,30 @@ uintptr_t g_idle_topstack = ESP32C3_IDLESTACK_TOP; * Private Functions *

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031771614 ## arch/risc-v/src/esp32c3/esp32c3_start.c: ## @@ -136,6 +177,30 @@ uintptr_t g_idle_topstack = ESP32C3_IDLESTACK_TOP; * Private Functions *

[GitHub] [incubator-nuttx] TimJTi opened a new pull request, #7690: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi opened a new pull request, #7690: URL: https://github.com/apache/incubator-nuttx/pull/7690 ## Summary Try again... Adds changes to sort the different bit positions for 4 byte read mode between GG25Q family devices and other variants. ## Impact None ## Testing

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031765076 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/* + * ar

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031764957 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/* + * ar

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031754583 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031754583 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7674: drivers/syslog:support stream as syslog backend.

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7674: URL: https://github.com/apache/incubator-nuttx/pull/7674#discussion_r1031747446 ## drivers/syslog/Make.defs: ## @@ -77,6 +77,10 @@ ifeq ($(CONFIG_CONSOLE_SYSLOG),y) CSRCS += syslog_console.c endif +ifeq ($(CONFIG_SYSLOG_BACKEN

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
Gary-Hobson commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031753302 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
Gary-Hobson commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031753302 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
Gary-Hobson commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031745787 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[incubator-nuttx] branch master updated (90c641d4c1 -> 5fd1379d3f)

2022-11-24 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 90c641d4c1 libc/streams: Add lib_[si]gets_t callback add 5fd1379d3f syslog: Move syslog stream to libc l

[GitHub] [incubator-nuttx] anchao merged pull request #7672: syslog: Move syslog stream to libc like other stream implementation

2022-11-24 Thread GitBox
anchao merged PR #7672: URL: https://github.com/apache/incubator-nuttx/pull/7672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nut

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031727829 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031726416 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
Gary-Hobson commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031721935 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[incubator-nuttx] branch master updated (869c93638d -> 90c641d4c1)

2022-11-24 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 869c93638d net/icmpv6: Fix `ipv6->len` in icmpv6_reply add 5ee1da4211 libc/streams: Ensure the different

[GitHub] [incubator-nuttx] anchao merged pull request #7681: Minor stream interface improvement

2022-11-24 Thread GitBox
anchao merged PR #7681: URL: https://github.com/apache/incubator-nuttx/pull/7681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nut

[GitHub] [incubator-nuttx] TimJTi closed pull request #7689: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi closed pull request #7689: GD25 mtd issues URL: https://github.com/apache/incubator-nuttx/pull/7689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [incubator-nuttx] TimJTi commented on pull request #7689: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi commented on PR #7689: URL: https://github.com/apache/incubator-nuttx/pull/7689#issuecomment-1326690254 I thought I had squashed, it now won't let me as there is a merge mixed in with it all. I will close this PR, check the PR linked by @xiaoxiang781216 and submit a new PR if appropr

[GitHub] [incubator-nuttx] TimJTi commented on pull request #7689: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi commented on PR #7689: URL: https://github.com/apache/incubator-nuttx/pull/7689#issuecomment-1326682278 Still struggle with Githib, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031709402 ## include/nuttx/streams.h: ## @@ -40,6 +40,16 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7689: GD25 mtd issues

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7689: URL: https://github.com/apache/incubator-nuttx/pull/7689#issuecomment-1326674628 @TimJTi please squash your patches into one: git rebase --interactive HEAD~10 and change all pick to squash except the first one it's very bad to have the intermedi

[GitHub] [incubator-nuttx] TimJTi opened a new pull request, #7689: GD25 mtd issues

2022-11-24 Thread GitBox
TimJTi opened a new pull request, #7689: URL: https://github.com/apache/incubator-nuttx/pull/7689 ## Summary Added a 256Mbit GD25 device to the list of supported devices. Discovered that the 4 byte status is in bit 0 not bit 3 for all the GD25Q devices I checked, so code added to check

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031700382 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/

[GitHub] [incubator-nuttx] TimJTi commented on issue #7670: GigaDevice 4 byte address status register bit - incorrect?

2022-11-24 Thread GitBox
TimJTi commented on issue #7670: URL: https://github.com/apache/incubator-nuttx/issues/7670#issuecomment-1326669302 I have checked a number of GigaDevice datasheets and it seems that only those in the GD25Q family (JEDEC CHIP IDENT 0x40) have the 4 byte read status in Bit 3 and the other t

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7677: lib_libvsprintf: fix the float point print bug

2022-11-24 Thread GitBox
pkarashchenko commented on code in PR #7677: URL: https://github.com/apache/incubator-nuttx/pull/7677#discussion_r1031694312 ## libs/libc/stdio/lib_libvsprintf.c: ## @@ -878,8 +878,32 @@ static int vsprintf_internal(FAR struct lib_outstream_s *stream, ndigs +

[GitHub] [incubator-nuttx] Gary-Hobson opened a new pull request, #7688: include: unified stream read and write interface

2022-11-24 Thread GitBox
Gary-Hobson opened a new pull request, #7688: URL: https://github.com/apache/incubator-nuttx/pull/7688 ## Summary Provide simple macros for unified stream read and write interfaces ## Impact ## Testing -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031691453 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/* + * ar

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031690380 ## arch/risc-v/src/esp32c3/esp32c3_start.c: ## @@ -122,6 +123,46 @@ IRAM_ATTR noreturn_function void __start(void); HDR_ATTR static void (*_entry_point)(void)

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031690187 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/* + * ar

[GitHub] [incubator-nuttx] zouboan commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
zouboan commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326650586 done @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7682: Sim V4L2 bridge and video driver enhancements

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7682: URL: https://github.com/apache/incubator-nuttx/pull/7682#issuecomment-1326645547 Let's reuse this PR after #7687 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326643706 @zouboan it's better to squash the second patch into the first one by: git rebase --interactive HEAD~2 and change pick to squash for the second change. -- This is a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#discussion_r1031669066 ## arch/risc-v/src/esp32c3/rom/esp32c3_libc_stubs.h: ## @@ -0,0 +1,288 @@ +/

[GitHub] [incubator-nuttx] PeterBee97 closed pull request #7682: Sim V4L2 bridge and video driver enhancements

2022-11-24 Thread GitBox
PeterBee97 closed pull request #7682: Sim V4L2 bridge and video driver enhancements URL: https://github.com/apache/incubator-nuttx/pull/7682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-nuttx] PeterBee97 commented on pull request #7682: Sim V4L2 bridge and video driver enhancements

2022-11-24 Thread GitBox
PeterBee97 commented on PR #7682: URL: https://github.com/apache/incubator-nuttx/pull/7682#issuecomment-1326640576 Closing, kernel changes moved to #7687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] PeterBee97 opened a new pull request, #7687: video driver enhancements

2022-11-24 Thread GitBox
PeterBee97 opened a new pull request, #7687: URL: https://github.com/apache/incubator-nuttx/pull/7687 ## Summary 1. New imgdata ops (enq_buf and dqbuf) are added for exchange buffer operation information with lower driver. Will be used in simulator v4l2 bridge drivers. 2. Added missin

[GitHub] [incubator-nuttx] zouboan commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
zouboan commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326635370 Thanks very much for your advice! @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326613766 @zouboan you need run ./tools/refresh.sh --silent to fix ci error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] PeterBee97 commented on a diff in pull request #7682: Sim V4L2 bridge and video driver enhancements

2022-11-24 Thread GitBox
PeterBee97 commented on code in PR #7682: URL: https://github.com/apache/incubator-nuttx/pull/7682#discussion_r1031645595 ## arch/sim/Kconfig: ## @@ -265,6 +265,29 @@ endchoice endif +config SIM_VIDEO Review Comment: OK (well let me pass this CI first..) -- This is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7682: Sim V4L2 bridge and video driver enhancements

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7682: URL: https://github.com/apache/incubator-nuttx/pull/7682#discussion_r1031626777 ## arch/sim/Kconfig: ## @@ -265,6 +265,29 @@ endchoice endif +config SIM_VIDEO Review Comment: @PeterBee97 let's split sim related change to ne

[incubator-nuttx] 02/03: net/icmpv6: Fix `datalen` in icmpv6_reply

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a26ea96f3bca2e9b5a221bdab26820474c22be1f Author: Zhe Weng AuthorDate: Thu Nov 24 16:59:31 2022 +0800 ne

[incubator-nuttx] 03/03: net/icmpv6: Fix `ipv6->len` in icmpv6_reply

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 869c93638d7171806c1a85a7d8f2f0510dc7a328 Author: Zhe Weng AuthorDate: Thu Nov 24 17:17:13 2022 +0800 ne

[incubator-nuttx] branch master updated (6368b29751 -> 869c93638d)

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 6368b29751 test: update usrsocktest script new 233974b327 net/icmpv6: Fix icmpv6 checksum calculation

[incubator-nuttx] 01/03: net/icmpv6: Fix icmpv6 checksum calculation in icmpv6_reply

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 233974b32706c7d25ad289bcbb449d407a47837e Author: Zhe Weng AuthorDate: Thu Nov 24 16:50:11 2022 +0800 ne

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7683: net/icmpv6: Fix icmpv6_reply function

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7683: URL: https://github.com/apache/incubator-nuttx/pull/7683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: test: update usrsocktest script

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6368b29751 test: update usrsocktest

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7684: test: update usrsocktest script

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7684: URL: https://github.com/apache/incubator-nuttx/pull/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] zouboan commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
zouboan commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326575792 Hi Alan, both AT697 and BM3803 based on LEON2, they almost the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[incubator-nuttx] branch master updated (3caa551ff4 -> 4b87a8b079)

2022-11-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 3caa551ff4 net: remove psock reference from connect add 4b87a8b079 lib_libvsprintf: fix the float point

[GitHub] [incubator-nuttx] acassis closed issue #7620: [Bug] Problem with print floating point

2022-11-24 Thread GitBox
acassis closed issue #7620: [Bug] Problem with print floating point URL: https://github.com/apache/incubator-nuttx/issues/7620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [incubator-nuttx] acassis merged pull request #7677: lib_libvsprintf: fix the float point print bug

2022-11-24 Thread GitBox
acassis merged PR #7677: URL: https://github.com/apache/incubator-nuttx/pull/7677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function

2022-11-24 Thread GitBox
xiaoxiang781216 commented on PR #7683: URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326559926 So, let's merge this patch as it, @anchao ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[incubator-nuttx] branch master updated (6d8c28a83c -> 3caa551ff4)

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 6d8c28a83c boards/citest: disable NET_ARP for usrsocktest add f2a7711ef8 net/soerr: add new _SO_CONN_

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7675: net: remove psock reference from connect

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7675: URL: https://github.com/apache/incubator-nuttx/pull/7675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7686: tools/nuttx-gdbinit: restore the context at the end of each command

2022-11-24 Thread GitBox
anchao opened a new pull request, #7686: URL: https://github.com/apache/incubator-nuttx/pull/7686 ## Summary tools/nuttx-gdbinit: restore the context at the end of each command after executing commands such as nxthread_*, you can enter c to continue the program directly

[GitHub] [incubator-nuttx] acassis commented on pull request #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
acassis commented on PR #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685#issuecomment-1326553571 Hi @zouboan I visited INPE last week, they have some projects using Sparc, but it is based on LEON2: https://flickr.com/photos/79703543@N00/52511348812/ -- This is an automated

[GitHub] [incubator-nuttx] zouboan opened a new pull request, #7685: boards/sparc: add initial support of s698pm-dkit board

2022-11-24 Thread GitBox
zouboan opened a new pull request, #7685: URL: https://github.com/apache/incubator-nuttx/pull/7685 ## Summary add initial support of s698pm-dkit board to put arch/sparc/s698pm into ci protect s698pm-dkit is a s698pm development board it has: 1. on board 8MB SRAM; 2. on board 16MB

[GitHub] [incubator-nuttx] wengzhe commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function

2022-11-24 Thread GitBox
wengzhe commented on PR #7683: URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326521461 > How about merge the commits into one? seems they are not independent and related to each other Actually, there are three problems there when I try to capture the packet by

[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #7677: lib_libvsprintf: fix the float point print bug

2022-11-24 Thread GitBox
CV-Bowen commented on code in PR #7677: URL: https://github.com/apache/incubator-nuttx/pull/7677#discussion_r1031566144 ## libs/libc/stdio/lib_libvsprintf.c: ## @@ -878,8 +878,32 @@ static int vsprintf_internal(FAR struct lib_outstream_s *stream, ndigs += 1;

[GitHub] [incubator-nuttx] no1wudi commented on pull request #7677: lib_libvsprintf: fix the float point print bug

2022-11-24 Thread GitBox
no1wudi commented on PR #7677: URL: https://github.com/apache/incubator-nuttx/pull/7677#issuecomment-1326514767 Verified on my local machine that this patch can fix #7620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] anchao commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function

2022-11-24 Thread GitBox
anchao commented on PR #7683: URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326489082 How about merge the commits into one? seems they are not independent and related to each other -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx] acassis commented on pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
acassis commented on PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#issuecomment-1326467783 > > MacOS is failing again... > > Yes, but it is failing for valid reasons. The Linux RISC-V is also failing: https://github.com/apache/incubator-nuttx/actions/runs/3536010

[GitHub] [incubator-nuttx] ttnie opened a new pull request, #7684: test: update usrsocktest script

2022-11-24 Thread GitBox
ttnie opened a new pull request, #7684: URL: https://github.com/apache/incubator-nuttx/pull/7684 Signed-off-by: nietingting ## Summary update usrsocktest expect value to "FAILED:0" ## Impact ci ## Testing test on local -- This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7678: drivers/segger: Add Segger RTT stream support

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7678: URL: https://github.com/apache/incubator-nuttx/pull/7678#discussion_r1031494823 ## include/nuttx/segger/rtt.h: ## @@ -0,0 +1,79 @@ +/ + * include/nuttx/segg

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7678: drivers/segger: Add Segger RTT stream support

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7678: URL: https://github.com/apache/incubator-nuttx/pull/7678#discussion_r1031493117 ## drivers/segger/Make.defs: ## @@ -23,6 +23,7 @@ SGDIR = segger ifeq ($(CONFIG_SEGGER_RTT),y) CSRCS += segger/RTT/RTT/SEGGER_RTT.c + CSRCS

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7678: drivers/segger: Add Segger RTT stream support

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7678: URL: https://github.com/apache/incubator-nuttx/pull/7678#discussion_r1031492204 ## include/nuttx/segger/rtt.h: ## @@ -0,0 +1,88 @@ +/ + * include/nuttx/segg

[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #7673: Add virtio-mmio and virtio-net drivers

2022-11-24 Thread GitBox
qinwei2004 commented on code in PR #7673: URL: https://github.com/apache/incubator-nuttx/pull/7673#discussion_r1031488979 ## drivers/virtio/Kconfig: ## @@ -0,0 +1,33 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the

[incubator-nuttx] branch master updated: boards/citest: disable NET_ARP for usrsocktest

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6d8c28a83c boards/citest: disable NE

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7676: boards/citest: disable NET_ARP for usrsocktest

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7676: URL: https://github.com/apache/incubator-nuttx/pull/7676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #7661: Add libc_stubs functions

2022-11-24 Thread GitBox
gustavonihei commented on PR #7661: URL: https://github.com/apache/incubator-nuttx/pull/7661#issuecomment-1326354612 > MacOS is failing again... Yes, but it is failing for valid reasons. The Linux RISC-V is also failing: https://github.com/apache/incubator-nuttx/actions/runs/353601

[incubator-nuttx] branch master updated: net/local: support FIONWRITE for domain socket ioctl

2022-11-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c37d90c194 net/local: support FIONWR

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7679: net/local: support FIONWRITE for domain socket ioctl

2022-11-24 Thread GitBox
xiaoxiang781216 merged PR #7679: URL: https://github.com/apache/incubator-nuttx/pull/7679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7675: net: remove psock reference from connect

2022-11-24 Thread GitBox
anchao commented on code in PR #7675: URL: https://github.com/apache/incubator-nuttx/pull/7675#discussion_r1031418976 ## net/rpmsg/rpmsg_sockif.c: ## @@ -287,11 +286,9 @@ static int rpmsg_socket_ept_cb(FAR struct rpmsg_endpoint *ept, nxmutex_lock(&conn->recvlock);

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7675: net: remove psock reference from connect

2022-11-24 Thread GitBox
anchao commented on code in PR #7675: URL: https://github.com/apache/incubator-nuttx/pull/7675#discussion_r1031418784 ## net/socket/socket.h: ## @@ -94,18 +94,30 @@ /* Macro to set socket errors */ #ifdef CONFIG_NET_SOCKOPTS +# define _SO_CONN_SETERRNO(c,e) \ +do \ +

[GitHub] [incubator-nuttx] wengzhe opened a new pull request, #7683: Fix icmpv6_reply function

2022-11-24 Thread GitBox
wengzhe opened a new pull request, #7683: URL: https://github.com/apache/incubator-nuttx/pull/7683 ## Summary patches included: - net/icmpv6: Fix `ipv6->len` in icmpv6_reply - The `ipv6->len` is the length excluding the IPv6 header, so need to be `dev->d_len - IPv6_HDRLEN`. - n

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7675: net: remove psock reference from connect

2022-11-24 Thread GitBox
xiaoxiang781216 commented on code in PR #7675: URL: https://github.com/apache/incubator-nuttx/pull/7675#discussion_r1031403475 ## net/tcp/tcp_monitor.c: ## @@ -165,10 +165,7 @@ static uint16_t tcp_monitor_event(FAR struct net_driver_s *dev, /* Clear the socket erro

  1   2   >