TimJTi commented on code in PR #7691: URL: https://github.com/apache/incubator-nuttx/pull/7691#discussion_r1031866158
########## drivers/mtd/gd25.c: ########## @@ -107,6 +107,7 @@ #define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */ #define GD25_SR_WEL (1 << 1) /* Bit 1: Write Enable Latch */ #define GD25_SR1_EN4B (1 << 3) /* Bit 3: Enable 4byte address */ +#define GD25Q_SR1_EN4B (1 << 0) /* Bit 0: Enable 4byte address GD25Q memories */ Review Comment: This isn't about the WIP bit, it's the 4 byte read bit, which is only relevant to memories with >128mbit. It's in the second status register, which has different names dependent on the device, and either bit 0 or 3. The driver will only attempt to read or write this if the size is >128Mbit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
