masayuki2009 commented on PR #7262:
URL: https://github.com/apache/incubator-nuttx/pull/7262#issuecomment-1272466374
@HidenoriMatsubayashi
I agree with your fix for the DRAM region settings because it's configurable
by QEMU.
However, I'm not sure if the DEVICE region is configurable o
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new cb73e9a67d arch: qemu-rv: Refactor t
xiaoxiang781216 merged PR #7259:
URL: https://github.com/apache/incubator-nuttx/pull/7259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on PR #7261:
URL: https://github.com/apache/incubator-nuttx/pull/7261#issuecomment-1272464537
Please fix new style warning, thanks:
```
Error:
/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm64/src/common/arm64_cpu_psci.c:1:77:
error: Block co
HidenoriMatsubayashi commented on PR #7262:
URL: https://github.com/apache/incubator-nuttx/pull/7262#issuecomment-1272459784
@masayuki2009 @xiaoxiang781216
May I have review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
HidenoriMatsubayashi opened a new pull request, #7262:
URL: https://github.com/apache/incubator-nuttx/pull/7262
## Summary
The default size in QEMU system is 128MB, and the size specified in chip.h
is also 128MB. However, the region size for MMU was 512MB, so fixed it.
## Impact
HidenoriMatsubayashi commented on PR #7261:
URL: https://github.com/apache/incubator-nuttx/pull/7261#issuecomment-1272455927
@masayuki2009 @xiaoxiang781216
May I have review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
HidenoriMatsubayashi opened a new pull request, #7261:
URL: https://github.com/apache/incubator-nuttx/pull/7261
## Summary
This change moves the static vars to the appropriate place to follow the
coding standard. It also adds comments as sections and `static` where necessary.
## Im
anchao opened a new pull request, #7260:
URL: https://github.com/apache/incubator-nuttx/pull/7260
## Summary
arm/backtrace: add support for EHABI(Exception Handling ABI) stack unwinder
Reference:
https://github.com/ARM-software/abi-aa/blob/main/ehabi32/ehabi32.rst
https://gi
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1297c23e7d arch/arm64/arm64_mmu: add
masayuki2009 merged PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
masayuki2009 commented on PR #6998:
URL: https://github.com/apache/incubator-nuttx/pull/6998#issuecomment-1272444006
I think this PR should have been separated into several commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
masayuki2009 commented on PR #6998:
URL: https://github.com/apache/incubator-nuttx/pull/6998#issuecomment-1272443471
The following issue has been reported.
https://github.com/apache/incubator-nuttx/issues/7233
--
This is an automated message from the Apache Git Service.
To respond t
masayuki2009 opened a new pull request, #7259:
URL: https://github.com/apache/incubator-nuttx/pull/7259
## Summary
- This commit refactors the entry point name for BUILD_KERNEL to avoid
misunderstanding the name
## Impact
- None
## Testing
- Tested with rv-
masayuki2009 commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272437809
@HidenoriMatsubayashi
I will merge this PR after the CI completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990721134
##
drivers/input/mxt.c:
##
@@ -1532,10 +1523,10 @@ static int mxt_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
static int mxt_poll(FAR str
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990721119
##
drivers/input/ft5x06.c:
##
@@ -986,10 +977,10 @@ static int ft5x06_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
static int ft5x06_poll(
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990721068
##
fs/fat/fs_fat32util.c:
##
@@ -1127,7 +1109,7 @@ int fat_putcluster(struct fat_mountpt_s *fs, uint32_t
clusterno,
int fat_removechain(struct fat_moun
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990720854
##
fs/rpmsgfs/rpmsgfs.c:
##
@@ -1059,7 +1042,7 @@ static int rpmsgfs_rewinddir(FAR struct inode *mountpt,
static int rpmsgfs_bind(FAR struct inode *blkd
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990720773
##
include/nuttx/wireless/ieee80211/bcmf_gspi.h:
##
@@ -60,32 +61,32 @@ typedef struct gspi_dev_s
* following fields before calling gspi_register.
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990720678
##
sched/clock/clock_getres.c:
##
@@ -45,7 +45,7 @@
int clock_getres(clockid_t clock_id, struct timespec *res)
Review Comment:
Done.
--
This i
HidenoriMatsubayashi commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272432899
Done. Can you please approve / review / merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
masayuki2009 commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272432063
@HidenoriMatsubayashi
In your case, you can not use `git commit --amend` which just amends the
last commit.
Instead, you can use `git rebase -i HEAD~3` and drop the 3rd
HidenoriMatsubayashi commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272431812
Thanks. IC. will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
masayuki2009 commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272430308
@HidenoriMatsubayashi
If there are only 2 commits and modify the second one, you can use `git
commit --amend`.
However, if there are 3 commits and modify the second com
xiaotailang commented on issue #7215:
URL:
https://github.com/apache/incubator-nuttx/issues/7215#issuecomment-1272430158
> Hi @xiaotailang you are correct! Using EEPROM with MTD is slow if your
EEPROM is I2C. The mount issue you are facing is because the auto-mount command
expects that the
HidenoriMatsubayashi commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272426226
@masayuki2009
> Please fix up the second commit. We don't need the commit message.
What do you mean? Should I use "git commit --amend"?
> By the w
masayuki2009 commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272423610
@HidenoriMatsubayashi
By the way, did you sign the ICLA?
https://www.apache.org/licenses/contributor-agreements.html
https://www.apache.org/licenses/icla.pdf
--
Th
masayuki2009 commented on PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#issuecomment-1272422678
@HidenoriMatsubayashi
Please fix up the second commit. We don't need the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the m
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new e8e6da6 Publishing web
HidenoriMatsubayashi commented on code in PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#discussion_r990706155
##
AUTHORS:
##
@@ -78,6 +78,7 @@ Vasilijev Alexand Anatoljevich (Alexander Vasiliev)
Wolfgang Gerd Reißnegger (Wolfgang Reißnegger)
Xiang Xiao
Yu
pkarashchenko commented on code in PR #1341:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r990695403
##
examples/lvgldemo/lvgldemo.c:
##
@@ -62,46 +57,99 @@
# define NEED_BOARDINIT 1
#endif
-#define DISPLAY_BUFFER_SIZE (CONFIG_LV_HOR_RES * \
-
pkarashchenko commented on code in PR #1340:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r990694889
##
examples/ustream/ustream_client.c:
##
@@ -90,7 +90,7 @@ int main(int argc, FAR char *argv[])
printf("client: Connecting to %s...\n", CONFIG_E
pkarashchenko commented on code in PR #7258:
URL: https://github.com/apache/incubator-nuttx/pull/7258#discussion_r990694486
##
arch/arm/src/stm32h7/stm32_flash.c:
##
@@ -330,15 +331,24 @@ static inline uint32_t stm32h7_flash_size(
static inline
struct stm32h7_flash_priv_s * st
pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r990691527
##
drivers/audio/vs1053.c:
##
@@ -1647,22 +1647,22 @@ static int vs1053_resume(FAR struct audio_lowerhalf_s
*lower)
static int vs1053_enqueuebuffer(FAR s
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 5d8cbfb279 rpmsgdev: add rpmsgdev po
xiaoxiang781216 merged PR #7255:
URL: https://github.com/apache/incubator-nuttx/pull/7255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
tito97sp opened a new pull request, #7258:
URL: https://github.com/apache/incubator-nuttx/pull/7258
Signed-off-by: Andrés Sánchez Pascual
## Summary
stm32_flash.c not supports currently the dual bank flash memory layout. This
commit contemplates this possible layout.
Also a
tito97sp closed pull request #7257: arch: stm32h7: Add support for dual bank
flash memory
URL: https://github.com/apache/incubator-nuttx/pull/7257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xiaoxiang781216 commented on code in PR #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256#discussion_r990655198
##
AUTHORS:
##
@@ -78,6 +78,7 @@ Vasilijev Alexand Anatoljevich (Alexander Vasiliev)
Wolfgang Gerd Reißnegger (Wolfgang Reißnegger)
Xiang Xiao
Yuuichi
tito97sp opened a new pull request, #7257:
URL: https://github.com/apache/incubator-nuttx/pull/7257
Signed-off-by: Andrés Sánchez Pascual
## Summary
stm32_flash.c not supports currently the dual bank flash memory layout. This
commit contemplates this possible layout.
## Imp
xiaoxiang781216 commented on code in PR #7248:
URL: https://github.com/apache/incubator-nuttx/pull/7248#discussion_r990650917
##
drivers/modem/alt1250/alt1250.c:
##
@@ -0,0 +1,1279 @@
+/
+ * drivers/mode
xiaoxiang781216 commented on code in PR #7248:
URL: https://github.com/apache/incubator-nuttx/pull/7248#discussion_r990650917
##
drivers/modem/alt1250/alt1250.c:
##
@@ -0,0 +1,1279 @@
+/
+ * drivers/mode
xiaoxiang781216 commented on code in PR #7248:
URL: https://github.com/apache/incubator-nuttx/pull/7248#discussion_r990650917
##
drivers/modem/alt1250/alt1250.c:
##
@@ -0,0 +1,1279 @@
+/
+ * drivers/mode
HidenoriMatsubayashi opened a new pull request, #7256:
URL: https://github.com/apache/incubator-nuttx/pull/7256
## Summary
This change is a refactoring to match the implementation of mmu_regions
which is user provided platform regions.
## Impact
None
## Testing
None
CV-Bowen opened a new pull request, #7255:
URL: https://github.com/apache/incubator-nuttx/pull/7255
## Summary
Support rpmsgdev-poll operation.
# Impact
New feature
## Testing
sim:rpserver and sim:rpproxy test
--
This is an automated message from the Apache Git S
acassis commented on issue #7215:
URL:
https://github.com/apache/incubator-nuttx/issues/7215#issuecomment-1272313153
Hi @xiaotailang you are correct! Using EEPROM with MTD is slow if your
EEPROM is I2C. The mount issue you are facing is because the auto-mount command
expects that the MTD d
xiaoxiang781216 commented on code in PR #1341:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r990637458
##
graphics/lvgl/Make.defs:
##
@@ -30,7 +30,4 @@ CXXFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)"
$(APPDIR)/graphics/lvgl}
CFLAGS += ${shell
xiaoxiang781216 commented on code in PR #1341:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r990636957
##
graphics/lvgl/lv_porting/lv_touchpad_interface.h:
##
@@ -0,0 +1,80 @@
+/
FASTSHIFT opened a new pull request, #1341:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1341
## Summary
Related discussion:
https://github.com/apache/incubator-nuttx-apps/issues/1322
## Impact
Apps based on LVGL v7 will not work.
## Testing
Dai
xiaoxiang781216 commented on PR #1340:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1272275353
Please ignore the style warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
xiaoxiang781216 opened a new pull request, #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340
## Summary
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4b6c9915fe arch: qemu-rv: Fix timer
xiaoxiang781216 merged PR #7254:
URL: https://github.com/apache/incubator-nuttx/pull/7254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990608526
##
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig"
masayuki2009 opened a new pull request, #7254:
URL: https://github.com/apache/incubator-nuttx/pull/7254
## Summary
- I noticed that the OS timer sometimes proceeds fast when a task is
scheduled to run on CPUO via IPI.
- Actually, qemu-rv implementation shares supervisor software in
56 matches
Mail list logo
