[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6653: Driver/sensor: enhance sensor driver to support uorb and multi core access sensor by rpmsg

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6653: URL: https://github.com/apache/incubator-nuttx/pull/6653#discussion_r934151907 ## drivers/sensors/sensor.c: ## @@ -609,35 +733,45 @@ static int sensor_ioctl(FAR struct file *filep, int cmd, unsigned long arg) FAR struct sensor_upp

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
masayuki2009 commented on PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#issuecomment-1200729939 @takayoshi-k >I did the stress test (nxplayer + telnet) with the first commit only. (i.e. did not apply the apps's PR) >However, it seems unstable (i.e. deadlock).

[GitHub] [incubator-nuttx] mkeydevelop commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack

2022-07-31 Thread GitBox
mkeydevelop commented on code in PR #6746: URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934140001 ## sched/sched/sched_timerexpiration.c: ## @@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks, /* Returning zero means

[GitHub] [incubator-nuttx] mkeydevelop commented on a diff in pull request #6660: sched/sched/sched_timerexpiration: idle task no need RR time slice

2022-07-31 Thread GitBox
mkeydevelop commented on code in PR #6660: URL: https://github.com/apache/incubator-nuttx/pull/6660#discussion_r934138490 ## sched/sched/sched_timerexpiration.c: ## @@ -238,7 +238,18 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks, { /* Apply the ke

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
masayuki2009 commented on PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#issuecomment-1200695097 >@takayoshi-k >I noticed that the stress test with spresense:wifi_smp is unstable. >Let me check what is happening with this PR. @takayoshi-k I did the stress

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6748: power/axp202: Replace battery_charger_operations_s * with battery_charger_dev_s

2022-07-31 Thread GitBox
xiaoxiang781216 opened a new pull request, #6748: URL: https://github.com/apache/incubator-nuttx/pull/6748 ## Summary Found in https://github.com/apache/incubator-nuttx/pull/6743 ## Impact Make axp202 work with the new battery framework ## Testing -- This is an

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r934120488 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_cha

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r934120488 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_cha

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r934120488 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_cha

[GitHub] [incubator-nuttx] takayoshi-k commented on a diff in pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
takayoshi-k commented on code in PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#discussion_r934113736 ## drivers/wireless/gs2200m.c: ## @@ -2152,6 +2152,35 @@ static enum pkt_type_e gs2200m_activate_wrx(FAR struct gs2200m_dev_s *dev, return gs2200m_send_c

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#discussion_r934106868 ## drivers/wireless/gs2200m.c: ## @@ -2152,6 +2152,35 @@ static enum pkt_type_e gs2200m_activate_wrx(FAR struct gs2200m_dev_s *dev, return gs2200m_se

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6653: Driver/sensor: enhance sensor driver to support uorb and multi core access sensor by rpmsg

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6653: URL: https://github.com/apache/incubator-nuttx/pull/6653#discussion_r934106472 ## drivers/sensors/sensor.c: ## @@ -609,35 +733,45 @@ static int sensor_ioctl(FAR struct file *filep, int cmd, unsigned long arg) FAR struct sensor_u

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6725: include: Fixed null struct may caused build issue.

2022-07-31 Thread GitBox
xiaoxiang781216 commented on PR #6725: URL: https://github.com/apache/incubator-nuttx/pull/6725#issuecomment-1200631360 ND protocol need mac address to do the translation between IPv6 address and MAC address, I guess some dependence miss here. -- This is an automated message from the Apac

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6725: include: Fixed null struct may caused build issue.

2022-07-31 Thread GitBox
masayuki2009 commented on PR #6725: URL: https://github.com/apache/incubator-nuttx/pull/6725#issuecomment-1200624886 ``` Configuration/Tool: sim/tcploop

[GitHub] [incubator-nuttx] easonxiang commented on a diff in pull request #6723: sched: Fill the gap in the structures.

2022-07-31 Thread GitBox
easonxiang commented on code in PR #6723: URL: https://github.com/apache/incubator-nuttx/pull/6723#discussion_r934096999 ## sched/mqueue/mqueue.h: ## @@ -65,11 +65,7 @@ struct mqueue_msg_s struct list_node node; /* Link node to message */ uint8_t type;/* (Use

[GitHub] [incubator-nuttx] easonxiang closed pull request #6723: sched: Fill the gap in the structures.

2022-07-31 Thread GitBox
easonxiang closed pull request #6723: sched: Fill the gap in the structures. URL: https://github.com/apache/incubator-nuttx/pull/6723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
masayuki2009 commented on PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#issuecomment-1200571729 @takayoshi-k I noticed that the stress test with spresense:wifi_smp is unstable. Let me check what is happening with this PR. -- This is an automated message from

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: c26bb358432d8137a733ddab702e78046faedabf

2022-07-31 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1256a56 Publishing web

[GitHub] [incubator-nuttx] takayoshi-k commented on a diff in pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
takayoshi-k commented on code in PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#discussion_r934060231 ## drivers/wireless/gs2200m.c: ## @@ -2108,6 +2152,35 @@ static enum pkt_type_e gs2200m_activate_wrx(FAR struct gs2200m_dev_s *dev, return gs2200m_send_c

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
masayuki2009 commented on code in PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#discussion_r934053343 ## drivers/wireless/gs2200m.c: ## @@ -2108,6 +2152,35 @@ static enum pkt_type_e gs2200m_activate_wrx(FAR struct gs2200m_dev_s *dev, return gs2200m_send_

[GitHub] [incubator-nuttx-apps] takayoshi-k opened a new pull request, #1244: wireless/gs2200m: Release all blocking socket

2022-07-31 Thread GitBox
takayoshi-k opened a new pull request, #1244: URL: https://github.com/apache/incubator-nuttx-apps/pull/1244 ## Summary When dis-associtaion happens, the socket is destroyed. And all blocking sockets are released for that error handling can be performed. ## Impact Only gs2200m

[GitHub] [incubator-nuttx] takayoshi-k opened a new pull request, #6747: Fix notify disassocitaion

2022-07-31 Thread GitBox
takayoshi-k opened a new pull request, #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747 ## Summary After recover disassociation, usrsock daemon must destroy all sockets. Add notification to prompt the daemon to do so. ## Impact Only for gs2200m driver #

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6653: Driver/sensor: enhance sensor driver to support uorb and multi core access sensor by rpmsg

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6653: URL: https://github.com/apache/incubator-nuttx/pull/6653#discussion_r934039404 ## drivers/sensors/sensor.c: ## @@ -609,35 +733,45 @@ static int sensor_ioctl(FAR struct file *filep, int cmd, unsigned long arg) FAR struct sensor_upp

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6723: sched: Fill the gap in the structures.

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6723: URL: https://github.com/apache/incubator-nuttx/pull/6723#discussion_r934038522 ## sched/mqueue/mqueue.h: ## @@ -65,11 +65,7 @@ struct mqueue_msg_s struct list_node node; /* Link node to message */ uint8_t type;/* (

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r934037164 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_charg

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6746: URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934037676 ## sched/sched/sched_timerexpiration.c: ## @@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks, /* Returning zero mean

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6746: URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934037676 ## sched/sched/sched_timerexpiration.c: ## @@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks, /* Returning zero mean

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r934037164 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_charg

[incubator-nuttx] branch master updated: Remove the private NULL, TRUE and FALSE macros

2022-07-31 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c26bb35843 Remove the private NU

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6745: Remove the private NULL, TRUE and FALSE macros

2022-07-31 Thread GitBox
pkarashchenko merged PR #6745: URL: https://github.com/apache/incubator-nuttx/pull/6745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6657: drivers/lcd/st7789: update putarea() method

2022-07-31 Thread GitBox
xiaoxiang781216 commented on PR #6657: URL: https://github.com/apache/incubator-nuttx/pull/6657#issuecomment-1200436286 Yes, we need some thing like pitch or a new callback to indicate the different usage. @Cynerd @lupyuen could you provide the patch for this? -- This is an automated mess

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6631: Added memory health checks.

2022-07-31 Thread GitBox
xiaoxiang781216 commented on PR #6631: URL: https://github.com/apache/incubator-nuttx/pull/6631#issuecomment-1200434101 @fjpanag @ALTracer https://github.com/apache/incubator-nuttx/pull/6724 provide the method to enable the heap check from nsh. So, you can do: 1. Check the heap

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #6742: build(deps): bump mistune from 0.8.4 to 2.0.3 in /Documentation

2022-07-31 Thread GitBox
xiaoxiang781216 closed pull request #6742: build(deps): bump mistune from 0.8.4 to 2.0.3 in /Documentation URL: https://github.com/apache/incubator-nuttx/pull/6742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] dependabot[bot] commented on pull request #6742: build(deps): bump mistune from 0.8.4 to 2.0.3 in /Documentation

2022-07-31 Thread GitBox
dependabot[bot] commented on PR #6742: URL: https://github.com/apache/incubator-nuttx/pull/6742#issuecomment-1200432710 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor vers

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6660: sched/sched/sched_timerexpiration: idle task no need RR time slice

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6660: URL: https://github.com/apache/incubator-nuttx/pull/6660#discussion_r933992535 ## sched/sched/sched_timerexpiration.c: ## @@ -238,7 +238,18 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks, { /* Apply th

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6746: sched: Remove KEEP_ALIVE_HACK hack

2022-07-31 Thread GitBox
xiaoxiang781216 opened a new pull request, #6746: URL: https://github.com/apache/incubator-nuttx/pull/6746 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6745: Remove the private NULL, TRUE and FALSE macros

2022-07-31 Thread GitBox
xiaoxiang781216 commented on PR #6745: URL: https://github.com/apache/incubator-nuttx/pull/6745#issuecomment-1200431808 Please ignore the "Mix case" warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6745: Remove the private NULL, TRUE and FALSE macros

2022-07-31 Thread GitBox
xiaoxiang781216 opened a new pull request, #6745: URL: https://github.com/apache/incubator-nuttx/pull/6745 ## Summary ## Impact Code refactor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6724: add heapcheck(memcheck) flag

2022-07-31 Thread GitBox
xiaoxiang781216 commented on PR #6724: URL: https://github.com/apache/incubator-nuttx/pull/6724#issuecomment-1200423864 @davids5 please review the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r933981483 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_cha

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
xiaoxiang781216 commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r933981483 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_cha

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6725: include: Fixed null struct may caused build issue.

2022-07-31 Thread GitBox
hartmannathan commented on code in PR #6725: URL: https://github.com/apache/incubator-nuttx/pull/6725#discussion_r933974303 ## include/nuttx/net/netdev.h: ## @@ -272,6 +272,7 @@ struct net_driver_s struct netdev_varaddr_s radio; #endif +uint8_t unused;/* it's emp

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r933965859 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_charg

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r933965859 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_charg

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6743: drivers/battery: Handle the early changed event correctly

2022-07-31 Thread GitBox
pkarashchenko commented on code in PR #6743: URL: https://github.com/apache/incubator-nuttx/pull/6743#discussion_r933965859 ## drivers/power/battery_charger.c: ## @@ -467,6 +467,16 @@ int battery_charger_changed(FAR struct battery_charger_dev_s *dev, FAR struct battery_charg

[incubator-nuttx-apps] branch master updated: apps/games: Add shift game

2022-07-31 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8a177cd79 apps/games: Add s

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1238: apps/games: Add shift game

2022-07-31 Thread GitBox
pkarashchenko merged PR #1238: URL: https://github.com/apache/incubator-nuttx-apps/pull/1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx] lupyuen commented on pull request #6657: drivers/lcd/st7789: update putarea() method

2022-07-31 Thread GitBox
lupyuen commented on PR #6657: URL: https://github.com/apache/incubator-nuttx/pull/6657#issuecomment-1200378739 Yep this is a tough decision. In case anybody is curious how ST7789 is implemented in Zephyr: https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/display_st7789

[GitHub] [incubator-nuttx] Cynerd commented on pull request #6657: drivers/lcd/st7789: update putarea() method

2022-07-31 Thread GitBox
Cynerd commented on PR #6657: URL: https://github.com/apache/incubator-nuttx/pull/6657#issuecomment-1200366852 > The current implementation of putarea might have a performance concern. The same can be said with the previous implementation and frame buffer usage. There are just two app