masayuki2009 commented on PR #6747: URL: https://github.com/apache/incubator-nuttx/pull/6747#issuecomment-1200729939
@takayoshi-k >I did the stress test (nxplayer + telnet) with the first commit only. (i.e. did not apply the apps's PR) >However, it seems unstable (i.e. deadlock). Regarding the first commit, I think it's a little complicated. I think we don't need `_notif_q_push_wo_enable()`. Also, I think we don't need `_enable_cid32()` but just modify `_enable_cid()` to support `uint32_t *cid_bits`. In this case, we need to modify `uint16_t valid_cid_bits`, `uint16_t aip_cid_bits` as well. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org