[GitHub] [incubator-nuttx] a-lunev commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
a-lunev commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173419073 > @a-lunev Thanks for your confirm! I did some tests according to your mentioned and found that in buffer mode if multiple segments are discarded at the same time, it cannot be re

[GitHub] [incubator-nuttx] anchao commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
anchao commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173285672 > For the buffered mode I enabled using rexmit_seq only in PR #5589 (it is not yet merged into the upstream). So far I have not yet analyzed the further history of changes in t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1214: system/hostname: Add an option to read the hostname from a file

2022-07-03 Thread GitBox
xiaoxiang781216 commented on code in PR #1214: URL: https://github.com/apache/incubator-nuttx-apps/pull/1214#discussion_r912592476 ## system/hostname/hostname_main.c: ## @@ -42,17 +42,64 @@ int main(int argc, FAR char *argv[]) { int ret; + FILE *f; + int maxarg = 2; c

[incubator-nuttx-apps] branch master updated: Added simple ws2812 example

2022-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ca4ef6966 Added simple ws2812 e

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1211: Added Neopixel Example

2022-07-03 Thread GitBox
xiaoxiang781216 merged PR #1211: URL: https://github.com/apache/incubator-nuttx-apps/pull/1211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: c7c5c754511c2ce50ab3cd83e104c0ec94477896

2022-07-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1f09cea Publishing web

[GitHub] [incubator-nuttx-website] dependabot[bot] commented on pull request #70: Bump activesupport from 6.0.2.1 to 6.0.5

2022-07-03 Thread GitBox
dependabot[bot] commented on PR #70: URL: https://github.com/apache/incubator-nuttx-website/pull/70#issuecomment-1173275730 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [incubator-nuttx-website] xiaoxiang781216 closed pull request #70: Bump activesupport from 6.0.2.1 to 6.0.5

2022-07-03 Thread GitBox
xiaoxiang781216 closed pull request #70: Bump activesupport from 6.0.2.1 to 6.0.5 URL: https://github.com/apache/incubator-nuttx-website/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[incubator-nuttx-website] branch master updated: Bump addressable from 2.7.0 to 2.8.0

2022-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new 6758fc5 Bump addressable fr

[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #69: Bump addressable from 2.7.0 to 2.8.0

2022-07-03 Thread GitBox
xiaoxiang781216 merged PR #69: URL: https://github.com/apache/incubator-nuttx-website/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[incubator-nuttx-website] branch asf-site updated: Publishing web: b18df655dd645517efdb649800882f5fccdc7347 docs: c7c5c754511c2ce50ab3cd83e104c0ec94477896

2022-07-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new b123418 Publishing web

[GitHub] [incubator-nuttx-website] dependabot[bot] opened a new pull request, #70: Bump activesupport from 6.0.2.1 to 6.0.5

2022-07-03 Thread GitBox
dependabot[bot] opened a new pull request, #70: URL: https://github.com/apache/incubator-nuttx-website/pull/70 Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.1 to 6.0.5. Release notes Sourced from https://github.com/rails/rails/releases";>activesupport's releases.

[incubator-nuttx-website] branch dependabot/bundler/activesupport-6.0.5 created (now 9c2a486)

2022-07-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/activesupport-6.0.5 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git at 9c2a486 Bump activesupport from 6.0.2.1 to 6.0.5 No new revisio

[incubator-nuttx-website] branch dependabot/bundler/addressable-2.8.0 created (now 4b15dd5)

2022-07-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/addressable-2.8.0 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git at 4b15dd5 Bump addressable from 2.7.0 to 2.8.0 No new revisions wer

[GitHub] [incubator-nuttx-website] dependabot[bot] opened a new pull request, #69: Bump addressable from 2.7.0 to 2.8.0

2022-07-03 Thread GitBox
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/incubator-nuttx-website/pull/69 Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. Changelog Sourced from https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.

[incubator-nuttx-website] branch master updated: Bump nokogiri from 1.10.7 to 1.13.6

2022-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new b18df65 Bump nokogiri from

[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #65: Bump nokogiri from 1.10.7 to 1.13.6

2022-07-03 Thread GitBox
xiaoxiang781216 merged PR #65: URL: https://github.com/apache/incubator-nuttx-website/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-nuttx] a-lunev commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
a-lunev commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173227327 > Hi, > > I re-reviewed the previous commit, rexmit_seq should only work properly in nonbuffer mode or SNDFILE is enabled, right? If you mean the upstream state befo

[incubator-nuttx-website] branch asf-site updated: Publishing web: 3c980bc717a3874c683a1bd2a48c64c33af05833 docs: c7c5c754511c2ce50ab3cd83e104c0ec94477896

2022-07-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8cb989e Publishing web

[GitHub] [incubator-nuttx-apps] normanr opened a new pull request, #1214: system/hostname: Add an option to read the hostname from a file

2022-07-03 Thread GitBox
normanr opened a new pull request, #1214: URL: https://github.com/apache/incubator-nuttx-apps/pull/1214 ## Summary Add an option to read the hostname from a file (eg: in `/etc/init.d/rcS`). Add a check that the hostname is non-empty. ## Impact Makes it possible to set hostname f

[GitHub] [incubator-nuttx] TregliaRaphael opened a new issue, #6566: NUCLEO-L496ZG-P: no nsh access

2022-07-03 Thread GitBox
TregliaRaphael opened a new issue, #6566: URL: https://github.com/apache/incubator-nuttx/issues/6566 Hi, i'm trying to flash default configuration for the NUCLEO-L496ZG-p board but the nsh console is stuck in readline. Let me go in deeper. **Steps:** ``` mkdir folder_test

[GitHub] [incubator-nuttx] anchao commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
anchao commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173140634 > can we verify that non buffer and SNDFILE work as expect? Yes, I just verified the sim/tcpblaster and confirm which works as expected -- This is an automated message from

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
xiaoxiang781216 commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173139224 can we verify that non buffer and SNDFILE work as expect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] anchao commented on pull request #6562: net/tcp: fix regression of invalid update the rexmit_seq in buffer mode

2022-07-03 Thread GitBox
anchao commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173137785 I restored the previous rexmit_seq logic, please review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] anchao commented on pull request #6562: net/tcp: remove all rexmit_seq related code

2022-07-03 Thread GitBox
anchao commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173134836 Hi, I re-reviewed the previous commit, rexmit_seq should only work properly in nonbuffer mode or SNDFILE is enabled, right? NET_TCP_WRITE_BUFFERS is used in our project, I

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6565: arch/risc-v: Move __XSTR, FLOAD/FSTORE and REGLOAD/REGSTORE to the right place

2022-07-03 Thread GitBox
xiaoxiang781216 opened a new pull request, #6565: URL: https://github.com/apache/incubator-nuttx/pull/6565 ## Summary 1.Move __XSTR from include/arch.h to include/irq.h 2.Move FLOAD/FSTORE and REGLOAD/REGSTORE from include/arch.h to src/common/riscv_internal.h ## Impact code

[incubator-nuttx] branch master updated: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c7c5c75451 net_if: add IFF_LOOPB

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread GitBox
hartmannathan commented on code in PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r912491298 ## include/net/if.h: ## @@ -46,32 +46,48 @@ /* Interface flag bits */ -#define IFF_DOWN (1 << 0) /* Interface is down */ -#define IFF_UP

[GitHub] [incubator-nuttx] hartmannathan merged pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread GitBox
hartmannathan merged PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] acassis commented on pull request #6562: net/tcp: remove all rexmit_seq related code

2022-07-03 Thread GitBox
acassis commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173073710 Hi @anchao could you please give more details about the issue? Also, is it possible to fix the "sndseq override by incorrect seqno" instead of removing the retransmit support? @ma

[GitHub] [incubator-nuttx] zhhyu7 commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread GitBox
zhhyu7 commented on code in PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r912462884 ## include/net/if.h: ## @@ -46,32 +46,48 @@ /* Interface flag bits */ -#define IFF_DOWN (1 << 0) /* Interface is down */ -#define IFF_UP

[GitHub] [incubator-nuttx] zhhyu7 commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread GitBox
zhhyu7 commented on code in PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r912462213 ## include/net/if.h: ## @@ -46,32 +46,48 @@ /* Interface flag bits */ -#define IFF_DOWN (1 << 0) /* Interface is down */ -#define IFF_UP

[GitHub] [incubator-nuttx] zhhyu7 commented on a diff in pull request #6543: net_if: add IFF_LOOPBACK/POINTOPOINT/MULTICAST/BROADCAST

2022-07-03 Thread GitBox
zhhyu7 commented on code in PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r912462213 ## include/net/if.h: ## @@ -46,32 +46,48 @@ /* Interface flag bits */ -#define IFF_DOWN (1 << 0) /* Interface is down */ -#define IFF_UP

[GitHub] [incubator-nuttx] a-lunev commented on pull request #6562: net/tcp: remove all rexmit_seq related code

2022-07-03 Thread GitBox
a-lunev commented on PR #6562: URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173048862 Hi all, I am sorry, so far I am still not available. I will try to participate later. Just based on the PR title it seems the track of changes is not that I did. -- This is an

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6551: framebuffer for e-ink display. Added new IOCTL param FBIO_REDRAW

2022-07-03 Thread GitBox
adamkaliszan commented on code in PR #6551: URL: https://github.com/apache/incubator-nuttx/pull/6551#discussion_r912446544 ## drivers/lcd/lcd_framebuffer.c: ## @@ -173,7 +173,30 @@ static int lcdfb_updateearea(FAR struct fb_vtable_s *vtable, fb_coord_t endy; int ret; -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6551: framebuffer for e-ink display. Added new IOCTL param FBIO_REDRAW

2022-07-03 Thread GitBox
xiaoxiang781216 commented on code in PR #6551: URL: https://github.com/apache/incubator-nuttx/pull/6551#discussion_r912441043 ## drivers/lcd/lcd_framebuffer.c: ## @@ -173,7 +173,30 @@ static int lcdfb_updateearea(FAR struct fb_vtable_s *vtable, fb_coord_t endy; int ret;