zhhyu7 commented on code in PR #6543: URL: https://github.com/apache/incubator-nuttx/pull/6543#discussion_r912462213
########## include/net/if.h: ########## @@ -46,32 +46,48 @@ /* Interface flag bits */ -#define IFF_DOWN (1 << 0) /* Interface is down */ -#define IFF_UP (1 << 1) /* Interface is up */ -#define IFF_RUNNING (1 << 2) /* Carrier is available */ -#define IFF_IPv6 (1 << 3) /* Configured for IPv6 packet (vs ARP or IPv4) */ -#define IFF_BOUND (1 << 4) /* Bound to a socket */ -#define IFF_NOARP (1 << 7) /* ARP is not required for this packet */ +#define IFF_DOWN (1 << 0) /* Interface is down */ +#define IFF_UP (1 << 1) /* Interface is up */ +#define IFF_RUNNING (1 << 2) /* Carrier is available */ +#define IFF_IPv6 (1 << 3) /* Configured for IPv6 packet (vs ARP or IPv4) */ +#define IFF_BOUND (1 << 4) /* Bound to a socket */ +#define IFF_LOOPBACK (1 << 5) /* Is a loopback net */ +#define IFF_POINTOPOINT (1 << 6) /* Is point-to-point link */ +#define IFF_NOARP (1 << 7) /* ARP is not required for this packet */ +#define IFF_MULTICAST (1 << 12) /* Supports multicast. */ +#define IFF_BROADCAST (1 << 13) /* Broadcast address valid. */ Review Comment: > Just a question: why 12 and 13 bits are used and not 8 and 9? I was just reusing the Linux definition, do I need to change it to bit 8 and 9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
