[GitHub] [incubator-nuttx] anchao opened a new pull request, #6430: wireless/bcm430xx: rename chip minor id to 'x'

anchao opened a new pull request, #6430: URL: https://github.com/apache/incubator-nuttx/pull/6430 ## Summary wireless/bcm430xx: rename chip minor id to 'x' rename 4301x chip minor id to 'x' to compatible more versions of variant of bcm430xx Signed-off-by: chao.an

[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6426: stm32wl5: add flash progmem driver support

mlyszczek commented on code in PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#discussion_r896429729 ## arch/arm/src/stm32wl5/stm32wl5_flash.c: ## @@ -359,6 +343,31 @@ ssize_t up_progmem_eraseblock(size_t block) } } +ssize_t up_progmem_ispageerased(siz

[incubator-nuttx] branch master updated (1f90e5a5b0 -> cf91b403c9)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 1f90e5a5b0 arch/xtensa: Don't build xtensa_coproc.S, it has only macros and is included when needed.

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6429: arch: imx6: Enable imx_idle.c to reduce CPU load

pkarashchenko merged PR #6429: URL: https://github.com/apache/incubator-nuttx/pull/6429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r896409087 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

xiaoxiang781216 commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r896406323 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: > > I had tested arc4random_buf, it generated

[GitHub] [incubator-nuttx] normanr commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

normanr commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r896375519 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: > I had tested arc4random_buf, it generated the exact

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request, #6429: arch: imx6: Enable imx_idle.c to reduce CPU load

masayuki2009 opened a new pull request, #6429: URL: https://github.com/apache/incubator-nuttx/pull/6429 ## Summary - I noticed that QEMU shows a high CPU load. - This commit re-adds imx_idle.c to avoid this issue. ## Impact - None ## Testing - Tested with

[GitHub] [incubator-nuttx] normanr commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

normanr commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r896375519 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: > I had tested arc4random_buf, it generated the exact

[GitHub] [incubator-nuttx] normanr commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

normanr commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r896375519 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: > I had tested arc4random_buf, it generated the exact

[GitHub] [incubator-nuttx] normanr commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

normanr commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r896375519 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: > I had tested arc4random_buf, it generated the exact

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6428: net/tcp: d_appdata should remove the tcp specific option field

anchao opened a new pull request, #6428: URL: https://github.com/apache/incubator-nuttx/pull/6428 ## Summary net/tcp: d_appdata should remove the tcp specific option field applicate data field should not touch data of IP layer Signed-off-by: chao.an ## Impact

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6418: Eps32 Lilygo t5v2 BSP

adamkaliszan commented on code in PR #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r896362141 ## boards/xtensa/esp32/ttgo_eink5_v2/scripts/Make.defs: ## @@ -0,0 +1,105 @@ + +

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6427: wireless/bcm43xxx: load nvram from file system

anchao opened a new pull request, #6427: URL: https://github.com/apache/incubator-nuttx/pull/6427 ## Summary wireless/bcm43xxx: load nvram from file system added an option to load nvram from file system, which will help developers easily to tuning the firmware parameters with

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6426: stm32wl5: add flash progmem driver support

xiaoxiang781216 commented on code in PR #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426#discussion_r896319032 ## arch/arm/src/stm32wl5/stm32wl5_flash.c: ## @@ -359,6 +343,31 @@ ssize_t up_progmem_eraseblock(size_t block) } } +ssize_t up_progmem_ispageeras

[incubator-nuttx-website] branch asf-site updated: Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: 1f90e5a5b00ab1bebe002bc336b34a202690d1f6

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 7477509 Publishing web

[GitHub] [incubator-nuttx] mlyszczek opened a new pull request, #6426: stm32wl5: add flash progmem driver support

mlyszczek opened a new pull request, #6426: URL: https://github.com/apache/incubator-nuttx/pull/6426 ## Summary These patches add support for progmem driver to use internal FLASH memory to hold user's data. Support to partition FLASH to up to 4 partitions has beed added to nucleo-wl55jc

[incubator-nuttx] branch master updated: arch/xtensa: Don't build xtensa_coproc.S, it has only macros and is included when needed.

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1f90e5a5b0 arch/xtensa: Don't bu

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6425: arch/xtensa: Don't build xtensa_coproc.S

pkarashchenko merged PR #6425: URL: https://github.com/apache/incubator-nuttx/pull/6425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

gustavonihei commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895993180 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_gr

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

gustavonihei commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895991361 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_gr

[incubator-nuttx] branch master updated: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9985e0a43e arm/tlsr82: bugfix, tlsr8

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

xiaoxiang781216 merged PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6418: Eps32 Lilygo t5v2 BSP

xiaoxiang781216 commented on code in PR #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r895955531 ## boards/xtensa/esp32/ttgo_eink5_v2/scripts/Make.defs: ## @@ -0,0 +1,105 @@ +###

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895932656 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895932656 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[incubator-nuttx] branch master updated: drivers/syslog: fix deadlock by reverting part of the changes from b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new e42e3aa642 drivers/syslog: fix deadl

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6414: drivers/syslog: fix deadlock by reverting part of the changes from b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

xiaoxiang781216 merged PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895860595 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895860595 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

CV-Bowen commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895841532 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -729,7 +769,7 @@ static int tlsr82_flash_ioctl(struct mtd_dev_s *dev, int cmd,

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

pkarashchenko commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895829269 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -729,7 +769,7 @@ static int tlsr82_flash_ioctl(struct mtd_dev_s *dev, int cmd,

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895827664 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

CV-Bowen commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895825227 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -354,7 +364,14 @@ static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv) ferr("Flash chip erase test

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895821153 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895818558 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895811358 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,30 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

pkarashchenko commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895804674 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -429,7 +446,14 @@ static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv) int k; ferr("Eras

[incubator-nuttx] branch master updated: getrandom: use _NX_XXXX interface to remove cancelation point for kernel

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 02682af759 getrandom: use _NX_ i

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6421: getrandom: use _NX_XXXX interface to remove cancelation point for kernel

xiaoxiang781216 merged PR #6421: URL: https://github.com/apache/incubator-nuttx/pull/6421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

CV-Bowen commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895730369 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -775,6 +806,7 @@ static int tlsr82_flash_ioctl(struct mtd_dev_s *dev, int cmd, /* Ignore arg, direc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

xiaoxiang781216 commented on code in PR #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895689135 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -775,6 +806,7 @@ static int tlsr82_flash_ioctl(struct mtd_dev_s *dev, int cmd, /* Ignore arg

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6425: arch/xtensa: Don't build xtensa_coproc.S

Ouss4 opened a new pull request, #6425: URL: https://github.com/apache/incubator-nuttx/pull/6425 ## Summary Don't build xtensa_coproc.S, it has only macros and is included when needed. ## Impact N/A ## Testing ESP32, ESP32-S2, ESP32-S3 -- This is an automated message fro

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6420: wireless/bcm43xxx: add support of bcm43013 chip

xiaoxiang781216 merged PR #6420: URL: https://github.com/apache/incubator-nuttx/pull/6420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: wireless/bcm43xxx: add support of bcm43013 chip

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c7fd1a113f wireless/bcm43xxx: add su

[incubator-nuttx-apps] branch master updated: wireless/wapi: fix wapi wpa_wconfig_s sta_mode data type error

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ce7c9ae65 wireless/wapi: fix wa

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1196: wireless/wapi: fix wapi wpa_wconfig_s sta_mode data type error

xiaoxiang781216 merged PR #1196: URL: https://github.com/apache/incubator-nuttx-apps/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895681153 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895677603 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[incubator-nuttx] branch master updated (4e5d8aca3d -> 7e1f906b74)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 4e5d8aca3d nucleo-wl55jc: add buttons and gpio interrupt support add 7e1f906b74 drvers/mmcsd/sdio

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6419: drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY

pkarashchenko merged PR #6419: URL: https://github.com/apache/incubator-nuttx/pull/6419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895673222 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] CV-Bowen opened a new pull request, #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

CV-Bowen opened a new pull request, #6424: URL: https://github.com/apache/incubator-nuttx/pull/6424 ## Summary 1. correct the tlsr82_flash_ioctl() return value; 2. tlsr82_flash_test() using api tlsr82_flash_ioctl(); ## Impact tlsr82 flash ## Testing local test with t

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895673222 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895673222 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6414: drivers/syslog: fix deadlock by reverting part of the changes from b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

pkarashchenko commented on code in PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#discussion_r895667526 ## drivers/syslog/syslog_device.c: ## @@ -120,6 +123,63 @@ static const uint8_t g_syscrlf[2] = * Private Functions

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895661902 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895661902 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6414: drivers/syslog: fix deadlock by reverting part of the changes from b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

pkarashchenko commented on PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#issuecomment-1153861541 @davids5 done. Anyway I was trying to address another part in https://github.com/apache/incubator-nuttx/pull/6376 I think we need to revert libc related changes anyway and

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895661902 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895661902 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895661902 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_group_s

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6423: sched/env: Fix the return value of unsetenv()

pkarashchenko commented on code in PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#discussion_r895653622 ## sched/environ/env_unsetenv.c: ## @@ -61,23 +61,22 @@ int unsetenv(FAR const char *name) { FAR struct tcb_s *rtcb = this_task(); FAR struct task_g

[incubator-nuttx] branch master updated (cb8c992914 -> 4e5d8aca3d)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from cb8c992914 drivers/sensors: add driver for as5048a magnetic encoder add 288b57d5ca stm32wl5: add EXTI

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6413: stm32wl5: add gpio exti support

xiaoxiang781216 merged PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT

xiaoxiang781216 closed pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT URL: https://github.com/apache/incubator-nuttx-apps/pull/1195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT

xiaoxiang781216 commented on PR #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195#issuecomment-1153844348 > unsetenv should never return ENOENT > > [apache/incubator-nuttx#6423](https://github.com/apache/incubator-nuttx/pull/6423) So we don't need this patch

[GitHub] [incubator-nuttx] pussuw commented on pull request #6423: sched/env: Fix the return value of unsetenv()

pussuw commented on PR #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423#issuecomment-1153842652 Missed that env_removevar() takes the index in. Fixed now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6423: sched/env: Fix the return value of unsetenv()

pussuw opened a new pull request, #6423: URL: https://github.com/apache/incubator-nuttx/pull/6423 If the environment variable does not exist, the function succeeds, as defined by POSIX. ## Summary Fixes return value of unsetenv, value was accidentally broken in #6083 ## Impact

[GitHub] [incubator-nuttx] onegray opened a new pull request, #6422: New chip family stm32wb (WIP)

onegray opened a new pull request, #6422: URL: https://github.com/apache/incubator-nuttx/pull/6422 ## Summary Work in progress ## Impact None ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx-apps] pussuw commented on pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT

pussuw commented on PR #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195#issuecomment-1153827145 unsetenv should never return ENOENT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx-apps] jlaitine commented on pull request #1194: nshlib/nsh_envcmd.c: Change cmd_unset to only unset existing env vari…

jlaitine commented on PR #1194: URL: https://github.com/apache/incubator-nuttx-apps/pull/1194#issuecomment-1153824111 Just one more comment on this; unsetenv is a posix interface, which should return "success" if the environment variable is not set (i.e. it already doesn't exist). S

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

pkarashchenko commented on PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#issuecomment-1153805071 Ok. I will split the change into 2 PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] davids5 commented on pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

davids5 commented on PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#issuecomment-1153796273 >Let's restore things to a working state and then do a single change for the syslog update. I was going to suggest spitting this into 2 PR. A revert and a fix for syslog i

[GitHub] [incubator-nuttx-apps] normanr opened a new pull request, #1196: wireless/wapi: fix wapi wpa_wconfig_s sta_mode data type error

normanr opened a new pull request, #1196: URL: https://github.com/apache/incubator-nuttx-apps/pull/1196 ## Summary Similar to #1134: This fixes the sta_mode field data type which causes: ```c src/wapi.c: In function 'wapi_save_config_cmd': src/wapi.c:866:38: warning: passing argum

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

pkarashchenko commented on code in PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#discussion_r895594941 ## drivers/syslog/syslog_device.c: ## @@ -120,6 +123,63 @@ static const uint8_t g_syscrlf[2] = * Private Functions

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

xiaoxiang781216 commented on code in PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#discussion_r895593423 ## drivers/syslog/syslog_device.c: ## @@ -120,6 +123,63 @@ static const uint8_t g_syscrlf[2] = * Private Functions **

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

xiaoxiang781216 commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895575691 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: Thanks -- This is an automated message fr

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

pkarashchenko commented on PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#issuecomment-1153757846 @davids5 the deadlock is only caused by changes in `drivers/syslog/syslog_device.c`. Initially the syslog take semaphore was returning error code if semaphore is already

[GitHub] [incubator-nuttx] davids5 commented on pull request #6414: mutex: Revert part of the changes introduced by b88a8cf39ff1019ad787c4316b22ce29c7daa2dc

davids5 commented on PR #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414#issuecomment-1153752476 @pkarashchenko On looking at this revert and the replacement. At first blush it looks like semaphore based code does exactly what the rmutex added. Would you please enumerate the

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6418: Eps32 Lilygo t5v2 BSP

adamkaliszan commented on code in PR #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r895558665 ## boards/xtensa/esp32/common/include/esp32_ssd1680.h: ## @@ -0,0 +1,64 @@ +/ +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

pkarashchenko commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895553280 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: I created https://github.com/apache/incubator-n

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6421: getrandom: use _NX_XXXX interface to remove cancelation point for kernel

pkarashchenko opened a new pull request, #6421: URL: https://github.com/apache/incubator-nuttx/pull/6421 ## Summary `getrandom` should use `_NX_OPEN`/`_NX_READ`/`_NX_CLOSE` interface when it is called from kernel. ## Impact Should be none ## Testing Pass CI -- This

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6420: wireless/bcm43xxx: add support of bcm43013 chip

anchao opened a new pull request, #6420: URL: https://github.com/apache/incubator-nuttx/pull/6420 ## Summary wireless/bcm43xxx: add support of bcm43013 chip Reference: https://www.broadcom.cn/bcm43013 Signed-off-by: chao.an ## Impact N/A, new chip

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6419: drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY

anchao commented on code in PR #6419: URL: https://github.com/apache/incubator-nuttx/pull/6419#discussion_r895513378 ## drivers/mmcsd/sdio.c: ## @@ -460,15 +460,15 @@ int sdio_enable_function(FAR struct sdio_dev_s *dev, uint8_t function) return ret; } - /* Wait 1

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6419: drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY

anchao commented on code in PR #6419: URL: https://github.com/apache/incubator-nuttx/pull/6419#discussion_r895510634 ## drivers/mmcsd/sdio.c: ## @@ -460,15 +460,15 @@ int sdio_enable_function(FAR struct sdio_dev_s *dev, uint8_t function) return ret; } - /* Wait 1

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

pkarashchenko merged PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated (a0ff6f9fa6 -> cb8c992914)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from a0ff6f9fa6 arch: k210: Add a workaround for clock stabilization add cb8c992914 drivers/sensors: a

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6419: drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY

pkarashchenko commented on code in PR #6419: URL: https://github.com/apache/incubator-nuttx/pull/6419#discussion_r895506550 ## drivers/mmcsd/sdio.c: ## @@ -460,15 +460,15 @@ int sdio_enable_function(FAR struct sdio_dev_s *dev, uint8_t function) return ret; } - /*

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

pkarashchenko commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895503448 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: I think that kernel has it's own implementation

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6419: drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY

anchao opened a new pull request, #6419: URL: https://github.com/apache/incubator-nuttx/pull/6419 ## Summary drvers/mmcsd/sdio: function enable should wait for CCCR_IORDY 1. function enable should wait for CCCR_IORDY 2. enlarge wait timeout from 10ms to 1s Change-Id: I

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6418: Eps32 Lilygo t5v2 BSP

pkarashchenko commented on code in PR #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418#discussion_r895497090 ## boards/xtensa/esp32/common/include/esp32_ssd1680.h: ## @@ -0,0 +1,64 @@ +/ +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6413: stm32wl5: add gpio exti support

pkarashchenko commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895495289 ## boards/arm/stm32wl5/nucleo-wl55jc/src/stm32_leds.c: ## @@ -188,7 +215,13 @@ void board_autoled_off(int state) uint32_t board_userled_initialize(void)

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT

pkarashchenko commented on code in PR #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195#discussion_r895482687 ## nshlib/nsh_envcmds.c: ## @@ -552,7 +552,7 @@ int cmd_unset(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv) /* Unset environment variable *

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1195: nshlib: Don't output error when unsetenv fail with ENOENT

xiaoxiang781216 commented on PR #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195#issuecomment-1153597176 @jlaitine here is the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1195: nshlib: Don't output error when unsetenv fail with ENOENT

xiaoxiang781216 opened a new pull request, #1195: URL: https://github.com/apache/incubator-nuttx-apps/pull/1195 ## Summary Fix the issue report here: https://github.com/apache/incubator-nuttx-apps/pull/1194 ## Impact ## Testing -- This is an automated message from

[incubator-nuttx-apps] branch master updated: serialblaster bugfix

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 835f43524 serialblaster bugfix

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1193: serialblaster bugfix

xiaoxiang781216 merged PR #1193: URL: https://github.com/apache/incubator-nuttx-apps/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6413: stm32wl5: add gpio exti support

mlyszczek commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895404698 ## arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c: ## @@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg) int stm32wl5_g