[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #1042: Fix readline_common.c:277:19: error: 'strncpy' destination unchanged after copying no bytes

2022-03-04 Thread GitBox
xiaoxiang781216 opened a new pull request #1042: URL: https://github.com/apache/incubator-nuttx-apps/pull/1042 ## Summary Report here: https://github.com/apache/incubator-nuttx/runs/5431571859?check_suite_focus=true ## Impact Fix warning ## Testing Pass CI -- T

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

2022-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r820062588 ## File path: drivers/input/ajoystick.c ## @@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char *buffer, /

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1b39f27b512cbb1fc294b70e0e70a67d0092b98d docs: b3b48a658ff944e0b9186119b720f001aa468ca9

2022-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d3ec273 Publishing web

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

2022-03-04 Thread GitBox
pkarashchenko commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r819914782 ## File path: drivers/input/ajoystick.c ## @@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char *buffer, /*

[incubator-nuttx-apps] branch master updated: netutils/netlib: Fix error: 'strncpy' specified bound 16 equals destination size

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 3afd123 netutils/netlib: F

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1041: netutils/netlib: Fix error: 'strncpy' specified bound 16 equals destination size

2022-03-04 Thread GitBox
pkarashchenko merged pull request #1041: URL: https://github.com/apache/incubator-nuttx-apps/pull/1041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5681: Simplify and unify fcntl with FIOCLEX and FIONCLEX

2022-03-04 Thread GitBox
pkarashchenko merged pull request #5681: URL: https://github.com/apache/incubator-nuttx/pull/5681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] 02/03: net: Remove psock_fcntl related code

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b2c86f808d4553336cd0fd8b669629dd2141dcd6 Author: Xiang Xiao AuthorDate: Fri Mar 4 16:13:17 2022 +0800

[incubator-nuttx] 03/03: fs/aio: Don't include include/nuttx/net/net.h

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b3b48a658ff944e0b9186119b720f001aa468ca9 Author: Xiang Xiao AuthorDate: Sat Mar 5 01:20:46 2022 +0800

[incubator-nuttx] 01/03: vfs: Forward fcntl(F_SETFD...) to ioctl(FIOCLEX|FIONCLEX...)

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 19e796305ad0aa3231f88851936bdcb17ea96445 Author: Xiang Xiao AuthorDate: Fri Mar 4 11:53:57 2022 +0800

[incubator-nuttx] branch master updated (66c61d4 -> b3b48a6)

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 66c61d4 imxrt: userleds: Teensy 4.x board LED is active high new 19e7963 vfs: Forward fcntl(F_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

2022-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r819810584 ## File path: drivers/input/ajoystick.c ## @@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char *buffer, /

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5682: imxrt: userleds: Teensy 4.x board LED is active high

2022-03-04 Thread GitBox
xiaoxiang781216 merged pull request #5682: URL: https://github.com/apache/incubator-nuttx/pull/5682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (041f25f -> 66c61d4)

2022-03-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 041f25f drivers/ioexpander: fix output inversion for ioe_dummy add 66c61d4 imxrt: userleds: Teensy

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5476: boards: Remove -fno-builtin

2022-03-04 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5476: URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1057071027 After removing -no-builtin, the compiler can catch more coding error: #5519 https://github.com/apache/incubator-nuttx/pull/5476/commits/98a361c3461c

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #1041: netutils/netlib: Fix error: 'strncpy' specified bound 16 equals destination size

2022-03-04 Thread GitBox
xiaoxiang781216 opened a new pull request #1041: URL: https://github.com/apache/incubator-nuttx-apps/pull/1041 ## Summary Report here: https://github.com/apache/incubator-nuttx/runs/5424034399?check_suite_focus=true ## Impact Fix compiler warning ## Testing Pass CI

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5681: Simplify and unify fcntl with FIOCLEX and FIONCLEX

2022-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5681: URL: https://github.com/apache/incubator-nuttx/pull/5681#discussion_r819754646 ## File path: net/netdev/netdev_ioctl.c ## @@ -1673,13 +1673,56 @@ int psock_vioctl(FAR struct socket *psock, int cmd, va_list ap) a

[GitHub] [incubator-nuttx] mogenson opened a new pull request #5682: imxrt: userleds: Teensy 4.x board LED is active high

2022-03-04 Thread GitBox
mogenson opened a new pull request #5682: URL: https://github.com/apache/incubator-nuttx/pull/5682 ## Summary The Teensy 4.0 and 4.1 board LED is active high ([according to schematic](https://www.pjrc.com/teensy/schematic.html)). Fix `board_userled()` and `board_userled_all()` to dr

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5681: Simplify and unify fcntl with FIOCLEX and FIONCLEX

2022-03-04 Thread GitBox
pkarashchenko commented on a change in pull request #5681: URL: https://github.com/apache/incubator-nuttx/pull/5681#discussion_r819698809 ## File path: net/netdev/netdev_ioctl.c ## @@ -1673,13 +1673,56 @@ int psock_vioctl(FAR struct socket *psock, int cmd, va_list ap) arg

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5645: arch/arm: optimize context switch speed

2022-03-04 Thread GitBox
pkarashchenko commented on a change in pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#discussion_r819695745 ## File path: arch/arm/src/common/arm_internal.h ## @@ -306,14 +307,10 @@ void arm_boot(void); /* Context switching */ -void arm_copyfu

[GitHub] [incubator-nuttx] anchao commented on pull request #5645: arch/arm: optimize context switch speed

2022-03-04 Thread GitBox
anchao commented on pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#issuecomment-1059281173 > Here, r3 is loaded from [r7, #0] and r7 FP: 80204678 shows the address is in the userland heap (i.e. user stack), so this might be correct but its content (i.e. the va

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #929: MCUboot move apps to examples

2022-03-04 Thread GitBox
pkarashchenko commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1059271340 > > I still need a day to think about this change. In general I support a motivation of moving things to `apps/examples` and group related functionality in `m

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5681: Simplify and unify fcntl with FIOCLEX and FIONCLEX

2022-03-04 Thread GitBox
xiaoxiang781216 opened a new pull request #5681: URL: https://github.com/apache/incubator-nuttx/pull/5681 ## Summary Follow up the change from: https://github.com/apache/incubator-nuttx/pull/5573 - vfs: Forward fcntl(F_SETFD...) to ioctl(FIOCLEX|FIONCLEX...) - net: Remove psock_fc

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1059253533 > So you want CONFIG_NEON only change the userspace code, this could be worked, but it's better to fix the root cause. Let's wait @anchao 's patch before we merge

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #929: MCUboot move apps to examples

2022-03-04 Thread GitBox
xiaoxiang781216 commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1059253203 How to proceed this PR now? It isn't good to hold a PR for long time. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
xiaoxiang781216 commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1059250033 So you want CONFIG_NEON only change the userspace code, this could be worked, but it's better to fix the root cause. Let's wait @anchao 's patch before we merge

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5680: drivers/ioexpander: fix output inversion for ioe_dummy

2022-03-04 Thread GitBox
xiaoxiang781216 merged pull request #5680: URL: https://github.com/apache/incubator-nuttx/pull/5680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (fa0e5da -> 041f25f)

2022-03-04 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from fa0e5da xtensa/xtensa_user_handler.S: Store EXCCAUSE and EXCVADDR into the user frame. The user frame i

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5645: arch/arm: optimize context switch speed

2022-03-04 Thread GitBox
masayuki2009 commented on pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#issuecomment-1059113053 @anchao The original issue with sabre-6quad:netknsh (QEMU) still happens. You can try the latest my branches with your patches. Please note that gcc-ar

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1040: netutils/usrsock_rpmsg: Switch the nonblocking mode by psock_ioctl instead

2022-03-04 Thread GitBox
pkarashchenko merged pull request #1040: URL: https://github.com/apache/incubator-nuttx-apps/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[incubator-nuttx-apps] branch master updated: netutils/usrsock_rpmsg: Switch the nonblocking mode by psock_ioctl instead

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new f31cc67 netutils/usrsock_r

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5680: drivers/ioexpander: fix output inversion for ioe_dummy

2022-03-04 Thread GitBox
pkarashchenko opened a new pull request #5680: URL: https://github.com/apache/incubator-nuttx/pull/5680 ## Summary Inversion of output IO expander pins does not work for ioe_dummy. Fix it and update the rest of IO expander implementations and add type cast to `ioe_pinset_t`. ## I

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5645: arch/arm: optimize context switch speed

2022-03-04 Thread GitBox
masayuki2009 commented on pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#issuecomment-1059071451 @xiaoxiang781216 @anchao I noticed that lm3s6965-ek:qemu-kostest (QEMU) failed with this PR. ``` user_main: condition variable test cond_test: I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5645: arch/arm: optimize context switch speed

2022-03-04 Thread GitBox
xiaoxiang781216 commented on pull request #5645: URL: https://github.com/apache/incubator-nuttx/pull/5645#issuecomment-1059049084 @masayuki2009 could you try the update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1040: netutils/usrsock_rpmsg: Switch the nonblocking mode by psock_ioctl instead

2022-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1040: URL: https://github.com/apache/incubator-nuttx-apps/pull/1040#discussion_r819462133 ## File path: netutils/usrsock_rpmsg/usrsock_rpmsg_server.c ## @@ -664,9 +661,9 @@ static int usrsock_rpmsg_accept_handler(struct r

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1040: netutils/usrsock_rpmsg: Switch the nonblocking mode by psock_ioctl instead

2022-03-04 Thread GitBox
pkarashchenko commented on a change in pull request #1040: URL: https://github.com/apache/incubator-nuttx-apps/pull/1040#discussion_r819453815 ## File path: netutils/usrsock_rpmsg/usrsock_rpmsg_server.c ## @@ -664,9 +661,9 @@ static int usrsock_rpmsg_accept_handler(struct rpm

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko edited a comment on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058979921 >> @minabeoki do you recommend to default NEON to n? > We need fix this problem instead, the default value just hide/postpone the problem. If we can'

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko edited a comment on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058979921 >> @minabeoki do you recommend to default NEON to n? > We need fix this problem instead, the default value just hide/postpone the problem. If we can't fi

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5679: xtensa/xtensa_user_handler.S: Store EXCCAUSE and EXCVADDR into the user frame.

2022-03-04 Thread GitBox
pkarashchenko merged pull request #5679: URL: https://github.com/apache/incubator-nuttx/pull/5679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (779665c -> fa0e5da)

2022-03-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 779665c arch/arm/src/stm32l4: STM32L4+ might need flash data cache corruption workaround add f

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko edited a comment on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058979921 >> @minabeoki do you recommend to default NEON to n? > We need fix this problem instead, the default value just hide/postpone the problem. If we can'

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058979921 > ill break in the current implementation since FPU context doesn't in Is disabling NEON for kernel build an option? I mean can we still use NEON for applic

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #1040: netutils/usrsock_rpmsg: Switch the nonblocking mode by psock_ioctl instead

2022-03-04 Thread GitBox
xiaoxiang781216 opened a new pull request #1040: URL: https://github.com/apache/incubator-nuttx-apps/pull/1040 ## Summary since it's more simpler than psock_ioctl ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058969824 > @minabeoki do you recommend to default NEON to `n`? We need fix this problem instead, the default value just hide/postpone the problem. If we can

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5679: xtensa/xtensa_user_handler.S: Store EXCCAUSE and EXCVADDR into the user frame.

2022-03-04 Thread GitBox
Ouss4 commented on pull request #5679: URL: https://github.com/apache/incubator-nuttx/pull/5679#issuecomment-1058970063 > @Ouss4 this file is with strange formatting, it uses TAB in most part of and but the block under #ifdef CONFIG_XTENSA_INTBACKTRACE uses two spaces, like normally we use

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
xiaoxiang781216 commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058969824 > @minabeoki do you recommend to default NEON to `n`? We need fix this problem instead, the default value just hide/postpone the problem. If we can't fix

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
xiaoxiang781216 commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058967929 > @xiaoxiang781216 I compiled for sabre-6quad(A9) config, and checked the compiled assemble code. In case of "-mfpu=neon-vfpv3", GCC uese NEON instructions for

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058961977 @minabeoki do you recommend to default NEON to `n`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx] minabeoki commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-04 Thread GitBox
minabeoki commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1058959569 @xiaoxiang781216 I compiled for sabre-6quad(A9) config, and checked the compiled assemble code. In case of "-mfpu=neon-vfpv3", GCC uese NEON instructions for in