[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1056502008 > @xiaoxiang781216 I think that we can drop dependency on `nuttx/compiler.h` now. I think so before, but assert reference noreturn_function:(. -- This

[incubator-nuttx] branch master updated (572f961 -> 4a16cf7)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 572f961 ci: Update gcc-arm-none-eabi to 10.3-2021.10 add 4a16cf7 Fix -Werror=nonnull-compare and -

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[incubator-nuttx-apps] branch master updated: Ignore .context (follow NuttX main repo)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 9439fd8 Ignore .context (follo

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056497307 Why this PR is closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817428618 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: from this patc

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5660: syscal: Remove .context form .gitignore

2022-03-01 Thread GitBox
xiaoxiang781216 opened a new pull request #5660: URL: https://github.com/apache/incubator-nuttx/pull/5660 ## Summary since it is already added in the top level of .gitignore in https://github.com/apache/incubator-nuttx/pull/5055 ## Impact Minor ## Testing Pass CI

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #5641: sim: add loop thread to handle dev loops

2022-03-01 Thread GitBox
GUIDINGLI commented on pull request #5641: URL: https://github.com/apache/incubator-nuttx/pull/5641#issuecomment-1056493454 > @GUIDINGLI > > Could you rebase your branch to the latest master? done -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659#issuecomment-1056486117 BTW, we can try moving to GCC11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1056484275 @xiaoxiang781216 I think that we can drop dependency on `nuttx/compiler.h` now. -- This is an automated message from the Apache Git Service. To respond to the m

[incubator-nuttx] branch master updated (9c7eea7 -> 572f961)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9c7eea7 drivers/ioexpander: Fix invert option value usage add 572f961 ci: Update gcc-arm-none-eabi

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
xiaoxiang781216 closed pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056431517 Yes we can, but softfp may cause performance issue on these platforms. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056431517 Yes, but softfp may cause performance issue on these platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056413203 Can we use softfp libs if hardfp are not available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
no1wudi commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817377794 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: Not sure it was genera

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5659: ci: Update gcc-arm-none-eabi to 10.3-2021.10

2022-03-01 Thread GitBox
no1wudi opened a new pull request #5659: URL: https://github.com/apache/incubator-nuttx/pull/5659 ## Summary There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it don't report libgcc.a correctly for FPU enabled case: ``` gcc-arm-none-eabi-9-2019-q4-major/bin/arm-none-eabi-gc

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056109598 @xiaoxiang781216 @pkarashchenko There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it don't report libgcc.a correctly for FPU enabled case: ``` g

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056109598 @xiaoxiang781216 @pkarashchenko There is a bug in arm-none-eabi-gcc 9.2 for cortex a that it dont report libgcc.a correctly for FPU enabled case: ``` gcc-arm-n

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817297839 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: which Makefile

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037#discussion_r817297839 ## File path: .gitignore ## @@ -25,5 +25,6 @@ /symtab_apps.c cscope.out Make.dep +.context Review comment: which Makefile

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on a change in pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r817288958 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MAXOPTIM

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r817286908 ## File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs ## @@ -34,7 +34,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MA

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi edited a comment on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056055658 > @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? It also passed on my local machine with latest PR but failed on CI,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056053377 @no1wudi but the build fails for `giant-board`. Could you please examine that case as well? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056052568 @pkarashchenko Yes, I got compiling flags like: ``` arm-none-eabi-gcc -c -fno-common -fno-builtin -Wall -Wstrict-prototypes -Wshadow -Wundef -Os -fomit-frame-point

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056049809 > > The errors are still the same. We are loosing compilation flags for compiler libs > > Maybe, but compilation passed on my local machine with latest gcc

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #1037: Ignore .context (follow NuttX main repo)

2022-03-01 Thread GitBox
no1wudi opened a new pull request #1037: URL: https://github.com/apache/incubator-nuttx-apps/pull/1037 ## Summary Add .context to ignore ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
no1wudi commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1056033742 > The errors are still the same. We are loosing compilation flags for compiler libs Maybe, but compilation passed on my local machine with latest gcc-arm-none-ea

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1b39f27b512cbb1fc294b70e0e70a67d0092b98d docs: 9c7eea79497ceb2a0b581fe13141280d5abab982

2022-03-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5564a75 Publishing web

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5641: sim: add loop thread to handle dev loops

2022-03-01 Thread GitBox
masayuki2009 commented on pull request #5641: URL: https://github.com/apache/incubator-nuttx/pull/5641#issuecomment-1055957021 @GUIDINGLI Could you rebase your branch to the latest master? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5658: sched/group: Simplify the allocation and deallocation logic

2022-03-01 Thread GitBox
masayuki2009 commented on pull request #5658: URL: https://github.com/apache/incubator-nuttx/pull/5658#issuecomment-1055951392 @xiaoxiang781216 Hmm, sabre-6quad:knsh has an issue. ``` $ qemu-system-arm -semihosting -M sabrelite -m 1024 -smp 4 -kernel ./nuttx -nographic

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5658: sched/group: Simplify the allocation and deallocation logic

2022-03-01 Thread GitBox
xiaoxiang781216 opened a new pull request #5658: URL: https://github.com/apache/incubator-nuttx/pull/5658 ## Summary 1.Move tg_membe allocation to group_alloc 2.Merge group_deallocate to group_release ## Impact Code refactor only ## Testing Pass CI and local test

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817035988 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817030722 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5657: drivers/ioexpander: Fix invert option value usage

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5657: URL: https://github.com/apache/incubator-nuttx/pull/5657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (5ed0e95 -> 9c7eea7)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 5ed0e95 LICENSE: cleanup add 9c7eea7 drivers/ioexpander: Fix invert option value usage No new rev

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5656: LICENSE: cleanup

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5656: URL: https://github.com/apache/incubator-nuttx/pull/5656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (dc99ce5 -> 5ed0e95)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from dc99ce5 boards: s32k1xx: revert to the original license add 5ed0e95 LICENSE: cleanup No new revis

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #1032: pwm: Fix issue with directing to "> /dev/null"

2022-03-01 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1032: URL: https://github.com/apache/incubator-nuttx-apps/pull/1032#issuecomment-1055702122 The better solution is make nsh work with open/read/write/close, not fopen/fread/fwrite/fclose, which could let's disable CONFIG_FILE_STREAM in the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1032: pwm: Fix issue with directing to "> /dev/null"

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #1032: URL: https://github.com/apache/incubator-nuttx-apps/pull/1032#issuecomment-1055702122 The better solution is make nsh work with open/read/write/close, not fopen/fread/fwrite/fclose, which could let's disable CONFIG_FILE_STREAM in the most c

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r817006877 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055694034 > The another option is to add `#undef UNUSED` at the beginning of `nuttx/compiler.h` It only work when we include the third party header file first and t

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055653371 The another option is to add `#undef UNUSED` at the beginning of `nuttx/compiler.h` -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1036: system/libuv: Switch process.c to process_spawn.c

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #1036: URL: https://github.com/apache/incubator-nuttx-apps/pull/1036#issuecomment-1055641371 Please fix ``` libuv/src/unix/process-spawn.c: In function 'uv__chld': Error: libuv/src/unix/process-spawn.c:49:20: error: 'SIGCHLD' undeclared (fi

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5204: joystck/buttons: Always protect the open list by critical section

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5204: URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r816948394 ## File path: drivers/input/ajoystick.c ## @@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char *buffer, /*

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816945929 ## File path: drivers/input/djoystick.c ## @@ -713,6 +711,17 @@ static int djoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816945656 ## File path: drivers/input/button_upper.c ## @@ -759,6 +767,19 @@ static int btn_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816944734 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5657: drivers/ioexpander: Fix invert option value usage

2022-03-01 Thread GitBox
pkarashchenko opened a new pull request #5657: URL: https://github.com/apache/incubator-nuttx/pull/5657 ## Summary Wrong macro used for checking invert option value ## Impact None ## Testing Pass CI -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5151: Tiva CAN driver

2022-03-01 Thread GitBox
hartmannathan commented on a change in pull request #5151: URL: https://github.com/apache/incubator-nuttx/pull/5151#discussion_r816899745 ## File path: arch/arm/src/tiva/common/tiva_can.c ## @@ -0,0 +1,2401 @@ +/**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r816888660 ## File path: arch/arm/src/armv7-a/Toolchain.defs ## @@ -59,18 +59,27 @@ ifeq ($(CONFIG_ARM_THUMB),y) ARCHCPUFLAGS += -mthumb endif -i

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5656: LICENSE: cleanup

2022-03-01 Thread GitBox
jerpelea opened a new pull request #5656: URL: https://github.com/apache/incubator-nuttx/pull/5656 ## Summary cleanup the license file: - remove Authors - add missing delimiters - add missing spaces - remove duplicate licenses ## Impact NONE ## Testing NONE

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816878380 ## File path: drivers/input/button_upper.c ## @@ -97,6 +97,7 @@ struct btn_open_s */ FAR struct pollfd *bo_fds[CONFIG_INPUT_BUTTO

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816872225 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816869186 ## File path: drivers/input/ajoystick.c ## @@ -194,19 +194,8 @@ static void ajoy_enable(FAR struct ajoy_upperhalf_s *priv) for (opriv

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816865704 ## File path: drivers/input/ajoystick.c ## @@ -100,6 +100,7 @@ struct ajoy_open_s * driver events. */ + bool ao_pollpending; R

[incubator-nuttx] branch master updated (2197fb2 -> dc99ce5)

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2197fb2 fs/romfs: fix read file mismatch when the length of file name is 16 add 63f2fbf LICENSE:

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5651: LICENSE: document licenses from boards folders

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #5651: URL: https://github.com/apache/incubator-nuttx/pull/5651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] pkarashchenko opened a new issue #5655: Remove the kernel spawn proxy thread

2022-03-01 Thread GitBox
pkarashchenko opened a new issue #5655: URL: https://github.com/apache/incubator-nuttx/issues/5655 This task is a follow-up for https://github.com/apache/incubator-nuttx/pull/5649 Please follow discussion in the original patch: https://github.com/apache/incubator-nuttx/pull/5391 -- T

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1034: Simplify DEFAULT_SMALL usage in Kconfig

2022-03-01 Thread GitBox
xiaoxiang781216 merged pull request #1034: URL: https://github.com/apache/incubator-nuttx-apps/pull/1034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[incubator-nuttx-apps] branch master updated: Simplify DEFAULT_SMALL usage in Kconfig

2022-03-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 82b94fc Simplify DEFAULT_SMALL

[incubator-nuttx] branch master updated (224241b -> 2197fb2)

2022-03-01 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 224241b boards: esp32-devkitc: Increase INIT_STACKSIZE to 3072 in smp/defconfig add 2197fb2 fs/romf

[GitHub] [incubator-nuttx] acassis merged pull request #5653: fs/romfs: fix read file mismatch when the length of file name is 16

2022-03-01 Thread GitBox
acassis merged pull request #5653: URL: https://github.com/apache/incubator-nuttx/pull/5653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5649: Revert "sched: Don't duplicate caller file handler when creating kernel thread"

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #5649: URL: https://github.com/apache/incubator-nuttx/pull/5649#issuecomment-1055517699 > Do we have a task (issue) to remove the proxy thread? No, it's on my TODO list, could you create an issue? -- This is an automated message from the Ap

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1032: pwm: Fix issue with directing to "> /dev/null"

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #1032: URL: https://github.com/apache/incubator-nuttx-apps/pull/1032#discussion_r816826696 ## File path: examples/pwm/pwm_main.c ## @@ -307,6 +307,13 @@ static void parse_args(FAR struct pwm_state_s *pwm, int argc, for (i

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #5626: Redirects doesn't work with programs like pwm

2022-03-01 Thread GitBox
pkarashchenko commented on issue #5626: URL: https://github.com/apache/incubator-nuttx/issues/5626#issuecomment-1055508095 @acassis is `CONFIG_FILE_STREAM` set in your configuration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-nuttx] branch master updated (955153a -> 224241b)

2022-03-01 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 955153a boards: sabre-6quad: Add knsh add 224241b boards: esp32-devkitc: Increase INIT_STACKSIZE to 3

[GitHub] [incubator-nuttx] anchao merged pull request #5654: boards: esp32-devkitc: Increase INIT_STACKSIZE to 3072 in smp/defconfig

2022-03-01 Thread GitBox
anchao merged pull request #5654: URL: https://github.com/apache/incubator-nuttx/pull/5654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [incubator-nuttx] anchao commented on pull request #5654: boards: esp32-devkitc: Increase INIT_STACKSIZE to 3072 in smp/defconfig

2022-03-01 Thread GitBox
anchao commented on pull request #5654: URL: https://github.com/apache/incubator-nuttx/pull/5654#issuecomment-1055479507 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[incubator-nuttx] branch master updated: boards: sabre-6quad: Add knsh

2022-03-01 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 955153a boards: sabre-6quad: Add knsh

[GitHub] [incubator-nuttx] acassis merged pull request #5652: boards: sabre-6quad: Add knsh

2022-03-01 Thread GitBox
acassis merged pull request #5652: URL: https://github.com/apache/incubator-nuttx/pull/5652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5648: arch:xtensa: fix sp duplicate reduce in handler enter

2022-03-01 Thread GitBox
pkarashchenko merged pull request #5648: URL: https://github.com/apache/incubator-nuttx/pull/5648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: arch:xtensa: fix sp duplicate reduce in handler enter

2022-03-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a4e93be arch:xtensa: fix sp dup

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #5654: boards: esp32-devkitc: Increase INIT_STACKSIZE to 3072 in smp/defconfig

2022-03-01 Thread GitBox
masayuki2009 opened a new pull request #5654: URL: https://github.com/apache/incubator-nuttx/pull/5654 ## Summary - I noticed that automatic tests sometimes fail - This commit fixes this issue ## Impact - None ## Testing - Tested with QEMU -- This is

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5624: joystick/buttons: Fix the event lose between the invocation of poll

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5624: URL: https://github.com/apache/incubator-nuttx/pull/5624#discussion_r816697411 ## File path: drivers/input/ajoystick.c ## @@ -722,6 +720,19 @@ static int ajoy_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5637: URL: https://github.com/apache/incubator-nuttx/pull/5637#issuecomment-1055339261 ``` arm-none-eabi-ld: error: /github/workspace/sources/nuttx/nuttx uses VFP register arguments, /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/9.2.1/lib

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5646: sim: Simplify boards and arch's Makefile

2022-03-01 Thread GitBox
pkarashchenko merged pull request #5646: URL: https://github.com/apache/incubator-nuttx/pull/5646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (ddde410 -> a8ab090)

2022-03-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ddde410 Revert "sched: Don't duplicate caller file handler when creating kernel thread" add a8

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5646: sim: Simplify boards and arch's Makefile

2022-03-01 Thread GitBox
pkarashchenko commented on a change in pull request #5646: URL: https://github.com/apache/incubator-nuttx/pull/5646#discussion_r816686341 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,8 +209,4 @@ ifeq ($(CONFIG_SIM_M32),y) LDFLAGS += -m32 LDMODULEFLAGS +=

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5649: Revert "sched: Don't duplicate caller file handler when creating kernel thread"

2022-03-01 Thread GitBox
pkarashchenko merged pull request #5649: URL: https://github.com/apache/incubator-nuttx/pull/5649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (7b36611 -> ddde410)

2022-03-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7b36611 boards/sparc: Remove HOSTCC related flags from Make.defs add ddde410 Revert "sched: Do

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5652: boards: sabre-6quad: Add knsh

2022-03-01 Thread GitBox
masayuki2009 commented on pull request #5652: URL: https://github.com/apache/incubator-nuttx/pull/5652#issuecomment-1055328315 @anchao This is a semihosting version. So you don't need an NFS server to test BUILD_KERNEL. -- This is an automated message from the Apache Gi

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #5653: fs/romfs: fix read file mismatch when the length of file name is 16

2022-03-01 Thread GitBox
Donny9 opened a new pull request #5653: URL: https://github.com/apache/incubator-nuttx/pull/5653 ## Summary fs/romfs: fix read file mismatch when the length of file name is 16 romfs rules: file name must end with '\0' Signed-off-by: Jiuzhu Dong ## Impact Acces

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #5652: boards: sabre-6quad: Add knsh

2022-03-01 Thread GitBox
masayuki2009 opened a new pull request #5652: URL: https://github.com/apache/incubator-nuttx/pull/5652 ## Summary - Add sabre-6quad:knsh to test BUILD_KERNEL with qemu - Update README.txt to run the nuttx with qemu ## Impact - None ## Testing - Tested wi

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5651: LICENSE: document licenses from boards folders

2022-03-01 Thread GitBox
jerpelea opened a new pull request #5651: URL: https://github.com/apache/incubator-nuttx/pull/5651 ## Summary LICENSE: document licenses from boards folders ## Impact LICENSE ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055299126 Yeah, but that is include order dependant. We can merge this change if that solves your issue, but in general I'm against some partial solutions. -- This is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5650: armv7-a/armv7-r:cache: modify hardcode in cache set/way operation

2022-03-01 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5650: URL: https://github.com/apache/incubator-nuttx/pull/5650#discussion_r816555456 ## File path: arch/arm/src/armv7-a/cp15_clean_dcache_all.S ## @@ -91,19 +91,32 @@ cp15_clean_dcache_all: + push{r4,

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055206321 > But `assert.h` includes `#include ` and `UNUSED` is defined in `compiler.h` so the redefinition problem will still exists. I mean the problem will not

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055206321 > But `assert.h` includes `#include ` and `UNUSED` is defined in `compiler.h` so the redefinition problem will still exists. I mean the problem will not

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
xiaoxiang781216 commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055206321 > But `assert.h` includes `#include ` and `UNUSED` is defined in `compiler.h` so the redefinition problem will still exists. I mean the problem will not be solv

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5644: boards/sparc: Remove HOSTCC related flags from Make.defs

2022-03-01 Thread GitBox
pkarashchenko merged pull request #5644: URL: https://github.com/apache/incubator-nuttx/pull/5644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: boards/sparc: Remove HOSTCC related flags from Make.defs

2022-03-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7b36611 boards/sparc: Remove HO

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5647: assert.h: Don't use UNUSED macro since it's very easy happen conflict

2022-03-01 Thread GitBox
pkarashchenko commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055191249 It's a chicken-egg problem. We meet similar with OpenSBI integration. Really do not know what is the best solution. -- This is an automated message from the Apa

  1   2   >