xiaoxiang781216 commented on pull request #5647: URL: https://github.com/apache/incubator-nuttx/pull/5647#issuecomment-1055694034
> The another option is to add `#undef UNUSED` at the beginning of `nuttx/compiler.h` It only work when we include the third party header file first and then assert.h, but the order is reverse in our case, that's why I create this patch. Since UNUSED is normally used inside source file. assert.h is the only exception by a recent change: https://github.com/apache/incubator-nuttx/commit/5f3a98b5a8d39a7a9ee1823c6f7eaf05b1822ad7 It's always good to avoid reference UNUSED in header files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
