[GitHub] [incubator-nuttx] jpaali opened a new pull request #4606: Add support for MT25Q1G SPI NOR

2021-09-23 Thread GitBox
jpaali opened a new pull request #4606: URL: https://github.com/apache/incubator-nuttx/pull/4606 ## Summary Adds support for MT25Q1G SPI NOR to drivers/mtd/m25px.c ## Impact ## Testing Tested on Microchip Polarfire ICICLE board. -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4575: net/devif: Simplify the logic in the error path of devif_callback_alloc

2021-09-23 Thread GitBox
xiaoxiang781216 commented on pull request #4575: URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-926378610 > > @a-lunev but my change make the fail path more simple. > > @xiaoxiang781216 There are pros and cons of each way. > The existing code seems having bet

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4599: sched:tcb_s:rearrange sched_priority/int_priority to word align

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4599: URL: https://github.com/apache/incubator-nuttx/pull/4599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: sched:tcb_s:rearrange sched_priority/int_priority to word align

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a41f92d sched:tcb_s:rearrange sched

[incubator-nuttx] branch master updated: net/tcp: sanity check for the listen address

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c132e5b net/tcp: sanity check for t

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx-apps] branch master updated: wapi: add 5g channel map in wapi

2021-09-23 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ab3cca4 wapi: add 5g channel map

[GitHub] [incubator-nuttx-apps] anchao merged pull request #856: wapi: add 5g channel map in wapi

2021-09-23 Thread GitBox
anchao merged pull request #856: URL: https://github.com/apache/incubator-nuttx-apps/pull/856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [incubator-nuttx-apps] anchao commented on pull request #856: wapi: add 5g channel map in wapi

2021-09-23 Thread GitBox
anchao commented on pull request #856: URL: https://github.com/apache/incubator-nuttx-apps/pull/856#issuecomment-926363416 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[incubator-nuttx] branch master updated (5a2510d -> 4ac3044)

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 5a2510d net/dup: only start tcp monitor on INET domain add 8816f21 tools: Add new make targets for

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715298577 ## File path: tools/Makefile.unix ## @@ -459,6 +459,26 @@ endif download: $(BIN) $(call DOWNLOAD, $<) +# bootloader +# +# Some

[GitHub] [incubator-nuttx] FASTSHIFT commented on a change in pull request #4595: libc/misc: add lib_glob

2021-09-23 Thread GitBox
FASTSHIFT commented on a change in pull request #4595: URL: https://github.com/apache/incubator-nuttx/pull/4595#discussion_r715295064 ## File path: libs/libc/misc/lib_glob.c ## @@ -0,0 +1,525 @@ +/ + *

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
anchao commented on a change in pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#discussion_r715287743 ## File path: net/tcp/tcp_listen.c ## @@ -100,9 +104,35 @@ FAR struct tcp_conn_s *tcp_findlistener(uint16_t portno) if (conn && conn->lport

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715282816 ## File path: tools/Makefile.unix ## @@ -459,6 +459,26 @@ endif download: $(BIN) $(call DOWNLOAD, $<) +# bootloader +# +# Some arc

[GitHub] [incubator-nuttx] a-lunev commented on pull request #4575: net/devif: Simplify the logic in the error path of devif_callback_alloc

2021-09-23 Thread GitBox
a-lunev commented on pull request #4575: URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-926305154 > @a-lunev but my change make the fail path more simple. @xiaoxiang781216 There are pros and cons of each way. The existing code seems having better performance

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715282816 ## File path: tools/Makefile.unix ## @@ -459,6 +459,26 @@ endif download: $(BIN) $(call DOWNLOAD, $<) +# bootloader +# +# Some arc

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715282816 ## File path: tools/Makefile.unix ## @@ -459,6 +459,26 @@ endif download: $(BIN) $(call DOWNLOAD, $<) +# bootloader +# +# Some arc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715277909 ## File path: tools/Makefile.unix ## @@ -459,6 +459,26 @@ endif download: $(BIN) $(call DOWNLOAD, $<) +# bootloader +# +# Some

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
gustavonihei commented on pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#issuecomment-926293130 > > The changes seem fine, but I may lack the knowledge on the TCP stack for properly evaluating them. > > Just a question: although it may be a security concern,

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715271597 ## File path: tools/esp32/Bootloader.mk ## @@ -0,0 +1,123 @@ + +#

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
xiaoxiang781216 commented on pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#issuecomment-926290037 > The changes seem fine, but I may lack the knowledge on the TCP stack for properly evaluating them. > Just a question: although it may be a security concern,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#discussion_r715268741 ## File path: net/tcp/tcp_listen.c ## @@ -100,9 +104,35 @@ FAR struct tcp_conn_s *tcp_findlistener(uint16_t portno) if (conn && con

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4602: net/dup: only start tcp monitor on INET domain

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4602: URL: https://github.com/apache/incubator-nuttx/pull/4602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: net/dup: only start tcp monitor on INET domain

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5a2510d net/dup: only start tcp mon

[incubator-nuttx] 01/02: risc-v/esp32-c3: Remove _s of non static variables from esp32c3_rt_timer.c

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit d0e7d7b77fbcd0233904e802e574bf12efd9276a Author: Sara Souza AuthorDate: Thu Sep 23 11:23:02 2021 -0300

[incubator-nuttx] branch master updated (f2f2040 -> 9c2c5d3)

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f2f2040 esp32_spiram/psram/himem: Add and fix the files' sections. new d0e7d7b risc-v/esp32-c3: Re

[incubator-nuttx] 02/02: risc-v/esp32-c3: fix pid initiatialization on esp32c3_rt_timer.c

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 9c2c5d39194cdfa00990a413da00306ba53854fe Author: Sara Souza AuthorDate: Thu Sep 23 11:27:06 2021 -0300

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4605: risc-v/esp32-c3: improvements and fix to esp32c3_rt_timer.c

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4605: URL: https://github.com/apache/incubator-nuttx/pull/4605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604#discussion_r715267448 ## File path: tools/esp32/Bootloader.mk ## @@ -0,0 +1,123 @@ +

[incubator-nuttx-website] branch asf-site updated: Publishing web: ea6fce84bf8202600a0318215864afe272c81f07 docs: f2f2040c44e3e23ca5c8db9bd0a6fdf94b1db4e5

2021-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9580ac7 Publishing web

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715212291 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715211505 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715210811 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715210569 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715209901 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715209125 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715207478 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715207173 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715204713 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715204138 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715201425 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715195801 ## File path: arch/xtensa/src/esp32/esp32_ble_adapter.c ## @@ -0,0 +1,2814 @@ +/*

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715192255 ## File path: arch/xtensa/src/esp32/esp32_ble.h ## @@ -0,0 +1,50 @@ +/***

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715191842 ## File path: arch/xtensa/src/esp32/esp32_ble.h ## @@ -0,0 +1,50 @@ +/***

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715190971 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715190745 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715189974 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715189178 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715188907 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715187918 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715186489 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715187316 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715186489 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715184105 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715183797 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715183163 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715182646 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715178207 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715181634 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715180456 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715179493 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715178207 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715177050 ## File path: arch/xtensa/src/esp32/esp32_ble.c ## @@ -0,0 +1,344 @@ +/**

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715175243 ## File path: arch/xtensa/src/esp32/Make.defs ## @@ -229,7 +229,13 @@ INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELI

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715175243 ## File path: arch/xtensa/src/esp32/Make.defs ## @@ -229,7 +229,13 @@ INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELI

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4509: esp32: Add initial support to Bluetooth Low Energy

2021-09-23 Thread GitBox
saramonteiro commented on a change in pull request #4509: URL: https://github.com/apache/incubator-nuttx/pull/4509#discussion_r715174441 ## File path: arch/xtensa/src/esp32/Make.defs ## @@ -229,7 +229,13 @@ INCLUDES += $(shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)$(DELIM)chip$(DELI

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #4605: risc-v/esp32-c3: improvements and fix to esp32c3_rt_timer.c

2021-09-23 Thread GitBox
saramonteiro opened a new pull request #4605: URL: https://github.com/apache/incubator-nuttx/pull/4605 ## Summary This PR: 1. Removes `_s` of non static variables from esp32c3_rt_timer.c. 2. Fix `pid` variable initialization. ## Impact Prevent a potential bug i

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
gustavonihei commented on pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#issuecomment-926120995 The changes seem fine, but I may lack the knowledge on the TCP stack for properly evaluating them. Just a question: although it may be a security concern, isn't i

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603#discussion_r715110875 ## File path: net/tcp/tcp_listen.c ## @@ -100,9 +104,35 @@ FAR struct tcp_conn_s *tcp_findlistener(uint16_t portno) if (conn && conn->

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #4604: xtensa/esp32: Enable build system to download or build binaries from source

2021-09-23 Thread GitBox
gustavonihei opened a new pull request #4604: URL: https://github.com/apache/incubator-nuttx/pull/4604 ## Summary This PR intends to add a new feature to the ESP32 build system for easing the provisioning of prebuilt binaries. Depending on the choice of *Application Image Format*, the

[GitHub] [incubator-nuttx] anchao opened a new pull request #4603: [SECURITY]net/tcp: sanity check for the listen address

2021-09-23 Thread GitBox
anchao opened a new pull request #4603: URL: https://github.com/apache/incubator-nuttx/pull/4603 ## Summary net/tcp: sanity check for the listen address TCP stack only checks the visitor's port number on listening port, which will cause external links to arbitrarily access l

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4570: esp32_spiflash.c: Correctly disable APP's CPU cache.

2021-09-23 Thread GitBox
Ouss4 commented on pull request #4570: URL: https://github.com/apache/incubator-nuttx/pull/4570#issuecomment-925891949 @masayuki2009 sorry I didn't see your comment earlier. Yes, I'm working on this. The APP CPU needs to be properly paused when the cache is disabled. -- This is an auto

[GitHub] [incubator-nuttx] anchao opened a new pull request #4602: net/dup: only start tcp monitor on INET domain

2021-09-23 Thread GitBox
anchao opened a new pull request #4602: URL: https://github.com/apache/incubator-nuttx/pull/4602 ## Summary net/dup: only start tcp monitor on INET domain invaild fd dup if the socket with local family work on stream mode. socket(AF_LOCAL, SOCK_STREAM, 0); ## Impa

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4595: libc/misc: add lib_glob

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4595: URL: https://github.com/apache/incubator-nuttx/pull/4595#discussion_r714733523 ## File path: libs/libc/misc/lib_glob.c ## @@ -0,0 +1,525 @@ +/ +

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #566: WIP: crypto: Initial support for Mbed TLS

2021-09-23 Thread GitBox
gustavonihei commented on pull request #566: URL: https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-925788825 There was a conflict on `crypto/Makefile`, which I got to resolve via the web UI. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4595: libc/misc: add lib_glob

2021-09-23 Thread GitBox
gustavonihei commented on a change in pull request #4595: URL: https://github.com/apache/incubator-nuttx/pull/4595#discussion_r714733523 ## File path: libs/libc/misc/lib_glob.c ## @@ -0,0 +1,525 @@ +/ +

[GitHub] [incubator-nuttx-apps] liuyang34 opened a new pull request #856: wapi: add 5g channel map in wapi

2021-09-23 Thread GitBox
liuyang34 opened a new pull request #856: URL: https://github.com/apache/incubator-nuttx-apps/pull/856 Signed-off-by: liuyang34 Change-Id: I6b113f2f16ddbd2f4d3a46fd691834e5287e7016 ## Summary scan result only process channel 1~14, and no process for 5g channel ## Impact

[incubator-nuttx] 01/03: esp32_spiflash.c/esp32_spiram.c: Remove some unused macros/functions/variables.

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 2834d2a46f198933d8671227208d1a8e8724d58b Author: Abdelatif Guettouche AuthorDate: Tue Sep 21 14:34:32 2021 +

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4600: esp32_spiflash.c/esp32_spiram.c: Remove some unused macros/functions/variables.

2021-09-23 Thread GitBox
xiaoxiang781216 merged pull request #4600: URL: https://github.com/apache/incubator-nuttx/pull/4600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] 02/03: esp32_spiram.c: Remove esp_himem_reserved_area_size from esp32_spiram.c file. This function is already defined in esp_himem and is used only when that file is built. We don't

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3d8a6fb676d6c5453e44469e20925374de01e06e Author: Abdelatif Guettouche AuthorDate: Wed Sep 22 17:21:40 2021 +

[incubator-nuttx] 03/03: esp32_spiram/psram/himem: Add and fix the files' sections.

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit f2f2040c44e3e23ca5c8db9bd0a6fdf94b1db4e5 Author: Abdelatif Guettouche AuthorDate: Wed Sep 22 17:20:30 2021 +

[incubator-nuttx] branch master updated (47c60b2 -> f2f2040)

2021-09-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 47c60b2 arch/arm: Remove -march and -mtune new 2834d2a esp32_spiflash.c/esp32_spiram.c: Remove som

[GitHub] [incubator-nuttx] jerpelea merged pull request #4601: arch/arm: Remove -march and -mtune

2021-09-23 Thread GitBox
jerpelea merged pull request #4601: URL: https://github.com/apache/incubator-nuttx/pull/4601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[incubator-nuttx] branch master updated: arch/arm: Remove -march and -mtune

2021-09-23 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 47c60b2 arch/arm: Remove -march and

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4601: arch/arm: Remove -march and -mtune

2021-09-23 Thread GitBox
xiaoxiang781216 opened a new pull request #4601: URL: https://github.com/apache/incubator-nuttx/pull/4601 ## Summary since -mcpu is enough https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58869 ## Impact Should be same as before ## Testing -- This is an automated m

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #4600: esp32_spiflash.c/esp32_spiram.c: Remove some unused macros/functions/variables.

2021-09-23 Thread GitBox
Ouss4 opened a new pull request #4600: URL: https://github.com/apache/incubator-nuttx/pull/4600 ## Summary Remove unused macros/functions/variables. ## Impact N/A ## Testing ESP32 defconfigs -- This is an automated message from the Apache Git Service. To respond to the