[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr

2020-12-14 Thread GitBox
xiaoxiang781216 opened a new pull request #523: URL: https://github.com/apache/incubator-nuttx-apps/pull/523 ## Summary not really need since these file stream should be opened automatically. Need work with https://github.com/apache/incubator-nuttx/pull/2540. See the discussion here

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2540: fs: Skip call fs_checkfd if fd < 3 in fs_fdopen

2020-12-14 Thread GitBox
xiaoxiang781216 opened a new pull request #2540: URL: https://github.com/apache/incubator-nuttx/pull/2540 ## Summary since the stdin, stdout and stderr may initialize later in userspace if CONFIG_DEV_CONSOLE isn't enabled. Note: it isn't bigger issue here to skip the check because

[incubator-nuttx] branch master updated (3adadbe -> 2ccc37f)

2020-12-14 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3adadbe arch/stm32: Fix nxstyle errors add 2ccc37f Fix syntax for BOARD_GCLK*_RUN_IN_STANDBY and

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2527: Fix syntax for BOARD_GCLK*_RUN_IN_STANDBY and BOARD_GCLK*_OUTPUT_ENABLE

2020-12-14 Thread GitBox
Ouss4 merged pull request #2527: URL: https://github.com/apache/incubator-nuttx/pull/2527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2529: version.sh does not use the "latest" tag just most recent

2020-12-14 Thread GitBox
xiaoxiang781216 commented on issue #2529: URL: https://github.com/apache/incubator-nuttx/issues/2529#issuecomment-745108528 @anchao could you take a look? the code is initially written by him. This is an automated message fr

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #410: Add LTP support

2020-12-14 Thread GitBox
jerpelea commented on pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-745099683 LGTM This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] yamt opened a new pull request #2539: esp32: Fix a typo. ESP_SPIRAM_BOOT_INIT -> ESP32_SPIRAM_BOOT_INIT

2020-12-14 Thread GitBox
yamt opened a new pull request #2539: URL: https://github.com/apache/incubator-nuttx/pull/2539 ## Summary Fix a typo in Kconfig ## Impact esp32 ## Testing make oldconfig with a few combinations of options T

[GitHub] [incubator-nuttx] jerpelea merged pull request #2535: arch/stm32: Fix nxstyle errors

2020-12-14 Thread GitBox
jerpelea merged pull request #2535: URL: https://github.com/apache/incubator-nuttx/pull/2535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated: arch/stm32: Fix nxstyle errors

2020-12-14 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3adadbe arch/stm32: Fix nxstyle erro

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support

2020-12-14 Thread GitBox
xiaoxiang781216 commented on pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-745034765 LGTM, @btashton could you review again? This is an automated message from the Apache Git Ser

[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
ttnie commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543025307 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,117 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Version 2.0

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543023140 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,117 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Ve

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543022725 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,117 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Ve

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543022554 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,117 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Ve

[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
ttnie commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543016703 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,113 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Version 2.0

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2538: sched: pthread: Fix potential bugs in pthread_condclockwait.c

2020-12-14 Thread GitBox
xiaoxiang781216 merged pull request #2538: URL: https://github.com/apache/incubator-nuttx/pull/2538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (3ec7cd1 -> 8ba67b7)

2020-12-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3ec7cd1 boards/arm/imxrt/teensy-4.x: CDC-ACM console support add 8ba67b7 sched: pthread: Fix poten

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#discussion_r543011793 ## File path: arch/arm/src/arm/arm_initialstate.c ## @@ -75,8 +75,10 @@ void up_initial_state(struct tcb_s *tcb) if (tcb->pid == 0)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#discussion_r543011793 ## File path: arch/arm/src/arm/arm_initialstate.c ## @@ -75,8 +75,10 @@ void up_initial_state(struct tcb_s *tcb) if (tcb->pid == 0)

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2538: sched: pthread: Fix potential bugs in pthread_condclockwait.c

2020-12-14 Thread GitBox
masayuki2009 opened a new pull request #2538: URL: https://github.com/apache/incubator-nuttx/pull/2538 ## Impact - I found potential bugs in pthread_condclockwait.c - Actually, sched_unlock() and wd_cancel() were misplaced. - This commit fixes this issue - pthread_cond_cl

[GitHub] [incubator-nuttx] jbampton opened a new pull request #2537: feat: add a GitHub action to lint the YAML files

2020-12-14 Thread GitBox
jbampton opened a new pull request #2537: URL: https://github.com/apache/incubator-nuttx/pull/2537 Lint some YAML Add a `.yamllint` config file This is an automated message from the Apache Git Service. To r

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1d65847df020becad8aaf7f02f01a93bc9e03ba9 docs: 3ec7cd186a813624facf9ca72bddf19311875bd4

2020-12-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new dde3f14 Publishing web

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2277: Heap is defined in linkerscript for FLAT builds.

2020-12-14 Thread GitBox
hartmannathan commented on pull request #2277: URL: https://github.com/apache/incubator-nuttx/pull/2277#issuecomment-744806713 > Hi @hartmannathan, > I am sorry that there is no progress on this, but I have limited free time lately. Hello, @fjpanag , no worries. Thanks for your re

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
masayuki2009 commented on pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#issuecomment-744793170 > @masayuki2009 could you try again? I just run the patch with sabre-6quad:smp plus QEMU, ostest and smp can run sucessfully. @xiaoxiang781216 All tests h

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
masayuki2009 commented on a change in pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#discussion_r542902265 ## File path: arch/arm/src/arm/arm_initialstate.c ## @@ -75,8 +75,10 @@ void up_initial_state(struct tcb_s *tcb) if (tcb->pid == 0)

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
masayuki2009 commented on pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#issuecomment-744759674 > @masayuki2009 could you try again? I just run the patch with sabre-6quad:smp plus QEMU, ostest and smp can run sucessfully. @xiaoxiang781216 OK. I'll ch

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #2536: xtensa/esp32: fixes enable int function and gets apb clk frequency through function

2020-12-14 Thread GitBox
saramonteiro commented on pull request #2536: URL: https://github.com/apache/incubator-nuttx/pull/2536#issuecomment-744709851 Expect to fail: nuttx/arch/xtensa/src/esp32/hardware/esp32_soc.h:455:11: error: Mixed case identifier found

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2536: xtensa/esp32: fixes enable int function and gets apb clk frequency through function

2020-12-14 Thread GitBox
saramonteiro opened a new pull request #2536: URL: https://github.com/apache/incubator-nuttx/pull/2536 ## Summary Fix: It's missing a configuration in the esp32_tim_enableint and esp32_tim_disableint Improvement: Get the APB clock frequency from a function instea

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors

2020-12-14 Thread GitBox
hartmannathan commented on a change in pull request #2535: URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542616629 ## File path: arch/arm/src/stm32/stm32_usbhost.h ## @@ -49,16 +49,17 @@ #include "hardware/stm32fx_otgfs.h" #include "hardware/stm32_o

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2277: Heap is defined in linkerscript for FLAT builds.

2020-12-14 Thread GitBox
fjpanag commented on pull request #2277: URL: https://github.com/apache/incubator-nuttx/pull/2277#issuecomment-744558534 Hi @hartmannathan, I am sorry that there is no progress on this, but I have limited free time lately. I am thinking of having the number of heap regions defined

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2535: URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542513288 ## File path: arch/arm/src/stm32/stm32_usbhost.h ## @@ -255,33 +252,37 @@ extern "C" #define EXTERN extern #endif -/**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2535: URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542512982 ## File path: arch/arm/src/stm32/stm32_usbhost.h ## @@ -49,16 +49,17 @@ #include "hardware/stm32fx_otgfs.h" #include "hardware/stm32

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2535: arch/stm32: Fix nxstyle errors

2020-12-14 Thread GitBox
hartmannathan opened a new pull request #2535: URL: https://github.com/apache/incubator-nuttx/pull/2535 ## Summary arch/arm/src/stm32/stm32_usbhost.h: * Fix nxstyle errors. ## Impact Removes nxstyle errors. ## Testing nxstyle --

[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
jerpelea merged pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[incubator-nuttx-apps] branch master updated: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 16c6e1f system: nxplayer and nx

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542427013 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542427013 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2533: URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542406930 ## File path: sched/mqueue/mqueue.h ## @@ -53,12 +53,6 @@ #define NUM_MSG_DESCRIPTORS 4 -/* This defines the number of messages to s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2533: URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542406930 ## File path: sched/mqueue/mqueue.h ## @@ -53,12 +53,6 @@ #define NUM_MSG_DESCRIPTORS 4 -/* This defines the number of messages to s

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #2533: URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542402116 ## File path: sched/mqueue/mqueue.h ## @@ -53,12 +53,6 @@ #define NUM_MSG_DESCRIPTORS 4 -/* This defines the number of messages to set asi

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542395630 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542395630 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542395630 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2077: Fix the stack color failure when the thread stack setup through up_use_stack

2020-12-14 Thread GitBox
xiaoxiang781216 commented on pull request #2077: URL: https://github.com/apache/incubator-nuttx/pull/2077#issuecomment-75714 @masayuki2009 could you try again? I just run the patch with sabre-6quad:smp plus QEMU, ostest and smp can run sucessfully.

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable

2020-12-14 Thread GitBox
acassis commented on a change in pull request #2533: URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542386036 ## File path: sched/mqueue/mqueue.h ## @@ -53,12 +53,6 @@ #define NUM_MSG_DESCRIPTORS 4 -/* This defines the number of messages to set aside

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2534: libc: Implement getppid

2020-12-14 Thread GitBox
xiaoxiang781216 opened a new pull request #2534: URL: https://github.com/apache/incubator-nuttx/pull/2534 ## Summary as specified here: https://pubs.opengroup.org/onlinepubs/009695399/functions/getppid.html ## Impact ## Testing --

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542380844 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542376288 ## File path: system/nxrecorder/nxrecorder.c ## @@ -844,9 +845,19 @@ int nxrecorder_recordraw(FAR struct nxrecorder_s *precorder,

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542376054 ## File path: system/nxplayer/nxplayer.c ## @@ -1932,9 +1933,19 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer,

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542375697 ## File path: system/nxplayer/nxplayer.c ## @@ -1932,9 +1933,19 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer,

[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo edited a comment on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-744429948 What about Telnet. If networking were enabled, would Telnet not also fail in exactly the same way? This solution cannot be implemented in a single ap

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542372434 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542372340 ## File path: system/nxplayer/nxplayer.c ## @@ -1932,9 +1933,19 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer,

[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-744429948 What about Telnet. If networking were enabled, would Telnet not also fail in exactly the same way? This solution cannot be implemented in a single applicati

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542368040 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate)

[GitHub] [incubator-nuttx-apps] ghn-certi commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
ghn-certi commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542355231 ## File path: system/nxplayer/nxplayer.c ## @@ -1932,9 +1933,19 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer,

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542348706 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
jerpelea commented on a change in pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#discussion_r542352489 ## File path: system/nxplayer/nxplayer.c ## @@ -1932,9 +1933,19 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer, i

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
jerpelea commented on pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#issuecomment-744410716 @xiaoxiang781216 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542348706 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
patacongo commented on a change in pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#discussion_r542348706 ## File path: nshlib/nsh_usbconsole.c ## @@ -88,15 +88,16 @@ static void nsh_configstdio(int fd, FAR struct console_stdio_s *pstate) dup

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support

2020-12-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r542341749 ## File path: testing/ltp/Makefile ## @@ -0,0 +1,113 @@ + +# apps/testing/ltp/ltp/Makefile +# +# Licensed under the Apache License, Ve

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 commented on pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#issuecomment-744388450 @jerpelea done. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
jerpelea commented on pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522#issuecomment-744380150 @xiaoxiang781216 please fix the errors This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2526: boards/arm/imxrt/teensy-4.x: CDC-ACM console support

2020-12-14 Thread GitBox
xiaoxiang781216 merged pull request #2526: URL: https://github.com/apache/incubator-nuttx/pull/2526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: boards/arm/imxrt/teensy-4.x: CDC-ACM console support

2020-12-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3ec7cd1 boards/arm/imxrt/teensy-4.x

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 merged pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0c3ee06 nshlib: Fix nsh_usbcon

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-744340606 Thanks @michallenc I will merge both patch now. This is an automated message from the Apache

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #522: system: nxplayer and nxrecorder shouldn't hardcode message length to 16

2020-12-14 Thread GitBox
xiaoxiang781216 opened a new pull request #522: URL: https://github.com/apache/incubator-nuttx-apps/pull/522 ## Summary the audio driver may config a very large buffer count, so let's adjust the message queue length dynamically. ## Impact Should no impact on the normal case.

[GitHub] [incubator-nuttx-apps] michallenc commented on pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
michallenc commented on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-744331133 > @michallenc could you try this patch with your new config([apache/incubator-nuttx#2526](https://github.com/apache/incubator-nuttx/pull/2526))? @xiaoxiang7

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #521: nshlib: Fix nsh_usbconsole.c

2020-12-14 Thread GitBox
xiaoxiang781216 commented on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-744320682 @michallenc could you try this patch with your new config(https://github.com/apache/incubator-nuttx/pull/2526)?

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2533: Make the number of queue/signal used by irq handler configurable

2020-12-14 Thread GitBox
xiaoxiang781216 opened a new pull request #2533: URL: https://github.com/apache/incubator-nuttx/pull/2533 ## Summary these structure can't be dynamically allocated in any irq handler so it's important to let the user extend the number as needed ## Impact No, since the default v

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2531: boards: stm32f4discovery: Update usbnsh/defconfig

2020-12-14 Thread GitBox
xiaoxiang781216 merged pull request #2531: URL: https://github.com/apache/incubator-nuttx/pull/2531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (98be50a -> 1aa7f34)

2020-12-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 98be50a libc: Implement posix_fallocate add 1aa7f34 boards: stm32f4discovery: Update usbnsh/defcon

[incubator-nuttx] branch master updated: libc: Implement posix_fallocate

2020-12-14 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 98be50a libc: Implement posix_falloc

[GitHub] [incubator-nuttx] jerpelea merged pull request #2530: libc: Implement posix_fallocate

2020-12-14 Thread GitBox
jerpelea merged pull request #2530: URL: https://github.com/apache/incubator-nuttx/pull/2530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above