This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new e4cddb1 wapi/conf: convert mac
xiaoxiang781216 merged pull request #517:
URL: https://github.com/apache/incubator-nuttx-apps/pull/517
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on pull request #517:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/517#issuecomment-743711892
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 commented on a change in pull request #2522:
URL: https://github.com/apache/incubator-nuttx/pull/2522#discussion_r541510110
##
File path: include/nuttx/efuse/esp_efuse.h
##
@@ -0,0 +1,184 @@
+/*
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new e36fb59 Publishing web
patacongo commented on pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#issuecomment-743446674
There is some naming that should be made consistent too. In the TCB, the
pid field should be called tid, for example.
---
hartmannathan commented on pull request #2473:
URL: https://github.com/apache/incubator-nuttx/pull/2473#issuecomment-743371393
@davids5 , @raiden00pl , Thank you for your input. I've finished this up and
it's ready for review.
--
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 3864912 arch/stm32: Fix nxstyle error
acassis merged pull request #2521:
URL: https://github.com/apache/incubator-nuttx/pull/2521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
acassis opened a new pull request #2522:
URL: https://github.com/apache/incubator-nuttx/pull/2522
## Summary
Add ESP32 EFUSE char driver
## Impact
ESP32 users will be able to read/burn the EFUSEs
## Testing
Tested on esp32-wrover-kit board
---
hartmannathan opened a new pull request #2521:
URL: https://github.com/apache/incubator-nuttx/pull/2521
## Summary
arch/arm/src/stm32/stm32l15xxx_rtcc.c:
* Fix nxstyle errors.
## Impact
Removes nxstyle errors.
## Testing
nxstyle
---
hartmannathan commented on pull request #2488:
URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-743234459
> Have you checked, if the FreeBSD and Linux versions are different from
each other in some subtle way? We cannot completely ignore Solaris precedent
(and others w
xiaoxiang781216 merged pull request #518:
URL: https://github.com/apache/incubator-nuttx-apps/pull/518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 3d42c64 fix build bread if CON
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 7962179 fix build break with CONFIG
xiaoxiang781216 merged pull request #2520:
URL: https://github.com/apache/incubator-nuttx/pull/2520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 commented on a change in pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#discussion_r540951299
##
File path: sched/task/task_getpid.c
##
@@ -95,11 +95,17 @@ pid_t getpid(void)
if (rtcb->task_state == TSTATE_TASK_RUNNING)
xiaoxiang781216 commented on a change in pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#discussion_r540951299
##
File path: sched/task/task_getpid.c
##
@@ -95,11 +95,17 @@ pid_t getpid(void)
if (rtcb->task_state == TSTATE_TASK_RUNNING)
patacongo commented on a change in pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#discussion_r540950040
##
File path: sched/task/task_getpid.c
##
@@ -95,11 +95,17 @@ pid_t getpid(void)
if (rtcb->task_state == TSTATE_TASK_RUNNING)
xiaoxiang781216 commented on pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#issuecomment-743190424
> This line in pthread.h needs to change too:
>
> #define pthread_self() ((pthread_t)getpid())
>
> Please review all uses of getpid() in the OS and m
xiaoxiang781216 commented on a change in pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#discussion_r540943083
##
File path: sched/task/task_getpid.c
##
@@ -95,11 +95,17 @@ pid_t getpid(void)
if (rtcb->task_state == TSTATE_TASK_RUNNING)
anchao commented on pull request #517:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/517#issuecomment-743189621
apps/wireless/wapi/src/util.c:79:6: error: Mixed case identifier found
not a real error, mixed case from cjson call
---
patacongo commented on issue #2499:
URL:
https://github.com/apache/incubator-nuttx/issues/2499#issuecomment-743187288
>
>
> @patacongo I provide a fix here: #2518, do you think it's reasonable? If
it's OK, I will review all getpid caller and change to getthid as needed.
It l
patacongo commented on a change in pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#discussion_r540937984
##
File path: sched/task/task_getpid.c
##
@@ -95,11 +95,17 @@ pid_t getpid(void)
if (rtcb->task_state == TSTATE_TASK_RUNNING)
patacongo commented on pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518#issuecomment-743184614
This line in pthread.h needs to change too:
#define pthread_self() ((pthread_t)getpid())
Please review all uses of getpid() in the OS and make sure that th
Dan-guanghua opened a new pull request #518:
URL: https://github.com/apache/incubator-nuttx-apps/pull/518
Change-Id: I785f44a4381965df70cbd33faeb2d2e24f6e
Signed-off-by: danguanghua
## Summary
## Impact
## Testing
---
Dan-guanghua opened a new pull request #2520:
URL: https://github.com/apache/incubator-nuttx/pull/2520
N/A
Change-Id: Idfa87031e09f26bd4ca57b5c220ce0ca849f80c4
Signed-off-by: danguanghua
## Summary
## Impact
## Testing
---
xiaoxiang781216 edited a comment on issue #2499:
URL:
https://github.com/apache/incubator-nuttx/issues/2499#issuecomment-743160838
@patacongo I provide a fix here:
https://github.com/apache/incubator-nuttx/pull/2518/, do you think it's
reasonable? If it's OK, I will review all getpid call
davids5 merged pull request #2519:
URL: https://github.com/apache/incubator-nuttx/pull/2519
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 73d4832 arch/arm/imxrt: replace clock
xiaoxiang781216 opened a new pull request #2519:
URL: https://github.com/apache/incubator-nuttx/pull/2519
# Summary
since clock_systimespec doesn't exist anymore
## Impact
Fix the potential link break.
## Testing
-
xiaoxiang781216 commented on issue #2499:
URL:
https://github.com/apache/incubator-nuttx/issues/2499#issuecomment-743160838
@patacongo I provide a fix here:
https://github.com/apache/incubator-nuttx/pull/2518/, do you think it's
resanable? If it's OK, I will review all getpid caller and c
xiaoxiang781216 opened a new pull request #2518:
URL: https://github.com/apache/incubator-nuttx/pull/2518
## Summary
getpid should return the main thread id
gettid should return the current thread id
See the discussion here:
https://github.com/apache/incubator-nuttx/issues/2499
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from d9d6491 drivers/leds/ws2812: optimize reset bytes
new 21cb793 include: nuttx: Fix style warnings i
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 21cb7935c5eb173f6ba9b61522d85019893f54a2
Author: Masayuki Ishikawa
AuthorDate: Mon Dec 7 21:01:28 2020 +0900
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6158b6b77bfb396a45789d0a8f4f0f9fae06ce98
Author: Masayuki Ishikawa
AuthorDate: Mon Dec 7 21:04:16 2020 +0900
xiaoxiang781216 merged pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 commented on pull request #2488:
URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-743152250
> > Because the current implementation only support the nonblocking
behaviour, the right thing is checking GRND_NONBLOCK flag and return return
error directly if
juniskane edited a comment on pull request #2488:
URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-743120568
So the plan is rename current function as `arc4random_buf` and also add the
three argument Linux version of `getrandom`? I guess I have to live with that.
That
juniskane commented on pull request #2488:
URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-743120568
So the plan is rename current function as arc4random_buf and also add the
three argument Linux version? I guess I have to live with that. That way we are
compatible wi
juniskane commented on pull request #2488:
URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-743118817
> Because the current implementation only support the nonblocking behaviour,
the right thing is checking GRND_NONBLOCK flag and return return error directly
if user fo
anchao opened a new pull request #517:
URL: https://github.com/apache/incubator-nuttx-apps/pull/517
## Summary
wapi/conf: convert mac address
## Impact
wapi save_config/reconnect
## Testing
wapi wlan0 save_config
wapi wlan0 reconnect
-
masayuki2009 commented on pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#issuecomment-743113388
@xiaoxiang781216
I've just pushed with -f.
This is an automated message from the Apache Git
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540845173
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE_SE
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540840327
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540821191
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE_SE
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540817299
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE_SE
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540806076
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540805791
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540805534
##
File path: arch/arm/Kconfig
##
@@ -789,6 +789,13 @@ config ARM_THUMB
default n
depends on ARCH_ARMV7A
+config ARM_WFE
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540789772
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define SP
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540787596
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540774339
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define SP
masayuki2009 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540771664
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define SP
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540766144
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define
xiaoxiang781216 commented on a change in pull request #2517:
URL: https://github.com/apache/incubator-nuttx/pull/2517#discussion_r540766144
##
File path: arch/arm/include/spinlock.h
##
@@ -95,6 +95,11 @@
#define SP_DSB(n) __asm__ __volatile__ ("dsb sy" : : : "memory")
#define
56 matches
Mail list logo
